i can't find a mistake in the syntax...?!

Fking

why this line

$result=mysql_query("INSERT INTO buy (markaid, modelid, telinfo, cena, kontakti)
 VALUES ({$_POST['markaid']}, {$_POST['modelid']}, {$_POST['telinfo']}, {$_POST['cena']}, {$_POST['kontakti']})") or die("Invalid query: " . mysql_error());

is giving me this error
Invalid query: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' fsdf, 54354, fdgdf)' at line 2

i tried replacing {$POST['markaid']} and the rest with simple variables ($a={$POST['markaid']} and after that using $a in the query), but it still outputs the same error

laserlight

Since you're inserting strings, you should delimit them with single quotes in the SQL statement.

Also, it would be wise to look into validating the incoming data.

Fking

thank you! But why there is @ in front of some of the variables?

planetsim

Im not sure why the @s are there, they shouldnt be. Secondly why do you have the {} around the variables in the Query? They are pretty useless there.

bradgrafelman

The '@' is an error surpressor.

If the variables aren't set, PHP will throw out a 'Notice: undefined variable'. Using the @ hides that error.

EDIT: I explained why I used the @, but the {}s are my fault. No clue why I used those... go ahead and remove them.

planetsim

@s shouldnt be used to surpress errors, its a bad habit to get into, especially on variables. There are occassions when its Ok to use them on things such as connecting to MySQL, Queries however these should only be added once there in production.

laserlight

If the variables aren't set, PHP will throw out a 'Notice: undefined variable'. Using the @ hides that error.

Hence you should check them with [man]isset/man or [man]empty/man, not simply suppress the error.

bradgrafelman

We'll.... now that I've been everything but burned at the stake for my lazy use of '@', I've decided to remove that post!