[Resolved] database connection

phanh

Hi, I'm new to PHP. Hope someone able to help me with this problem.

-------------db_connect.html---------------
<html>
<head>
<title>User Authentication</title>
</head>
<body>

<p><strong>Username:</strong><br>
<INPUT TYPE = "text" NAME = "username" SIZE = 30></p>

<p><strong>Password:</strong><br>
<INPUT TYPE = "text" NAME = "password" SIZE = 15></p>

--------------db_connect.php--------------
<?php

if(($_POST[username] == " ") || ($_POST[password] == " "))
{
	header("Location: db_connect.html");
	exit;
}

$user = $_POST[username];

$pass = $_POST[password];

//get the connection to the database
$connection = @mysql_connect("localhost", $user, $pass)
	or die(mysql_error());

I receive notice warning about username and password variables.

Use of undefined constant username - assumed 'username' in d:\easyphp1-7\www\db_connect.php on line 3

Use of undefined constant password - assumed 'password' in d:\easyphp1-7\www\db_connect.php on line 3

Can anyone explain why I receive these warnings even though the two variables do hold some values?

Thanks for any help,

bradgrafelman

If nothing happens, then that means your script ran just fine. In your db_connect.php, you have PHP connect to MySQL with the username and password given.

Once that connect successfully, your script is done executing. What were you expecting to see??

Now, about your code technique:

Unless you're talking about constants, all strings need to be enclosed in quotes. Username is not a constant in this case, so use $_POST['username'];, etc.
For your IF statement, you're saying "If the username or password is set to a space, redirect to this page". Don't you mean if either one of them are blank? Try using:

if(empty($_POST['username']) || empty($_POST['password'])) {

Technically (meaning by RFC standards) the 'Location' HTTP Header needs to be using an absolute URI ('http://mysite.com/db_connect.html', etc.), though it will work using relative paths (as far as IE is concerned; not sure about other browsers).

phanh

Thanks, bradgrafelman

I include the single quote around the username and password variables, and everything went well. I don't receive any warning anymore.

bradgrafelman

If this issue is resolved, don't forget to MARK THIS THREAD RESOLVED using the link at the bottom of the page.