[Resolved] Doing something wrong with my if's

[Elliott]

hi, im having a problem with this section of code.

Ive done it so that it will pull out the results for various modules, and display the scores, and also say pass, fail, not taken etc.

Mod1 is displaying fine, but for mod 7 its saying failed, even tho there is no record, and it should say Not Taken.

Both mod 2 and mod 7 percent will not display too. and i am outputting the same was as with mod1.

<?php echo $percent2; ?> etc

heres my code, much appriate any help.

$mod1_query = "SELECT percent, date FROM burnleycollege_mod1_results WHERE candidate_username = '".$_SESSION['username']."' ORDER BY percent DESC LIMIT 1";
$run_mod1_query = mysql_query($mod1_query);
$mod1_result = mysql_fetch_array($run_mod1_query);
$taken1 = mysql_num_rows($run_mod1_query);
$percent1 = $mod1_result['percent'];
$date1 = $mod1_result['date'];

if ($taken1 = 0)
{
$result1 = "Not Taken";
}
		elseif ($percent1 > 74)
				{
				$result1 = '<font color="green">Passed</font>';
				}
				elseif ($percent1 < 75)
						{
						$result1 = '<font color="red">Failed</font>';
						}


//========= MOD 2 =============================================================
$mod2_query = "SELECT percent, date FROM burnleycollege_mod2_results WHERE candidate_username = '".$_SESSION['username']."' ORDER BY percent DESC LIMIT 1";
$run_mod2_query = mysql_query($mod2_query);
$mod2_result = mysql_fetch_array($run_mod2_query);
$taken2 = mysql_fetch_row($run_mod2_query);
$percent2 = $mod2_result['percent'];
$date2 = $mod2_result['date'];


	if ($percent2 > 74)
			{
			$result2 = '<font color="green">Passed</font>';
			}
			if ($percent2 < 75)
					{
					$result2 = '<font color="red">Failed</font>';
					}
					else
					{
					$result2 = "Not Taken";
					}

//========= MOD 7 =============================================================
$mod7_query = "SELECT percent, date FROM burnleycollege_mod7_results WHERE candidate_username = '".$_SESSION['username']."' ORDER BY percent DESC LIMIT 1";
$run_mod7_query = mysql_query($mod7_query);
$mod7_result = mysql_fetch_array($run_mod7_query);
$taken7 = mysql_fetch_row($run_mod7_query);
$percent7 = $mod7_result['percent'];
$date7 = $mod7_result['date'];


	if ($percent7 > 74)
			{
			$result7 = '<font color="green">Passed</font>';
			}
			if ($percent7 < 75)
					{
					$result7 = '<font color="red">Failed</font>';
					}
					else
					{
					$result7 = "Not Taken";
					}

Its meant to get the highest which i think its doing.

Mod 1 is passed, and mod 2 is failed, and mod 7 is not yet taken, for the purpose of testing.

[id10t]

You need to ='s

if $foo == 0

[Elliott]

hmmm where?

My if's are if a > b etc

Also the if statements are different for 2 and 7 as from 1, but ive had them the same, and was trying them like that, and i get the same output.

[MikeSnead]

if ($taken1 = 0)
{
$result1 = "Not Taken";
} 

should be..

if ($taken1 == 0)
{
$result1 = "Not Taken";
} 

[Elliott]

ahh i get ya....

ok that bit works now thanks....

but this bit still not displaying

<?php echo $percent2; ?>

but this does?

<?php echo $percent1; ?>

[kburger]

You should probably be doing comparisons of < and > on the same integer. Either < 75 or > 75, or < 74 or > 74, but don't mix the two. Your cutoff value needs to be the comparison value for all comparisons.

if ($taken7 == 0) $result7 = "Not taken";
else {
	if ($percent7 >= 75) $result7 = '<font color="green">Passed</font>';
	else $result7 = '<font color="red">Failed</font>';
} 

Also this line

$taken2 = mysql_fetch_row($run_mod2_query);

Should be this

$taken2 = mysql_num_rows($run_mod2_query);

[Elliott]

thanks, corrected that bit, but its still not displaying.

I echo'd the $taken2, and $taken7, and they are both showing as 0. But there are deffinately records in the table with the username i log in with.

Is it ok to have so many queries on one page? or do i have to close the connection to each table?

Seems weird that the mod1 query works fine 😕

[Elliott]

hmmm cant think of anything....the tables all exist, they all contain a record with that username in, and all my queries look correct.

its working fine for mod1 query, but its not finding a record in the next 2 tables.?

Do i need to close the sql connection after every query? or shouldnt that matter?

[Installer]

Try this:

$mods = array('mod1', 'mod2', 'mod7');
foreach ($mods as $mod) {
    $query = "SELECT percent, date " .
             "FROM burnleycollege_" . $mod . "_results " .
             "WHERE candidate_username = '" . $_SESSION['username'] . "'" .
             "ORDER BY percent DESC LIMIT 1"; 
    $run_query = mysql_query($query); 
    if (mysql_num_rows($run_query) == 0) { 
        $percents[$mod] = ''; 
        $results[$mod] = 'Not Taken'; 
        $dates[$mod] = ''; 
    } else {
        while ($res = mysql_fetch_array($run_query)) { 
            $percents[$mod] = $res['percent']; 
            if ($percent[$mod] >= 75) { 
                $results[$mod] = '<font color="green">Passed</font>'; 
            } else { 
                $results[$mod] = '<font color="red">Failed</font>';
            } 
            $dates[$mod] = $res['date']; 
        }
    } 
}

foreach ($results as $key => $value) {
    echo $key . ' Result: ' . $value . 
         ' Percent: ' . $percents[$key] .
         ' Date: ' . $dates[$key] . '<br />';
}

[Elliott]

thanks m8, thats a nice compact way to do it, thansk for the time u spent doin it.

But still its not finding anything from table 7 and 2.

hmmm im gonna drop the tables and remake them and see if that changes anything.

[Installer]

its not finding anything from table 7 and 2.

In that case, I'd say yeah, recheck your db. It could also help to put in some echo statements to see more clearly what's happening, e.g.:

...
    $run_query = mysql_query($query);  

    echo mysql_num_rows($run_query) . '<br />';
...

[Elliott]

this is really crazy....

dropped tables, made new ones. its not finding any rows at all (0 returned).

My code is the same for all the queries but with the numbers changed. really puzzled.

Reckon it might be better if i put each query in a separate php file, then included them?

[Installer]

Wait. I made a big mistake. Try this:

$mods = array('mod1', 'mod2', 'mod7');
foreach ($mods as $mod) {
    $query = "SELECT percent, date " .
             "FROM burnleycollege_" . $mod . "_results " .
             "WHERE candidate_username = '" . $_SESSION['username'] . "'" . 
             "ORDER BY percent DESC LIMIT 1"; 
    $run_query = mysql_query($query); 
    if (mysql_num_rows($run_query) == 0) { 
        $percents[$mod][] = ''; 
        $results[$mod][] = 'Not Taken'; 
        $dates[$mod][] = ''; 
    } else {
        while ($res = mysql_fetch_array($run_query)) { 
            $percents[$mod][] = $res['percent']; 
            if ($percent[$mod][] >= 75) { 
                $results[$mod][] = '<font color="green">Passed</font>'; 
            } else { 
                $results[$mod][] = '<font color="red">Failed</font>';
            } 
            $dates[$mod][] = $res['date']; 
        }
    } 
}

foreach ($results as $key => $value) {
    foreach ($value as $key2 => $value2) { 
        echo $key1 . '/' . $key2 . ' Result: ' . $value2 . 
             ' Percent: ' . $percents[$key][$key2] .
             ' Date: ' . $dates[$key][$key2] . '<br />';
    }
}

[Elliott]

hmmm i get this with the new code..

Fatal error: Cannot use [] for reading in /home/elliott/public_html/project/studenthome.php on line 334

[Installer]

What's line 334?

[Elliott]

$mods = array('mod1', 'mod2', 'mod7');
foreach ($mods as $mod) {
    $query = "SELECT percent, date " .
             "FROM burnleycollege_" . $mod . "_results " .
             "WHERE username = '" . $_SESSION['username'] . "'" . 
             "ORDER BY percent DESC LIMIT 1"; 
    $run_query = mysql_query($query); 
    if (mysql_num_rows($run_query) == 0) { 
        $percents[$mod][] = ''; 
        $results[$mod][] = 'Not Taken'; 
        $dates[$mod][] = ''; 
    } else {
        while ($res = mysql_fetch_array($run_query)) { 
            $percents[$mod][] = $res['percent']; 
            if ($percent[$mod][] >= 75) { // <--------------Line 334
                $results[$mod][] = '<font color="green">Passed</font>'; 
            } else { 
                $results[$mod][] = '<font color="red">Failed</font>';
            } 
            $dates[$mod][] = $res['date']; 
        }

[Installer]

Change line 334 to:

            if ($res['percent'] >= 75) { 

[Installer]

Sorry, I don't have your db set-up to properly test on, or I'd catch little stuff like that before posting.

[Elliott]

hehe, i can tell its not my week for this 😃

i get this now

Parse error: parse error, unexpected $ in /home/elliott/public_html/project/studenthome.php on line 354

And line 354 is right at the very end, after my closing </html> tag, nothing on the line.

Hmmm going back to basics, shouldnt my basic structure pull something out of the table 2 and 7 if its in there?

[Installer]

That error is just a matter of a missing closing bracket (curly brace) (most always if not always). Things like that will be easier to find with strict formatting.

If there's something in 2 and 7 it should be getting retrieved. Do you have the correct field names? What does "echo mysql_num_rows($run_query);" show for each mod?