[Resolved] problem with nested loops

[ptaylor2005]

Hi,
Having a problem with a nested loop outputting to html.
Trying to dynamically write out three textboxes onto the page, and populate them with the resultset of a simple query.
This is the query:

$sql = mysql_query("Select write_region From resume_locations Where resume_id = '$res_id'");

The three textboxes are then written out via the following:
for($n=0;$n<3;$n++) {
echo "<input type=\"text\" name=\"wlocation[]\" size=\"28\" maxlength=\"185\" style=\"font-size: 10px\"\n";

I then tried to use another loop to populate the textbox values with the results of the query. Please note, there should always be three textboxes, even if the query returns zero rows. That way the user can enter data into the textboxes.
So the next loop is:

while($wl = mysql_fetch_array($sql)){
echo "value=\"" .$wl[write_region]."\"\n";
}

Then close the textbox:

echo " /><br />\n";
}

Of course what's happening is that only the first row of data from the query is being written out, the other textboxes are empty, although in this particular query there should be 2 rows of data.

Any help would be gratefully appreciated.
Thanks!

[Sxooter]

Looks like you're missing your closing \" in there...

Never mind, this stupid web browser was displaying " that looked like ' to me....

sigh.

[Sxooter]

OK, got it. Looks like you're doing all the value="" inside that one while loop.

You need to either drop the for next (it's so 1982 anyway. 🙂 and just use the while for the whole thing, or drop the while and us the for loop. Something like:

while (getyourrow()){
  print your text row here;
}

[ptaylor2005]

Thanks for the reply -
The only problem is that I need the code to write out three textboxes, regardless of the number of rows from the query. Basically it's a resume page where users can pick from a list of cities from select boxes, or, if the cities are not listed, they can type them in manually. These are then saved for editing later.

So it needs the 3 textboxes each time, and any corresponding records to appear in them if any.

Thanks again.

[Sxooter]

What if there's enough rows for 4 or 5 text boxes?

[ptaylor2005]

There would only ever be maximum three; the students are allowed to enter up to 3 cities max, but can edit these later on, updating the corresponding records in the table, or say if they had originally only entered one city, they could log back in and add a second or third, if all three textboxes were there.

[Sxooter]

OK, then what you should probably do is use the for loop (I can't believe I just wrote that 🙂 ) and test each time you create a text box to see if there's a row first, and if there is, then grab it and stick the value in, otherwise just insert nothing.

for ($i=0;$i<3;$i++){
  if ($row = @mysql_fetch_array($res)){
    $val = $row['somefield'];
  } else {
   $val = "";
  }
  print "big honkin input line here";
}

[ptaylor2005]

Thank you! That works very well.

Cheers,

Paul

[Sxooter]

No prob, glad to help. Don't forget to mark the thread "RESOLVED"...