Random empty entry on photo upload

[jonki]

Hi,
I am completely flumoxed on this one. I am uploading photos and the code I wrote works fine 99.9% of the time, but I have some users who can NEVER upload a file. They do not change a thing to the file, e-mail it to me, I do exaclty the same and it works fine. I thought it must have something to to with the browser of the user but another user had the same problem, reloaded the file and it worked fine. (Maybe they are unrelated)
What happens is this - the user uploads the file, a name is given to it and that name is recorded into the database but the file is not where it should be, (nor is there a file of a different name anywhere).
If you want to check this out go to www.tenercoche.com and peform a search - you will see a blank photo now and again.
Any help would be greatly appreciated.
Here is the code - hope it helps.

<? @header('Content-type: image/jpeg'); 

$path = $_SERVER['DOCUMENT_ROOT'] . '/fotos_coches/';  

if(!empty($foto)) 
    { 
    if ($foto_type == "image/gif") { $ext = ".gif"; } 
    if ($foto_type == "image/pjpeg") { $ext = ".jpg";} 
    $newfotoname = uniqid("").$ext ;  

    } 

if (($foto_type == "image/gif") or ($foto_type == "image/pjpeg")) 
    { 


list ($width, $height) = getimagesize($foto); 
$new_width=300; 
$ratio=$new_width/$width; 
$new_h=$ratio*$height; 

$image_p = imagecreatetruecolor($new_width, $new_h); // Create a back image of these co-ordinates
rename($foto, $foto.$ext);	
$image = imagecreatefromjpeg($foto.$ext); 
imagecopyresampled($image_p, $image, 0, 0, 0, 0, $new_width, $new_h, $width, $height); 
$im = imagejpeg($image_p, $path.$newfotoname, 75); 

imagedestroy($image); 
imagedestroy($image_p); 


@copy($im, $path.$newfotoname);  
} 

?> 

THANKS A LOT!!!!

[dalecosp]

Forgive me if I'm wrong (I often speak before thinking ...), but isn't the code you've shown us the display code, while the problem you're citing is with the upload?

😕

[jonki]

No - this is the upload. I dont need the original size therefor I resize it to save space and put it in a folder with I then reference to in my database. The entry into the database is just newfotoname (excuse the mixing of spanish and english)

Thanks

[kburger]

I've got to agree with dalecosp. There's nothing in this code that handles a file upload.

[jonki]

I have a form which you can fill in (where you select the pictures you want) and when you click on send it then takes them to a page which includes this.
The code I have pasted here is the only bit of code refering to the images I have and it was worked (almost) perfectly.

In the form the user fills in I have this:
<form method="post" enctype="multipart/form-data" action="insertar.php">
<p>
<input type="hidden" name="MAX_FILE_SIZE" value="6500000">
and then the button for the file and a submit button.

and the file is already uploaded I assume when it reached the code I mentioned in my first message.

But I assumed that everything I have just written would be taken for granted. Am I missing anything here?

[kburger]

Random empty entry on photo upload

If you're having problems with file uploads you'll have to post the code that handles the uploads. There's no way anybody could possibly guess why you're having trouble if they haven't seen your code yet.

[Weedpacket]

I'm thinking that is the upload code, but Question One of the Newbies FAQ applies. Of course, then the header() is probably wrong.

[jonki]

All the code I have that concerns the photos I have put here. There is nothing I have missed out so it must handle file uploads because this works 99€ of the time.
I looked at the Newbies FAQ (thanks Weedpacket) and you may be on to something there. However, EVERYTHING else works perfectly and even the files work fine nearly all the time so I am doubtful whether this is the problem.
(This bit of upload code was written for me by the guys who host my website and as they are profesionals and obvioulsy know what version of PHP we are using then I assumed that they'd have got it right - they are just washing their hans of the problem saying that the code works fine. Which is does, except for one or two users.)
I am wondering if it could have anything to do with the browser (as it always the same people who can't upload files)

Thanks a lot everyone

[Weedpacket]

It may be because their browser is using the correct MIME type for JPEG images (i.e., "image/jpeg").
You could use getimagesize() to determine if the uploaded file is a GIF or JPEG or PNG image, without having to trust what the client says.

[jonki]

But when the same guy emails me the photos I upload them in exactly the same way as he does (using his username and password) and it works fine.
At the moment I am only working with jpegs and all files uploaded are jpegs.

Does this narrow it down?

[mrhappiness]

you use the same browser as he?
your browsers sends the same mime type as his browser does?

just follow weedpacket's suggestion and it should work

[jonki]

Thanks for your help but I am not sure exaclty what to do.
I use getimagesize() to find the file type. This will be in the form "image/jpeg" and then what do I do to it that would be different from what I do now?
Thanks

[mrhappiness]

you checked the file's real mime type and did not rely on the mime type the browser sent to you as you do at the moment (or did until now)

if getimagesize returns image/gif or image/jpeg you have a gif or jpeg file if getimagesze returns something diffeernt you have a file of another type

[jonki]

but I know for a fact that it is a jpeg. I know the guy who is trying to post the files and we have discussed at great length what it could be that he is doing that is different and we can come up with nothing.
He sends me the jpegs and without changing a thing I upload them and it works fine.
As you can see, I haven't got a clue about what the cause could be.

Thanks

[mrhappiness]

change your code: instead of

 @header('Content-type: image/jpeg');

write

echo '<pre>';
print_r($_FILES);
echo '</pre>';

and let him upload a jpeg afterwards and mail you the output he receives
compare that with the output you receive and post both results

[jonki]

Finally he has got back to me.

Here is the message when I do it. (I am using exactly the same photos because he had to send them to me as it still doesn't work.)

Array
(
[foto] => Array
(
[name] => cayenne s hinten.jpg
[type] => image/pjpeg
[tmp_name] => /tmp/phpFVSL38
[error] => 0
[size] => 138889
)

[foto2] => Array
    (
        [name] => cayenne s seite.jpg
        [type] => image/pjpeg
        [tmp_name] => /tmp/php0S6zwO
        [error] => 0
        [size] => 140322
    )

[foto3] => Array
    (
        [name] => cayenne s innen vorn.jpg
        [type] => image/pjpeg
        [tmp_name] => /tmp/phpF03HQ2
        [error] => 0
        [size] => 162474
    )

[foto4] => Array
    (
        [name] => cayenne s vorn.jpg
        [type] => image/pjpeg
        [tmp_name] => /tmp/phpgLZFsW
        [error] => 0
        [size] => 141661
    )

)

------------------- So that works fine -----------------------------

This is his that DIDNT work

Array
(
[foto] => Array
(
[name] => cayenne s hinten.jpg
[type] => image/jpeg
[tmp_name] => /tmp/phpFVSL38
[error] => 0
[size] => 138889
)

[foto2] => Array
    (
        [name] => cayenne s seite.jpg
        [type] => image/jpeg
        [tmp_name] => /tmp/php0S6zwO
        [error] => 0
        [size] => 140322
    )

[foto3] => Array
    (
        [name] => cayenne s innen vorn.jpg
        [type] => image/jpeg
        [tmp_name] => /tmp/phpF03HQ2
        [error] => 0
        [size] => 162474
    )

[foto4] => Array
    (
        [name] => cayenne s vorn.jpg
        [type] => image/jpeg
        [tmp_name] => /tmp/phpgLZFsW
        [error] => 0
        [size] => 141661
    )

)

---

So there IS a difference!!!!!!!
We are getting somewhere.

       [type] => image/pjpeg

       [type] => image/jpeg

Now how do I get it so that his also comes as pjpeg? What does this mean?

Many many thanks - the end is in sight .........

[mrhappiness]

Originally posted by jonki
Now how do I get it so that his also comes as pjpeg?

make him (and the whole rest of the internet) use the very same browser you use...

or read [man]getimagesize[/man] (especially the code examples)
this definitly solves your problem

[jonki]

Thanks a lot. I did contemplate for a minute on whether to change the browseres used by the rest ofthe world but decided that maybe doing what you suggested might be easier.

I am guessing you are refering to mime types but I am not very got at this an dont follow 100%.

I am going to play around with this example

<?php
$tam = getimagesize($nombre_archivo);
$da=fopen($nombre_archivo, "rb");
if ($tam && $da) {
  header("Content-type: {$tam['mime']}");
  fpassthru($da);
  exit;
} else {
  // error
}
?>  

and see if it gets me anywhere. If I am barking up the wrong tree please stop me......

thanks

[jonki]

OK - I tried it and I got a whole load of symbols filling up my screen. But the thing worked ..... but it always does on my computer....

I have a worry though. This photo manipulation is in a seperate file and I include() it in the main file. This means that the headers have already been sent by the original file and I get a warning. I used to get round this by putting an @ infront of the header command but am I covering over a problem I should be dealing with or is this acceptable?

Many thanks