[Resolved] Calling Function In A while Loop

[joe_C_nice]

I have a series of records in a database. I'm using a while loop to retrieve each entry. Within that while loop i'm calling a function created in an external file that's accessed by require_once.

The problem is only the first entry from my databse is returned. Removing the function call returns all the entries. But I need access to this function.

//Are there any suggestions other than using 
$sql = mysql_query("select username from members ");
while($r = mysql_fetch_array($sql))
{
$array[] = $r;
}
//then running a foreach loop to extract the data from $array

[thorpe]

youve allready got an array in $r, why make another?

$sql = mysql_query("select username from members ");
while($r = mysql_fetch_array($sql,MYSQL_ASSOC))
{
    foreach ($r as $v) {
        echo $v['username'];
    }
}

[joe_C_nice]

Anyone know why calling my fucntion within a while loop only returns the first result from my db.

[thorpe]

you want to show us your code?

[joe_C_nice]

$sql = mysql_query("select users from members where refer = 0");
while($row = $mysql_fetch_array($sql))
						{
										echo user_stats($row['users']).'<br>';
								}

[thorpe]

cant see why it wont work. can we see the function?

[joe_C_nice]

function user_stats($user)
{
$query = mysql_query("select * from active_members where user='$user'");

$row = mysql_fetch_assoc($query);
return $row;
}

[thorpe]

your function returns an array, so you cant simply echo() it. i cant undersatnd how this has been working at all.

the way you've approuched this is really inificient anyhow. where possible you should avoid putting queries in loops. this is allot of work on a database server.

go over to mysqlfreaks and search for a tutorial on using 'joins'. they will help you achieve what you want in 1 query.

[joe_C_nice]

Figured it out.🙂