Array Help

[hbradshaw]

Hello:

I have a form with a field called "whichday". This represents the days of the week.

In my form, I have it written as:
<input type="checkbox" name="whichday[]" value="Monday">
<input type="checkbox" name="whichday[]" value="Tuesday">
<input type="checkbox" name="whichday[]" value="Wed">
<input type="checkbox" name="whichday[]" value="Thursday">

Now, I'm passing this form into a script and I was able to verify that the "whichday[]" was working. All four days appeared.

Now, I run the script selecting all four days. My script takes the results in places them in table format. When the script runs, for Which Days:,the table should show me: Monday, Tuesday, Wed, Thurs. Instead, it only shows Thursday. I don't know what's happening to the other three days and why they are not appearing in the list.

Can someone take a look at my script and help me find my error?

Thank you in advance.

Here is the script:

<?php

$name=$_POST["name"];
$email=$_POST["email"];
foreach($whichday as $index => $day)
?>

<table border="0" width="100%">
  <tr>
    <td width="32%">Name</td>
    <td width="68%"><? echo "$name"; ?></td>
  </tr>
  <tr>
    <td width="32%">Email</td>
    <td width="68%"><? echo "$email"; ?></td>
  </tr>
  <tr>
    <td width="32%">Days</td>
    <td width="68%"><? echo "$day"; ?></td>
  </tr>
</table>

[bradgrafelman]

Are you positive that's the entire script? You need to enclose the 'foreach' data in brackets:

<?PHP

// your previous code up until foreach() goes here

foreach($whichday as $index => $day) {
?> 

<table border="0" width="100%"> 
<tr> 
<td width="32%">Name</td> 
<td width="68%"><?=$name;?></td> 
</tr> 
<tr> 
<td width="32%">Email</td> 
<td width="68%"><?=$email;?></td> 
</tr> 
<tr> 
<td width="32%">Days</td> 
<td width="68%"><?=$day;?></td> 
</tr> 
</table>
<?PHP
}
?>

NOTE: I also shortened the echo's to the <?= tag, which is the same as echo'ing the variable. If you'd rather use echo, I would highly recommend (and this goes for ALL of your scripts) that you NOT use the short '<?' open tag; not all servers support this, and as it is a setting, you never know when it may be switched off or unavailable if you move servers.

[TheDefender]

Probably best to just always stick to long tag syntax all of the time...

<?php echo $name;?>

<?=$name;?> is considered a use of the short open tag syntax, just like this: <? echo $name;?>.

For the sake of avoiding a headache (as bradgrafelman mentioned), you should always consider writing it out as I did above. It is the only truly portable method of doing it.

[bradgrafelman]

thwaps self on head

Of course that's part of short open. I'm a hypocrite :p

My mistake!

[hbradshaw]

Hi Bradgrafelman,

I placed the foreach in brackets and when I run the script, the result is a blank page.

Oh, yes that is the entire script, for now anyway. I'm writing it step at a time and testing otherwise debugging later is a nightmare.

Here's the script:

<?php

$name=$POST["name"];
$email=$POST["email"];
foreach($whichday as $index => $day) {
?>

<table border="0" width="100%">
<tr>
<td width="32%">Name</td>
<td width="68%"><?=$name;?></td>
</tr>
<tr>
<td width="32%">Email</td>
<td width="68%"><?=$email;?></td>
</tr>
<tr>
<td width="32%">Days</td>
<td width="68%"><?=$day;?></td>
</tr>
</table>
<?PHP
}
?

[TheDefender]

Sounds like your register globals is off, since it's a blank page... That would mean that the $whichday variable as you are calling it is blank, since no table is being displayed at all...

Add in a line to define your $whichday variable from the POST array...

$name=$_POST["name"]; 
$email=$_POST["email"]; 
$whichday = $_POST['whichday'];
foreach($whichday as $index => $day) {