Function fails while direct-script works

[Sneef]

Here's the code that doesn't work:

(this is found in functions.php that's required at the beginning of my index.php)

function security_level()
	{
	switch ($_SESSION['security_group']):
		case admin:
			$security_level = 3;
			break;
		case moderator:
			$security_level = 2;
			break;
		case client:
			$security_level = 1;
			break;
		default:
			$security_level = 0;
	endswitch;
	}

In the index.php file, I call the function with "security_level();"
However, the $security_level variable isn't defined when I echo it.

Here's where it gets more confusing... When I copy-paste the switch into index.php, then echo $security_level, it echoes just fine (displays the correct number).

Any ideas?

TIA
-Sneef

EDIT: the global $_SESSION['security_group'] is defined wether I use the function in functions.php or the copy-paste alternative.

[pohopo]

I would first check to see if the session variable is set. If not then give person no rights.

function security_level()
{
if (ISSET($_SESSION['security_group']) 
{
switch ($_SESSION['security_group']):
case admin:
$security_level = 3;
break;
case moderator:
$security_level = 2;
break;
case client:
$security_level = 1;
break;
default:
$security_level = 0;
endswitch;
} else {
$security_level=0
} 

return $security_level;

}

[Sneef]

Good point. (my edit wasn't fast enough I guess! 😉 )

But that doesn't solve my problem.

-Sneef

[thorpe]

your function is not [man]return[/man]ing anything.

[Installer]

You have to make the value of the variable available outside the function (Variable scope), with "return", by reference, or with "global".

[Sneef]

Like so?

function security_level()
	{
	switch ($_SESSION['security_group']):
		case admin:
			$security_level = 3;
			break;
		case moderator:
			$security_level = 2;
			break;
		case client:
			$security_level = 1;
			break;
		default:
			$security_level = 0;
	endswitch;
	return $security_level;
	}

EDIT: I guess not, since it's not working... I'll try putting return on every variable. EDIT2: No, that doesn't work either:

functions.php

function security_level()
	{
	switch ($_SESSION['security_group']):
		case admin:
			return $security_level = 3;
			break;
		case moderator:
			return $security_level = 2;
			break;
		case client:
			return $security_level = 1;
			break;
		default:
			return $security_level = 0;
	endswitch;
	}

index.php

security_level();
echo $security_level;

[thorpe]

function security_level()  {
  switch ($_SESSION['security_group']) {
    case 'admin':
      $security_level = 3;
      break;
    case 'moderator':
      $security_level = 2;
      break;
    case 'client':
      $security_level = 1;
      break;
    default:
      $security_level = 0;
  }
  return $security_level;
}

[cahva]

Thorpe you forgot that he didnt return it to any variable so this is also needed:

$security_level=security_level();
echo $security_level;

And I would simplify that security_level() function even more (but thats just a matter of taste 😉 ):

function security_level() {
	$levels=array(1=>'client',2=>'moderator',3=>'admin');
	return(array_search($_SESSION['security_group'], $levels));
}

[Sneef]

That's the same as:

function security_level() 
    { 
    switch ($_SESSION['security_group']): 
        case admin: 
            $security_level = 3; 
            break; 
        case moderator: 
            $security_level = 2; 
            break; 
        case client: 
            $security_level = 1; 
            break; 
        default: 
            $security_level = 0; 
    endswitch; 
    return $security_level; 
    }

[Sneef]

Originally posted by cahva
Thorpe you forgot that he didnt return it to any variable so this is also needed:

$security_level=security_level();
echo $security_level;

And I would simplify that security_level() function even more (but thats just a matter of taste 😉 ):

function security_level() {
	$levels=array(1=>'client',2=>'moderator',3=>'admin');
	return(array_search($_SESSION['security_group'], $levels));
}

[/B]

Love how you created the array, but I'm too much of a n00b to be able to set that up and understand it fully! But will bookmark it 😉

What's that about not returning the variable...? I need "$security_level=security_level();" too? (in the functions.php or index.php?)

[Sneef]

Mmmh... I guess I understand it well enough... I just replaced my switch with the array. Works wonders 🙂

[Sneef]

Now, I've got another problem...

I have a function (another switch) that determines which buttons will be displayed. That switch is based on the $security_level variable:

function main_menu()
	{
	echo "<form action='".$_SERVER['php_self']."' method='post'>";

switch ($security_level):
	case 1:
		echo "<input name='1' type='submit' value='1' />
			  <input name='2' type='submit' value='2' />";
		break;
	case 2:
		echo "<input name='1' type='submit' value='1' />
			  <input name='2' type='submit' value='2' />
			  <input name='3' type='submit' value='3' />";
		break;
	case 3:
		echo "<input name='1' type='submit' value='1' />
			  <input name='2' type='submit' value='2' />
			  <input name='3' type='submit' value='3' />
			  <input name='4' type='submit' value='4' />";
endswitch;

echo "</form>";
}

Yet, when I call this function in my index.php file, it does nothing:

$security_level = security_level();
echo $security_level;
main_menu();

I don't see what's wrong with it... if I copy-paste it to index.php, it displays fine. And, there's no variable to return, so what's missing? stumped (is it normal to be stumped like this all the time when beginning to code?)

[thorpe]

the variable $security_level is not available inside the main_menu() function unless you pass it in or make it global (not recommended).

all you need do is change this line;

function main_menu()

to

function main_menu($security_level)

then, when you call the main_menu() function, pass it the security_level() function.
eg;

main_menu(security_level());

you could also save the returned sec level value from your security_level() function, then feed that in.
eg;

$level = security_level();
main_menu($level);

hope this helps.

[Sneef]

Thanks thorpe! That worked.

However, where would be a good place to read up on why that works or how it works? I need to know how it works if I wanna be able to reuse it or modify it (eg: add another var)

[thorpe]

as per usuall. i would suggest the manual . read up on functions , and you might need to take a look at scope aswell.

good luck.