my memers online script is not working properly

rutin

hi there,
its been a quite long time since i started to work on the members online script. script is funtion very strange.

If user is logged it will show which users are online.

I have link for user to logout, if it clicked than user is no longer online.

But if you close down browser and open up the page again, it still shows that user logged in.

my problem is: how can have to check if user is online or not ?

I have searched this forum, seen some good posts, but could not implement them, so please dont send me to search. Thank you.

my script for login:

<?php

  $sql = "select * from users where login = '$login' and password = '$password'";
  $result = mysql_query($sql ,$db);
  if ($myrow = mysql_fetch_array($result)) {
     do {

        $uid = $myrow["userid"];
        $uname = $myrow["login"];

     } while ($myrow = mysql_fetch_array($result));

     $loggedin = true;
     $upwd = $password;
     $msg = "Welcome $uname, you are now logged in.  <a href=index.php>Click here</a> to return to the front page.";


// if the user is logged in set to Yes
$query2 = "update users set  logged_in='Y'  where userid = $uid and password = '$upwd'";


// tried with this query but it does nothing,
//$query2 = "update users set timestamp='$timestamp' logged_in='Y'  where userid = $uid and password = '$upwd'";
$mysqlresult2 = mysql_query($query2);


// throw and error

  } else {
     $loggedin = false;
     $upwd = "";
     $uid = "";
     $uname = "";
     $msg = "Sorry, that login and password is not valid.  Click back on your browser to try sgain.  If you have forgotten your password <a href=forgot.php>click here</a>.  If you are a new user you will need to <a href=newuser.php>create a new login</a>";


  }

session_register("loggedin");
session_register("upwd");
session_register("uid");
session_register("uname");

?>

and my script for users online:


<?php 	
echo "<span class=\"style5\">"; 
// check for user status

$sql_query = "SELECT * FROM users WHERE logged_in = 'Y'";
$result = mysql_query($sql_query); 
if ($row = mysql_fetch_array($result)) { // make sure you have something to work with 
   do { 

// display users
 printf($row['login'] . "&nbsp;"); 
   } while ($row = mysql_fetch_array($result)); 

 } else {

// no registered users
        echo "<span class=\"style5\">no users online</span>"; 

  }

echo "</span>"; 

 ?>

I am posting on regular basis here, and hanging on forum at all times, so please bare with me, i am learning. and sorry if i repat myself.

With hope that somebody will help me, i thank to that person in advance.

thorpe

your going to need a field in your db for storing active times. then, as users hit your pages you will need to update this field with the current time.

this same script then also needs to go through your active time field and delete entries older than say 20mins.

at the moment, your users are logging in and you are setting a field to 'Y'. this then remains on 'Y'. resulting in your users always looking like they are online.

the suggestion i have made will automatically delete users from the 'active' list if they haven't hit a page in the last 20mins.

rutin

added new table field called timstamp:
now my code for login looks like this :

<?php

$timeoutseconds = 180;      

$timestamp = time();         // get current time 
$timeout = $timestamp-$timeoutseconds;

  $sql = "select * from users where login = '$login' and password = '$password'";
  $result = mysql_query($sql ,$db);

  if ($myrow = mysql_fetch_array($result)) {


     do {

        $uid = $myrow["userid"];
        $uname = $myrow["login"];

     } while ($myrow = mysql_fetch_array($result));

     $loggedin = true;
     $upwd = $password;
     $msg = "Welcome $uname, you are now logged in.  <a href=index.php>Click here</a> to return to the front page.";

//$query2 = "update users set  logged_in='Y'  where userid = $uid and password = '$upwd'";

$time=time(); 
$query2 = "update users set timestamp='$time',logged_in='Y' where userid = $uid and password = '$upwd'";
$mysqlresult2 = mysql_query($query2);



  } else {
     $loggedin = false;
     $upwd = "";
     $uid = "";
     $uname = "";
     $msg = "Sorry, that login and password is not valid.  Click back on your browser to try sgain.  If you have forgotten your password <a href=forgot.php>click here</a>.  If you are a new user you will need to <a href=newuser.php>create a new login</a>";


  }

session_register("loggedin");
session_register("upwd");
session_register("uid");
session_register("uname");

?>

code for users online, looks like this !

<?php 	

echo "<span class=\"style5\">"; 



$sql_query = "SELECT * FROM users WHERE logged_in = 'Y'";
$result = mysql_query($sql_query); 
if ($row = mysql_fetch_array($result)) { // make sure you have something to work with 
   do { 

 printf($row['login'] . "&nbsp;"); 
 //printf($row['login']); 

   } while ($row = mysql_fetch_array($result)); 
//}

 } else {

    echo "<span class=\"style5\">no users online</span>"; 

  }


echo "</span>"; 
$timeout=time()-500; 
$sql_query = "UPDATE users set logged_in = 'N' WHERE timestamp < $timeout"; 
$result = mysql_query($sql_query); 
 ?>

i get you, i hope this is the right !
Did i put it right ?

Thanks