new row from a loop

[dud3r]

Ok I'm working on a gallery script and I need some help. I have a bit of code that shows thumbnails of images from users in the database.

Here's the code:

echo "<TABLE class=tborder cellSpacing=1 cellPadding=6 width=100% align=center border=0>";
echo "<TBODY>";
echo "<TBODY id=collapseobj_forumbit_12>";
$limit = 12; 
$query_count = "SELECT * FROM pictures2 WHERE approved='1' ORDER BY id desc"; 
$result_count = mysql_query($query_count); 
$totalrows = mysql_num_rows($result_count); 
$PHP_SELF = $_SERVER['PHP_SELF']; 
if(empty($page)) { 
$page = 1; 
} 
$limitvalue = $page * $limit - ($limit); 
$query = "SELECT * FROM users,pictures2 WHERE approved='1' ORDER BY id desc LIMIT $limitvalue, $limit"; 
$result = mysql_query($query) or die("Error: " . mysql_error()); 
while($row = mysql_fetch_array($result)) { 
echo "<TR>";
echo "<TD class=alt1 align=left width=15%>";
echo "<a href=profile.php?username=".$row['username']."><img src=/pictures/thumb/thumb-".$row['filename']." border=0></a>"; 
echo "</TD>";
echo "<TD class=alt2 align=left width=15%>";
echo $row['description']; 
echo "</TD>";
echo "</TR>";
}
echo "</table>";

//------pages links below---//

However, I want it to show 3 rows of 4 images on each page. Right now, it only shows one row of 3 images on each page. How can I make it break up all the images from the database and make it show 3 rows or 4 images on each page? I already have the page script, so if it shows a total of 12 images per page but I don't know how to make it show those 12 images seperated into 3 rows.
Thanks in advance for any help.

[pete_bisby]

You need to keep track of the number of images, and place a new line after the correct number of images have been displayed:

...
...
for ($i=0; $i < mysql_num_rows($result); $i++) {
  if (($i==0) || (($i%4)==0) {
    echo "<TR>";
  }
  echo "<TD class=alt1 align=left width=15%>"; 
  echo "<a href=profile.php?username=".$row['username']."><img src=/pictures/thumb/thumb-".$row['filename']." border=0></a>";  

  echo "</TD>"; 
  echo "<TD class=alt2 align=left width=15%>"; 
  echo $row['description'];  

  echo "</TD>";
  if ((($i+1)%4)==0) {
    echo "</TR><TR>";
  }
  $imageNum++;
}

If you use a for loop you automatically declare a counter. Utilising that counter at the start of the loop you can insert the <TR> tag, and at the end of the loop to insert the </TR> tag. You should now have 4 sets of images over 3 rows.

[dud3r]

That code gives me a parse error and tells me to go the line that says "if (($i==0) || (($i%4)==0) {".

[Antares]

Originally posted by dud3r
That code gives me a parse error and tells me to go the line that says "if (($i==0) || (($i%4)==0) {".

Because one bracket is missing, correct is

(($i == 0) || (($i%4) == 0)) { ...

[pete_bisby]

Hey, nobody's perfect !!!

If we were, we wouldn't have great forums like this!

[laserlight]

Actually,
($i==0) || (($i%4)==0
Can be simplied to
$i % 4 == 0

That said, since you are already using a while loop, it makes sense to simply create the counter and increment within the while loop. Testing with mysql_num_rows() is an unnecessary expense.

[Weedpacket]

Oh, I don't know; I'd still use mysql_num_rows() and a for loop, in the following fashion:

$number_of_rows = mysql_num_rows($result);
if($number_of_rows>0)
{
    for($i=0; $i<$number_of_rows; $i++)
    {
// ...
    }
}
else
{
    // Handle the case where there were no rows returned.
}

I also feel that having a counter inside a while loop to simulate a for loop is unnecessary 🙂

[laserlight]

I also feel that having a counter inside a while loop to simulate a for loop is unnecessary

If you wholly use a for loop instead, of course.
pete_bisby's suggestion seemed to be to use both when either will do.