[Resolved] Help! My ereg isn't working

habbardone

Hello
I am using this simple ereg to check a field.
When doing a var_dump($_POST); it shows that the element is
string (4) '1111' . Despite this my ereg routine doesn't accept that I have a number in the field. What am I doing wrong ?

Thanks for any help! 🙂

/*
*  Check the Price field
*/		

if(!ereg("^[0-9]$",$N_price[$i]))
{
   $mess = "yes";			 
   $message1 = "All prices must be numbers only.";
   $message2 = " - or a decimal point. See line no : ".$Di." Price: ".$N_price[$i];
   require_once ("head.inc");
   require_once ("c_sal_ord_bfm.php");
   exit(); 
   }  // endif
[code=php]

bradgrafelman

If the variable is always going to be a string of numbers, i.e. '1111' or '1234', why use a slow, pattern-matching function such a ereg? Seems like the "killing a fly with a cannon" type thing. Try this instead:

if(!is_numeric($N_price[$i])) 
{

NOTE: This will NOT work for floats (i.e. '1111.2'). To mix floats and integers in your price, try this:

if(!is_numeric($N_price[$i]) && !is_float($N_price[$i])) 
{

Hope this helps.

Installer

I agree. And this should also work:

function valid_price($str)
{
    if (substr_count($str, '.') > 1) {
        return false;
    }
    $tmp = str_replace('.', '', $str);
    if (!ctype_digit($tmp)) {
        return false;
    }
    return true;
}

habbardone

!Thanks for the input - looks good.

bradgrafelman

If you find that one of these suggestions will solve your issue, make sure you MARK THE THREAD RESOLVED using the link at the bottom of the page!