[Resolved] Update Error

asa_carter

Can anyone see what is wrong with this?

<?
include("connect.php");

//database data is
// userid: asa_carter
// verify: verified

$u = "asa_carter_not";
$v = "verified_not";

$verify = mysql_query("UPDATE login SET verify='verified' WHERE userid='$u' AND verify='$v'") OR die("error"); 

?>

It doesnt give an error.

Cheers

Asa

toplay

Are you displaying something when it worked ok? There may not be anything wrong. Try using backtick marks and display something when it works. Example:

<?PHP
// Just in case
error_reporting(E_ALL);
ini_set('display_errors', '1');

include("connect.php");

//database data is
// userid: asa_carter
// verify: verified

$u = "asa_carter_not";
$v = "verified_not";


$sql = "UPDATE `login` SET `verify` = 'verified' WHERE `userid` = '$u' AND `verify` = '$v'";

$verify = mysql_query($sql);
if ($verify) {
    echo 'Update was successful';
} else {
   // Handle error
   echo 'Query failed. SQL: ', $sql, '<br />Error # ', mysql_errno(), ' Error msg: ', mysql_error();
   exit;
}
?>

asa_carter

Hi,

I've just tried that and it just says the update was successful when both the the $u and $v variables are both in the database and not in the database...

The database is updating ok only when the conditions are met. It's just checking that it was successful that is not working.

Any other idea's?

Asa

toplay

"The database is updating ok only when the conditions are met. It's just checking that it was successful that is not working. "
Say what? I don't understand what you're trying to say. Please rephrase it.

If it tells you that it worked, then great. Are you saying that it's not returning FALSE when the search criteria doesn't match or what?

asa_carter

Hi,

Yes. It's not returning false when the search criteria is not met.

toplay

I don't have an answer for you other than to say you should double check yourself. Use phpMyAdmin or MySQL command prompt or similar tool to check the update and what's really in the table.

Good luck.

asa_carter

I have tested the update query and it works fine.

Like I said, the problem is I can't check to see whether it was successful or not.

I've tried using mysql_num_rows, mysql_affected_rows, isset().

All of these return true, even if there where no results in the query.

toplay

mysql_affected_rows() is what you should use after doing an UPDATE. It doesn't return true, but rather the number of rows modified.

Please note that MySQL will not update a value if that value is already the same in the table (for the row(s) attempting to be updated).

I'm really having a hard time trying to understand your train of thought. You probably need to post the latest code you're talking about.

I don't understand because you say this on one hand:
"I have tested the update query and it works fine. "

Then say this on the other:
"I can't check to see whether it was successful or not."

What do you mean by the following?
"... even if there where no results in the query".

What results? How do you determine or what does "no results" mean to you?

Make sure you're not using '@' in front of SQL commands because it suppresses errors. Also, make sure you have the highest error_reporting level (as shown in my earlier post).

asa_carter

$sql = mysql_query("UPDATE `login` SET `verify` = 'verified' WHERE `userid` = '$u' AND `verify` = '$v'"); 
if (mysql_affected_rows($mysql_access)==1)
  true
else
  false

Sorted.

toplay

Good. I would check to make sure it updated at least one row and not just look for one specifically. Depending on the search criteria, the UPDATE could update from none to many rows. Example:

$sql = mysql_query("UPDATE `login` SET `verify` = 'verified' WHERE `userid` = '$u' AND `verify` = '$v'");
if ($nbr = mysql_affected_rows($mysql_access) > 0)
  echo 'Number of rows updated: ', $nbr;
else
  echo 'No rows updated';

Well done and take care.