How can I rewrite this PHP code but have it do the same thing?

JamesRP

Hi,

I'm just wondering how could I rewrite this PHP code but have it do the same thing? Could I change the variable names and spacing and have it do the same thing? Can someone offer me any pointers? Thanks, here's the code:

$password = '';



error_reporting(E_ERROR | E_WARNING | E_PARSE);	

new RestoreTool;

class RestoreTool
{
    var $logged_in = 0;
    var $maximum_time = 0;

function RestoreTool() {
    global $HTTP_GET_VARS, $HTTP_COOKIE_VARS, $password;

    $this->timestamp = time();

    if (!$this->maximum_time) 
    {
        //set_time_limit(0);
    	$this->maximum_time = ini_get('max_execution_time');
    }

    if ($HTTP_GET_VARS['act'] == 'login') 
    {
    	$this->do_login();
    }
    elseif ($password && $password != $HTTP_COOKIE_VARS['mysqltool']) 
    {
    	$this->login();        	
    }
    else 
    {
        if ($password) 
        {
        	$this->logged_in = 1;
        }

        switch ($HTTP_GET_VARS['act']) 
        {
            case 'logout':	
                $this->logout();
            break;

            case 'change_db':
                $this->read_db_details();
                $this->set_database('The current settings do connect however if you wish to change the current database please edit the details below:');
            break;

            case 'set_database':	
                $this->do_set_database();
            break;

            case 'backup':	
                $this->backup();
            break;

            case 'do_backup':	
                $this->do_backup();
            break;

            case 'restore':	
                $this->restore();
            break;

            case 'do_restore':
                $this->do_restore();
            break;

            default:

                $this->main();
        }        	
    }

    if ($this->link) 
    {
    	mysql_close($this->link);
    }

    $this->output();
}

function timeout() {
    if (!$this->maximum_time)
    {
    	return false;
    }
    elseif ((time() - $this->timestamp) > ($this->maximum_time - 5)) 
    {
    	return true;
    }
    else 
    {
    	return false;
    }
}

function output() {
    if ($this->logged_in) 
    {
    	$logout_text = '[ <a href="mysql_tool.php?act=logout">Log Out</a> ]';
    }
    else 
    {
    	$logout_text = '';
    }

    if ($this->title) 
    {
    	$title = $this->title;
    }
    else 
    {
    	$title = 'Backup / Restore Tool';
    }

    print '<?xml version="1.0" encoding="iso-8859-1"?>';
    print <<<HTML

🙂

JamesRP.

Jason_Batten

Why do you want to change it 😉 ?

Is it someone else's code? because changed or not it still belongs to the owner :evilgrin:

JamesRP

Yes it is someone elses code. However, I have permission to change the rewrite the code, the owner did not want me to use that version.

So, thusly, I'm asking my question. Also, is there anyway I can improve the code? Thanks for the reply, nonetheless.

JamesRP.

vaaaska

I'm sorry, but asking for somebody to rewrite it is not really the purpose of this place. I suggest you start from the beginning and try to understand what this is doing...then break it down and go from there.

People will be much more helpful if you start off by showing that you really want to learn. Show us some of your reworked code and people will be more helpful.

Until then, here's a helpful link...

http://www.php.net/

mtmosier

Technically this person didn't ask for anyone to do the rewritting.

Could I change the variable names and spacing and have it do the same thing?

Yes.

Can someone offer me any pointers?

vaaaska's suggestion was good (first step is to really understand what it's doing).