Darm

[BizBoy]

Im trying to upload photos and info but the photos dont upload can anyone help with this code?

//Add it
if($act == "addnew") 
{ 
    //Upload files
if ($_POST['MAX_FILE_SIZE']) 
{
$namelist=array(); // we'll hold all the filenames here...

foreach ($_FILES["pic"]["error"] as $key => $error) { 
   if ($error == UPLOAD_ERR_OK) { 
       $tmp_name = $_FILES["pic"]["tmp_name"][$key]; 
       $name = $next_id."_".$_FILES["pic"]["name"][$key]; 
       move_uploaded_file($tmp_name, "$directory$name"); 
       echo $name." Uploaded<br>"; 
       $namelist[]=$name;
        }
    }
}

$lctn = addslashes($lctn); 
$type = addslashes($type); 
$vews = addslashes($views); 

$insert_names=implode(",", $namelist); // make array a comma-seperated list

mysql_query("INSERT INTO propdb SET ID = '$next_id', lctn = '$lctn', type = '$type', psize = '$psize', lsize = '$lsize', views = '$views', price = '$price', brooms = '$brooms', bhrooms = '$bhrooms', lounges = '$lounges', kitchens = '$kitchens', images = '$insert_names'", $connection);
echo "The entry has been successfully added."; 

};

thank you.

[wempy]

... but the photos dont upload ...

what errors are you getting?

[BizBoy]

Warning: implode(): Bad arguments. in D:\webroot\propdb\admin.php on line 228

228: $insert_names=implode(",", $namelist); // make array a comma-seperated list

[Weedpacket]

$namelist won't exist if $_POST['MAX_FILE_SIZE'] doesn't have a value. Could that be your problem?

[BizBoy]

All the forums correct.

Heres the Upload forum

<!---Javascript in header for onChange-->
    <tr>
      <td>Upload Pictures</td>
      <td><select onChange=\"file('parent',this,0)\">
      <option value=\"$num\" selected>".$num;
		if($num > 0) {echo "\nSelected";} else {echo "\nNo Photos";};

echo "</option>";
for($a = 1; $a <= 10; $a++)
{
	echo "<option value=\"?act=add&num=$a\">$a ";
	if($a > 1) {echo "Photos";} else {echo "Photo";};
	echo "</option>";
};
echo "</select></td>
</tr>
<tr>
  <td class=\"con\"></td>
  <td>";
$numfile = $_GET['num'];
for($a = 0; $a < $numfile; $a++)
{
	echo "<input type=\"file\" name=\"pic[]\"><br>";
};
echo "<input type=\"hidden\" name=\"MAX_FILE_SIZE\" value=\"3000000\" /></td>
</tr>

[Weedpacket]

Try a print_r($FILES);. I think you've got your dimensions around the wrong way.

foreach($_FILES['pic'] as $picture)
{
  if($picture['error']==UPLOAD_ERR_OK)
  {
    $tmp_name = $picture['tmp_name'];
//....
  }
}