php email form?

starkutboy

Ok, I think I got a good php form set up, but I keep getting these errors when I click submit on my form...

Warning: Unexpected character in input: '\' (ASCII=92) state=1 in /home/prom/prominencemagazine-www/email/email.php on line 2

Parse error: parse error in /home/prom/prominencemagazine-www/email/email.php on line 2

This is the email.php (it's pretty long, for a subscription):

<?php
if (!isset($_POST['submit_form'])):
?>
<html>
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body marginwidth="0" marginheight="0" topmargin="0" leftmargin="0">
<form action="<?=$HTTP_SERVER_VARS['PHP_SELF']?>" method="post">
Name:<input type="text" name="newfname" size="35" value=""><br>

Email:<input type="text" name="newemail" size="35" value=""><br>
<input type="submit" name="submit_form" value="">
</form>
</body>
</html>
<?php else:
$newfname = $POST['newfname'];
$newemail = $POST['newemail'];
$qc = $_POST['qc'];
// Send html autoresponder email or whatever
$to = $newemail;
$subject = "thank you for subscribing";
$message = "
<html>
<head>
<title></title>
</head>
<body>
<font style=\"font-family:tahoma, arial, verdana;font-size:10pt\">
Dear $newfname,
<p>Thank you for subscribing. You will receive an email regarding your subscription within 2-3 business days.</p>
<p>Best Regards,</p>
<p>Prominence Magazine<br>
www.prominencemagazine.com</br>

</font>
</body>
</html>
";
$headers = "MIME-Version: 1.0\r\n";
$headers .= "Content-type: text/html; charset=iso-8859-1\r\n";
$headers .="From: Prominence Magazine <badboy_ES@hotmail.com>\r\n";
mail($to, $subject, $message, $headers);
// Done sending autoresponder
$date = date("F j, Y, g:i a" );

Form submitted on $date
";
$header = "From: My Newsletter <badboy_ES@hotmail.com>";
mail($to, $subject, $message, $header);
// Done notifying to administrator
?>

<html>
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body marginwidth="0" marginheight="0" topmargin="0" leftmargin="0">
<font style="font-family:tahoma, arial, verdana;font-size:10pt">
Dear <?=$newfname?>,
<p>Thank you for subscribing. You will receive an email regarding your subscription shortly.</p>
<p>Best Regards,</p>
<p>Prominence Magazine<br>
www.prominencemagazine.com

</font>
</body>
</html>
<?php endif; ?>

Can anyone see anything wrong with my php coding? Is there something I messed up, cause I don't know php too well, I had help on this.

thorpe

line 2 has : on the end instead of {

and in fact... i think you'll find a few more of these types of errors scattered through your code.

starkutboy

it's still giving me the same error. here's the form on the html page that is being submitted...maybe it has to do with that too.

<form action="/email/email.php" method="post">
<td valign="top" class="normblack" width="100%">
<p><font color="#800000"><b>E-mail this article to a friend:</b></font></p>
<input type="text" name="newfname" size="14" maxlength="200" value="First Name">
<br><br>
<input type="text" name="newlname" size="14" maxlength="200" value="Last Name">
<br><br>

						<input type="text" name="newemail" size="14" maxlength="40" value="Friend's E-mail">
						<br><img src="graphics/transparent.gif" alt="" width="1" height="5" hspace="0" vspace="0" border="0"><br>
						<input type="submit" name="submit_form" value="submit"></td>
					 	</form>

thorpe

like i said. i think your code has quite a few errors like that in it (im not going to dig through it). the form you posted is pure html, and the error you are getting is a php error.

your going to need to go through your code closer. i think you'll find quite a few syntax errors.

these types of errors are often easier to find if you indent your code, the way it is, i can hardly read it.

also... use the php tags provided by the board to highlight php syntax..... so much easier to read AND to see errors.

kburger

thorpe, I think that's actually valid alternate control structure syntax, although it looks strange to me too.

starkutboy

The thing is I don't know php really at all, I kind of pieced some things together here from a friends email thing. But i don't know what is actually considered normal php syntax. I think it's ok for the most part...not sure what $qc is...

<?php
if (!isset($_POST['submit_form']));
?>
<html>
<head>
<title></title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body marginwidth="0" marginheight="0" topmargin="0" leftmargin="0">
<form action="<?=$HTTP_SERVER_VARS['PHP_SELF']?>" method="post">
Name:<input type="text" name="newfname" size="35" value=""><br>
Email:<input type="text" name="newemail" size="35" value=""><br>
<input type="submit" name="submit_form" value="">
</form>
</body>
</html>

<?php else:

$newfname = $POST['newfname'];
$newemail = $POST['newemail'];
$qc = $_POST['qc'];

// Send html autoresponder email or whatever
$to = $newemail;
$subject = "thank you for subscribing";
$message = "
<html>
<head>
<title></title>
</head>
<body>
<font style=\"font-family:tahoma, arial, verdana;font- size:10pt\">
Dear $newfname,
<p>Thank you for subscribing. You will receive an email regarding your subscription within 2-3 business days.</p>
<p>Best Regards,</p>
<p>Prominence Magazine<br>
www.prominencemagazine.com</p>
</font>
</body>
</html>";

$headers = "MIME-Version: 1.0\r\n";
$headers = "Content-type: text/html; charset=iso-8859-1\r\n";
$headers = "From: Prominence Magazine <badboy_ES@hotmail.com>\r\n";
mail($to, $subject, $message, $headers);

// Done sending autoresponder
$date = date("F j, Y, g:i a" );

// Notify the new submission to the administrator
$to = "badboy_ES@hotmail.com";
$subject = "I would like a subscription to Prominence Magazine";
$message = "
The following submission has been received.
Name: $newfname $newlname
Email: $newemail
$qc
Form submitted on $date";
$header = "From: badboy_ES@hotmail.com";
mail($to, $subject, $message, $header);
// Done notifying to administrator
?>

</font>
</body>
</html>
<?php endif; ?>

kburger

One thing that would really help people trying to read your code in this forum is to wrap your code in [ PHP ] [ /PHP ] tags. That will do the syntax highlighting for us.😉

Here's a problem:

if (!isset($_POST['submit_form']));

should be

if (!isset($_POST['submit_form'])):

starkutboy

do you know where I can look at examples of some php. I'm not sure what's wrong with the code, that's why i'm tryin to get some help.

kburger

PHP has an excellent manual
Here's the control structure I'd use:

if (!isset($_POST['submit_form'])) {
	// display the form
} else {
	// process the form, send the email, thank them
}