[Resolved] Syntax Error

reflash

I need some help with a syntax error that I'm getting. I altered my database to change one field and add one. I then altered the form to reflect these changes, and altered the php code as well.

Here's the altered code:

$FName=$POST['FName'];
$LName=$POST['LName'];
$Color=$POST['Color'];
$Group=$POST['Group'];
$UName=$POST['UName'];
$PWord=$POST['PWord'];
$EMail=$_POST['EMail'];

mysql_connect($host, $user, $pass) or die('Connection died!');
mysql_select_db($db) or die('Selection died!');
$add_all="INSERT INTO $table (FName, LName, Color, Group, UName, PWord, EMail) values ('$FName','$LName','$Color','$Group','$UName','$PWord','$EMail');";
mysql_query($add_all) or die(mysql_error());

and here's the error:

You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'Group, UName, PWord, EMail) values ('xxxxx','xxxxxx','b','2','h

I did add the proper variables, etc., and everything looks OK - I'm probably missing something glaringly obvious...

reflash

BTW - the code was working before I made the changes.

drew010

judging by the error, it seems to be more likely a syntax error in the query itself rather than a problem with the fields. usually if you are referencing an inexisting value it will say unknown column 'x' or something like that.

try to echo the whole $add_all
prior to executing the query and see if it looks well formed

reflash

Hi drew,

Thanks for the reply. I echo'd it as you suggested, and it looks OK - all of the variables come through as entered into the form. I think it may have something to do with the $Group variable - the error message begins with that field name & ends with that variable. I just for the life of me can't see where the problem is.

In addition, it's not adding anything to the database.

klik

Hey,

Try the following. I assume $table already exists and has been declared.

$FName=$_POST['FName'];
$LName=$_POST['LName'];
$Color=$_POST['Color'];
$Group=$_POST['Group'];
$UName=$_POST['UName'];
$PWord=$_POST['PWord'];
$EMail=$_POST['EMail'];

mysql_connect($host, $user, $pass) or die('Connection died!');
mysql_select_db($db) or die('Selection died!');
$add_all = mysql_query("INSERT INTO $table (FName, LName, Color, Group, UName, PWord, EMail) VALUES ('$FName','$LName','$Color','$Group','$UName','$PW
ord','$EMail')") or die (mysql_error());

drew010

try backticking all your mysql column names, that could be it...

$add_all="INSERT INTO $table (FName, LName, Color, Group, UName, PWord, EMail) values ('$FName','$LName','$Color','$Group','$UName','$PW
ord','$EMail');";

reflash

Hi klik,

Thanks for the reply. That didn't work either. Just for clarity's sake, I'll post all of the code - here's the page:

<html>
<head>
<BODY>
Database Connect test page!<BR><BR>

<?php

if (isset($HTTP_POST_VARS['add']))
{

// Set Mysql Variables
$host='localhost';
$user='xxxxxx';
$pass='xxxxxx';
$db='xxxxxx';
$table='main';

// Set global variables to easier names
$FName=$POST['FName'];
$LName=$POST['LName'];
$Color=$POST['Color'];
$Group=$POST['Group'];
$UName=$POST['UName'];
$PWord=$POST['PWord'];
$EMail=$_POST['EMail'];

mysql_connect($host, $user, $pass) or die('Connection died!');
mysql_select_db($db) or die('Selection died!');
$add_all = "INSERT INTO $table (FName, LName, Color, Group, UName, PWord, EMail) values

('$FName','$LName','$Color','$Group','$UName','$PWord','$EMail')";
echo $add_all;
mysql_query($add_all) or die(mysql_error());

include 'form.inc.php';

}
else
{

include 'form.inc.php';

}
?>

</BODY>
</HTML>

reflash

Hi drew,

The backtick thing seems to have done it! Do you have any idea why it would have worked before this without the backticks? I added one more field... Maybe once you exceed 6 fields in a query you need to do that?

Thanks for your help!

Sorry for the delay in answering - I have to upload everything to my hosting service after implementing the changes, and then surf to the page to test. It's a little slow, but it works...

drew010

the backticks probably worked since Group is most likely a reserved work in mysql. I'm not really an sql expert so im not familiar with all the words and whats taken and whats not, but I know you can have a similar situation with columns called password since password is actually a function. im guessing its similar with group.