[Resolved] Mailing List Problem

[klik]

Hey,

I have a small mailing list script. The following code is emant to send the email message to every member who has signed up to the mailing list (mailing_list set to 1 in database)

Currently there are 3 members subscribed to the mailing list, but only one member receives it, and firther more they receive the message twice

	$sql = mysql_query("SELECT email FROM cms_users WHERE mailing_list='1'");
    	$participants = mysql_num_rows($sql);
    	$fetch = mysql_fetch_array($sql);

	foreach($fetch as $to){
 	   mail($to, "$subject", "$body", "FROM: webmaster <[e-mail]>");
	}

/* END Send the email */

Suggestions and help more than appreciated.
Thanks

[drew010]

id try something like this...

$sql = mysql_query("SELECT email FROM cms_users WHERE mailing_list='1'");
  if(mysql_num_rows($sql) > 0) {
    while($row = mysql_fetch_array($sql)) {
      mail($row['email'], $subject, $body, "From: \"webmaster\" <[e-mail]>");
    }
  }
//end mail code

the problem with what you had is the line
$fetch = mysql_fetch_array($sql);
mysql_fetch_array returns the contents of the next result row as an array. since there are multiple it needs to be done in a loop. calling that way only gets you the first row.

[klik]

Thanks a lot !

That did the trick. I've been pondering over this for ages as well. Thanks again.