[Resolved] [Resolved] [Resolved] PHP not running like it should on new server...

Yari

Hi,

I have a very strange problem... I recently purchased a new server with PHP 4.3.2-19.ent.

Since then, any php coded website I put up on this server don't run properly... I can't even work out exactly WHAT is going wrong, let me try to explain...

The website www.frankpetsh.com/index.php uses the new server. One the old server, I could browse through the different product ranges and different pages without a problem... on the new server it just stays on the homepage.

I.e. the first page:
http://www.frankpetsch.com/index.php
is the same as the SERVICES page
http://www.frankpetsch.com/index.php?page=services&subrange=none
when it should in fact show a different image and text.

This worked fine on the old server, but any PHP scripts don't seem to run beyond the first page on the new server.

I checked all my code, and I also checked the MySQL database, including doing manual queries from the db, which work correctly.

Does anyone have any ideas? The tech support people can't figure it out either.

Cheers,

yari

bradgrafelman

Do you declare those two variables in your script? I'm almost willing to bet money that you relied on register_globals on the old server.

Try adding this to the top of your script:

$page = (@$_GET['page'] ? $_GET['page'] : '');
$subrange = (@$_GET['subrange'] ? $_GET['subrange'] : '');

Yari

Hello Brad,

Thanks for helping... so, I need to declare variables first?

Something like: global $page

I tried coping and pasting your code in, it give me a parse error...

So, because I upgraded to a much newer version of PHP the way variables work are different? And do I need to declare the _GET for all variables?

Thanks,

yari

bradgrafelman

Variables work the same. Before, you probably had register_globals on. Essentially, this means PHP extracts all variables from GET, POST, SESSION, etc into their appropriate variable names for you. This is, however, considered a security risk. For more information, you can search this board for keywords such as "register globals" or "register_globals".

Also, are you sure the parse errors are because of my code? I just double checked it on my server and it works fine.

Lastly, the only time you'll have to manually global-ize a variable is if it is outside the scope (i.e. you're inside a function declaration when you're trying to use a variable previously defined outside of that declaration). While this may be the case, I'm not sure whether you would need to do this or not.

Yari

Wow, its working! I should have asked for help 10 days ago!

http://www.frankpetsch.com/index.php?page=services&subrange=none

So... to make sure I code my websites right from now on, this is what I did, is it ok (at top of page)?

(sorry, I tried using the

 but it kept cutting off my text...)
[code=php]$page=$_GET["page"];
$subrange=$_GET["subrange"];

Yari

Oops, for some reason my reply keeps getting cut off...

What I meant to say was, is this ok? And what are the advantages of the code you sent me above over mine?

Cheers,

Yari

bradgrafelman

I used the ternary operator in my code simply because in your code, a notice will be issued if the GET parameters don't exist.

In a production environement, you want to solve all errors, warnings, notices, etc. as possible, so I implemented a bit of error-checking. Your way though unrecommended will probably work fine.

Yari

Thank you Brad, I will try your code again to get it working on my server, but things are looking good!

Much appreciated!

bradgrafelman

Also, I used the ternary because I'm comfortable using it and I'm a bit lazy. If you are neither, you can certainly write it out:

if(!empty($_GET['page'])) $page = $_GET['page']; else $page = '';

Yari

Ah, I see!

An excellent choice of code then, I wasn't sure what it did, now I do and I'll be using it.

The problem seemed to be the spaces in the code, so I took them out and hey presto! it works now.

Thanks againBrad.

bradgrafelman

Anytime, mate!

EDIT: This thread has been resolved 3 times! lol... clicking the link once is enough; it'll prepend '[Resolved]' to the thread title.