question

[phpn00bf4life]

http://wghq.net/blocks.php?op=poll

<?php
include("config.php");
$query = "SELECT * FROM poll WHERE pid='.$_COOKIE['voted'].'";
	while($row = mysql_fetch_array(mysql_query($query))){
		$query2 = "SELECT * FROM poll ORDER BY pid DESC LIMIT 1";
			while($row2 = mysql_fetch_array($mysql_query($query2))){
				if($row['pid'] == $row2['pid']){
					$fin_query = mysql_query($query);
						if(@mysql_num_rows($fin_query) != "0"){
							$show_poll = "SELECT * FROM poll ORDER BY pid DESC LIMIT 1";
							$fin_show_poll = mysql_query($show_poll);
								while($poll_question = mysql_fetch_array($fin_show_poll)){
									echo'<b>'.$poll_question['pquestion'].'?</b><br>';
									$thepid = $poll_question['pid'];
									$totalvotes = $poll_question['totalvotes'];
									$display_results = "SELECT * FROM poll_options WHERE pid='$thepid' ORDER BY pid DESC LIMIT 16";
									$fin_display_results = mysql_query($display_results);
									while($precentages = mysql_fetch_array($fin_display_results)){
									if($precentages['votes']=="0"){
									echo'0';
									}else{
									$precentage = round(($precentages['votes'] / $totalvotes)*100);
									}
								echo''.$precentages['option'].' - '.$precentage.'%';
								}
						}
				} else {
					if(!$_POST['submit']){
						$poll_sel = "SELECT * FROM poll ORDER BY pid DESC LIMIT 1";
						$fin_poll_sel = mysql_query($poll_sel);
							while($poll_title=mysql_fetch_array($fin_poll_sel)){
								echo'<b>'.$poll_title['question'].'?</b><br>';
								$id = $poll_title['pid'];
								$totalvotes = $poll_title['totalvotes'];
							}
						$set_options = "SELECT * FROM poll_options WHERE pid='pid' ORDER BY oid DESC LIMIT 16";
						$fin_set_options = mysql_query($set_options);
						echo'<form method="POST" action="blocks.php?op=poll&pid='.$pid.'">';
						echo'<table border="0" cellpadding="4" cellspacing="0" style="border-collapse: collapse; font-size:10px; font-family:Arial" bordercolor="#111111" width="100%" id="AutoNumber2">';
							while($options=mysql_fetch_array($fin_set_options)){
							echo'<tr><td width="3%"><input type="radio" value="'.$options['oid'].'" checked name="options"></td><td width="97%">'.$options['option'].'</td></tr>';
						}
						echo'</table><p align="center"><input type="submit" value="Vote!" name="submit" style="font-size: 10px; font-family: Arial; color: #800000; border-style: solid; border-width: 1"></p></form>';
					} else {
						$add = + 1;
						$where = $_POST['options'];
						$insert_data = "UPDATE poll_options SET votes='$add' WHERE oid='$where'";
						$fin_insert_data = mysql_query($insert_data);
						$insert_data2 = "UPDATE poll_options SET totalvotes='$add' WHERE pid='$pid'";
						$fin_insert_data2 = mysql_query($insert_data2);
						set_cookie("voted","$pid",[phone]);
					}
				}
			}
		}
	}
?>

i already have some stuff in the mysql thing... anyways why is it not displaying anything?

[drew010]

i copied the code and ran it through the php interpreter in syntax check mode. there is a parse error, here it is.

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in test.php on line 3

i didnt look over the rest but i think the 3rd line should be changed from
$query = "SELECT FROM poll WHERE pid='.$COOKIE['voted'].'";
to
$query = "SELECT FROM poll WHERE pid='" . $COOKIE['voted'] . "'";

[phpn00bf4life]

it still doesn't show anything

[drew010]

i think there is another parse error.

at the top of the script put
ini_set("display_errors", 1);
error_reporting(E_ALL);

that should show you any problems with the code.

[phpn00bf4life]

so i did it. . . and sure enuff there was an error...what does this mean:

Notice: Undefined index: voted in /home/wghq3fb/public_html/blocks_inc/poll.inc.php on line 5

[drew010]

undefined indices have to do with arrays. if you have
$arr = array("key" => "value");

and you try to do

echo $arr['inexistant'];

if errors are turned on php will warn you that the index inexistant doesnt exist. so its basically saying 'voted' is being used as an index on line 5 of that file, but it isnt actually valid.

[phpn00bf4life]

<?php
session_start();
header("Cache-Control: Private");
ini_set("display_errors", 1); 
error_reporting(E_ALL); 
include("config.php");
if(!$_SESSION['voted']){
	if(!$_POST['submit']){
		$poll_sel = "SELECT * FROM poll ORDER BY pid DESC LIMIT 1";
		$fin_poll_sel = mysql_query($poll_sel);
			while($poll_title=mysql_fetch_array($fin_poll_sel)){
				echo'<b>'.$poll_title['question'].'?</b><br>';
				$id = $poll_title['pid'];
				$totalvotes = $poll_title['totalvotes'];
			}
		$set_options = "SELECT * FROM poll_options WHERE pid='$id' ORDER BY oid DESC LIMIT 16";
		$fin_set_options = mysql_query($set_options);
		echo'<form method="POST" action="blocks.php?op=poll&pid='.$pid.'">';
		echo'<table border="0" cellpadding="4" cellspacing="0" style="border-collapse: collapse; font-size:10px; font-family:Arial" bordercolor="#111111" width="100%" id="AutoNumber2">';
			while($options=mysql_fetch_array($fin_set_options)){
				echo'<tr><td width="3%"><input type="radio" value="'.$options['oid'].'" checked name="options"></td><td width="97%">'.$options['option'].'</td></tr>';
			}
			echo'</table><p align="center"><input type="submit" value="Vote!" name="submit" style="font-size: 10px; font-family: Arial; color: #800000; border-style: solid; border-width: 1"></p></form>';
	} else {
		$add = + 1;
		$where = $_POST['options'];
		$insert_data = "UPDATE poll_options SET votes='$add' WHERE oid='$where'";
		$fin_insert_data = mysql_query($insert_data);
		$insert_data2 = "UPDATE poll_options SET totalvotes='$add' WHERE pid='$pid'";
		$fin_insert_data2 = mysql_query($insert_data2);
		$_SESSION['voted'] = $pid;
	}
}else{

$show_poll = "SELECT * FROM poll ORDER BY pid DESC LIMIT 1";
$fin_show_poll = mysql_query($show_poll);
	while($poll_question = mysql_fetch_array($fin_show_poll)){
		echo'<b>'.$poll_question['pquestion'].'?</b><br>';
		$thepid = $poll_question['pid'];
		$totalvotes = $poll_question['totalvotes'];
		$display_results = "SELECT * FROM poll_options WHERE pid='$thepid' ORDER BY pid DESC LIMIT 16";
		$fin_display_results = mysql_query($display_results);
			while($precentages = mysql_fetch_array($fin_display_results)){
				if($precentages['votes']=="0"){
					echo'0';
				}else{
					$precentage = round(($precentages['votes'] / $totalvotes)*100);
				}
				echo''.$precentages['option'].' - '.$precentage.'%';
			}
	}
}
?>

still getting errors u can see the poll options and what not, but then u can't see the precentages etc..

[phpn00bf4life]

i think i got it...i'll post more later about how it goes thx for the help!

[drew010]

instead of using logic like
if(!$SESSION['voted']){
which asserts the variable is false,
use
if(!isset($SESSION['voted'])) {
which checks if the variable exists. the results will pretty much be the same, but the code is a bit more understandable, and of course wont generate errors.

after i first voted i wasnt able to see anything, but refreshing the page changed that.

[phpn00bf4life]

cool thx...i'm still learning PHP so this thread has taught me some new cool tricks. 🙂 anyways code clean up time 😉