[Resolved] [Resolved] simple question

[patsfans]

I've created a page for selling photographs, and just want to set up a script where it displays 12 photos at a time, with a script that displays the total number of photos followed by clickable links for each of the pages. Then when you click on the "next" link, it will display the next 12 with a "previous" link along with links to each of the numbered pages in between.

Example:

[photo]

30 total | Displaying 1-12 1 | 2 | 3 [next]

and then after you click it:

[photo]

30 total | Displaying 13-24 [previous] 2 | 3 [next]

I've been going over several different types of code and can't quite get one to work correctly, so if anyone has any answers, your help is appreciated.

Thanks again,

Ian

[Matt_Kindig]

I can help but I need some more information from you:

1. How does the script know which page it is on. A $GET in the URL might be easiest, or you can use cookies or $POST variables?

2. Why don't you want the script to display a "1" if you are on page "2"? This is different from the way most scripts like this are written (See, for example, the navigation pages at the bottom of the forums page on the board).

3. Without more of your code, I can't help you with the actual posting of photos. What code are you using to do that part?

[patsfans]

Originally posted by Matt Kindig
I can help but I need some more information from you:

1. How does the script know which page it is on. A $GET in the URL might be easiest, or you can use cookies or $POST variables?

2. Why don't you want the script to display a "1" if you are on page "2"? This is different from the way most scripts like this are written (See, for example, the navigation pages at the bottom of the forums page on the board).

3. Without more of your code, I can't help you with the actual posting of photos. What code are you using to do that part? [/B]

This is more or less the code:

$sql = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC";

$result = @($sql,$connection) or die("Couldn't Execute Query for # 1");

$i = 1;

$cols = 3;

$dollar = "$";

echo "<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=602><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>";

while ($row=mysql_fetch_array($result)) {

if ($i > $cols) { 
   echo "</tr><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>";
   echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "_sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font>&nbsp; $" . $row ["price"] . "<a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><br><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>"; 
   $i = 2; 
} else { 
   echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "_sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font>&nbsp;$" . $row ["price"] . "<br><a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>"; 
   $i++; 
} 

}

echo "</table>";

So right now it shows everything in the table and it's set up three rows at a time for that team (we have a page devoted to each one). I'm just trying to do it where it shows 12 at a time, and then allows users to go back and forth as shown in the earlier post. I've recently learned it's better for search engine optimization to have more pages related to the topic and was told this was wise to do if I have a large selection of items instead of having them all on one page.

To answer your other #2 question, I don't mind if it does. I was just omitted that by accident when I posted earlier.

Thanks for taking the time to help me, and thanks again in advance for your help!

Ian

[Matt_Kindig]

Here's what I came up with. Without your db I can't test it, so let me know if this works correctly and/or post any errors that you receive. Note that under $pageName I called this script photos.php. You'll want to change it if you called it something else.

I also modified your SQL query to only retrieve the 12 rows that will be displayed, to make the page load faster.

EDIT: Made some syntax corrections.

EDIT #2: Modified the $end variable so that it doesn't exceed the number of photos.

<?php
function makePageLink($pageNum,$linkTitle="") {
	$pageName="photos.php";
	$link= "<a href=\"".$pageName;
	$link.= "?page=\"" .$pageNum. ">";
	if ($linkTitle != "") {
		$link .= $linkTitle;
	} else { 
		$link .= $pageNum;
	}
	$link.= "</a>";
	return $link;
}

$whichPage=$_GET["page"];




//gets number of rows/photos
$sql1="SELECT COUNT(*) FROM mlb WHERE team = '$team'";
$numPhotos=mysql_query($sql1);

//number of pages of 12 photos each
$numPages= ceil($numPhotos / 12);
//determines where to start and end count
$start=($whichPage-1)*12+1;
$end=min($whichPage*12,$numPhotos);

//get 12 entries that will be displayed
$sql2 = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC LIMIT $start,12 "; 

$result = @mysql_query($sql2,$connection) or die("Couldn't Execute Query for # 1"); 

$i = 1; 
$cols = 3; 
$dollar = "$"; 

echo "<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=602><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>"; 

while ($row=mysql_fetch_array($result);
if ($i > $cols) { 
echo "</tr><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>"; 
echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "_sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font>  $" . $row ["price"] . "<a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><br><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>"; 
$i = 2; 
} else { 
echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "_sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font> $" . $row ["price"] . "<br><a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>"; 
$i++; 
} 

} 
echo "</table>"; 

echo $numPhotos. " total | Displaying " .$start. "-" .$end;
if ($whichPage != 1) {
	$link=makePageLink($whichPage-1,"[previous]");
                echo $link;
}
for ($iter=1; $iter<= $numPages; ++$iter) {
	$link=makePageLink($iter);
	echo $link." | ";
}
if ($whichPage != $numPages) {
	$link=makePageLink($whichPage+1,"[next]");
               echo $link;
}

?>

😉

[patsfans]

Slight problem. I modified it with your code to fill in the display block and it comes up now where the page just comes up blank. I also obviously replaced the page name (photos.php) with the correct one. I've gone over it and can't find the error....so I'm a bit perplexed. Usually it's a ", }, or a ; but I can't quite find it.

Here's the code I used:

<?

$dbname = "[databasename]";

$connection = @mysql_connect("localhost", "[username]", "[password]") or die("Couldn't Connect.");

$db = @mysql_select_db($dbname, $connection) or die("Couldn't Select Database.");

//$price is the value for unframed pictures
//$framed is the value for framed pictures
$team = "[team]";

$sql = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC";

$result = @($sql,$connection) or die("Couldn't Execute Query for # 1");

function makePageLink($pageNum,$linkTitle="") {
$pageName="photos.php";
$link= "<a href=\"".$pageName;
$link.= "?page=\"" .$pageNum. ">";
if ($linkTitle != "") {
$link .= $linkTitle;
} else {

$link .= $pageNum;
}
$link.= "</a>";
return $link;
}

$whichPage=$_GET["page"];

//gets number of rows/photos
$sql1="SELECT COUNT(*) FROM mlb WHERE team = '$team'";
$numPhotos=mysql_query($sql1);

//number of pages of 12 photos each
$numPages= ceil($numPhotos / 12);
//determines where to start and end count
$start=($whichPage-1)12+1;
$end=min($whichPage12,$numPhotos);

//get 12 entries that will be displayed
$sql2 = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC LIMIT $start,12 ";

$result = @($sql2,$connection) or die("Couldn't Execute Query for # 1");

$i = 1;

$cols = 3;

$dollar = "$";

echo "<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=602><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>";

while ($row=mysql_fetch_array($result);
if ($i > $cols) {

echo "</tr><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>";

echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font> $" . $row ["price"] . "<a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><br><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>";

$i = 2;

} else {

echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font> $" . $row ["price"] . "<br><a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>";

$i++;

}

}

echo "</table>";

echo $numPhotos. " total | Displaying " .$start. "-" .$end;
if ($whichPage != 1) {
$link=makePageLink($whichPage-1,"[previous]");
echo $link;
}
for ($iter=1; $iter<= $numPages; ++$iter) {
$link=makePageLink($iter);
echo $link." | ";
}
if ($whichPage != $numPages) {
$link=makePageLink($whichPage+1,"[next]");
echo $link;
}

?>

Any ideas? Thanks for taking the time to help me, I appreciate it.

Ian

[drew010]

at the top of the script put
ini_set("display_errors", 1);
error_reporting(E_ALL);

and it will show you any parse errors

[patsfans]

It's strange. I inserted that yet it still comes up blank. This one has me puzzled.

Ian

[Matt_Kindig]

I've noticed that you use the '@' symbol to suppress most of the errors on your mysql queries. Try removing those to see if you have mysql errors. That might explain the blank page.

[patsfans]

Originally posted by Matt Kindig
I've noticed that you use the '@' symbol to suppress most of the errors on your mysql queries. Try removing those to see if you have mysql errors. That might explain the blank page.

Hey Matt, I took your advice and tried that, yet it's still blank. I've gone over the code several times to see if I missed something an can't see anything. Any ideas?

Ian

[drew010]

i ran a syntax check on it, here is what i got...

-bash-2.05b$ php -l test.php

Parse error: parse error, unexpected ';' in test.php on line 56
Errors parsing test.php

when i change line 56 to
while ($row=mysql_fetch_array($result)) {
it then had no errors

[Matt_Kindig]

Of course! I apologize for the error in my code. I can't believe I made that silly error.

[patsfans]

Originally posted by drew010
i ran a syntax check on it, here is what i got...

-bash-2.05b$ php -l test.php

Parse error: parse error, unexpected ';' in test.php on line 56
Errors parsing test.php

when i change line 56 to
while ($row=mysql_fetch_array($result)) {
it then had no errors

Odd

Getting closer. I changed that and now I got this error:

Notice: Undefined index: page in /home/httpd/vhosts/prosportspictures.com/httpdocs/mlb/redsox/test.php on line 33

Resource id #5 total | Displaying -11-0[previous]1 | [next]

I'm calling the file "test.php" and changed that in this line:

$pageName="test.php";

Line 33 is this:

$whichPage=$_GET["page"];

Ian

[Matt_Kindig]

Also, you can probably take out that first mysql_query statement, i.e. the one that is

$sql = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC";

$result = @mysql_query($sql,$connection) or die("Couldn't Execute Query for # 1");

as you do not use the $result for anything later in the script, and running the query will just slow down the page load.

[patsfans]

Originally posted by Matt Kindig
Also, you can probably take out that first mysql_query statement, i.e. the one that is

$sql = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC";

$result = @mysql_query($sql,$connection) or die("Couldn't Execute Query for # 1");

as you do not use the $result for anything later in the script, and running the query will just slow down the page load. [/B]

Done. Error is now on line 31 which was the

$whichPage=$_GET["page"];

line. I'm not familiar with that one so I haven't been able to figure that out yet.

Ian

[Matt_Kindig]

Add this statement after line 31:

if ($whichPage=="") {
  $whichPage=1;
}

and let us know.

[drew010]

the undefined index error means that key doesnt exist in the array, which happens when ?page=xxx isnt there.

try this:

if (!isset($_GET['page'])) {
  $whichPage = 1;
} else {
  $whichPage = $_GET['page'];
}

that should supress the error as well as cover your bases if no page is set.

[patsfans]

Originally posted by drew010
the undefined index error means that key doesnt exist in the array, which happens when ?page=xxx isnt there.

try this:

if (!isset($_GET['page'])) {
  $whichPage = 1;
} else {
  $whichPage = $_GET['page'];
}

that should supress the error as well as cover your bases if no page is set. [/B]

Hey guys, I tried this as well and now the photos opened, but I still got the same error message along with this appearing at the bottom:

Resource id #4 total | Displaying 1-Resource id #4 1 |

When you click on the 1 it takes me to a blank page (no photos) with this at the top:

Resource id #4 total | Displaying -11-0[previous]1 | [next]

With no value here in the linkbox: http://www.[url]/mlb/team/test.php?page=

Ian

[drew010]

the reason it shows Resource ID #4 is because you are trying to echo a value that is a resource, in this case a mysql connection id.
the problem comes from
$numPhotos=mysql_query($sql1);
and
$end=min($whichPage*12,$numPhotos);

you issued the query but you still have to retrive the results with mysql_fetch_row or mysql_fetch_array.

try
$numPhotos=mysql_query($sql1);
$photoCount = mysql_fetch_row($numPhotos);
$photoCount = $photoCount[0];

then
$end=min($whichPage*12,$photoCount);

[patsfans]

Originally posted by drew010
the reason it shows Resource ID #4 is because you are trying to echo a value that is a resource, in this case a mysql connection id.
the problem comes from
$numPhotos=mysql_query($sql1);
and
$end=min($whichPage*12,$numPhotos);

you issued the query but you still have to retrive the results with mysql_fetch_row or mysql_fetch_array.

try
$numPhotos=mysql_query($sql1);
$photoCount = mysql_fetch_row($numPhotos);
$photoCount = $photoCount[0];

then
$end=min($whichPage*12,$photoCount);

Done...however I still get the error regarding line #31, and the bottom looks like this:

Resource id #4 total | Displaying 1-121 |

Here's the code as it stands now:

<?

ini_set("display_errors", 1);
error_reporting(E_ALL);
$linktext2 ="";
$dbname = "[dbname]";

$connection = @mysql_connect("localhost", "[username]", "[password]") or die("Couldn't Connect.");

$db = @mysql_select_db($dbname, $connection) or die("Couldn't Select Database.");

$sql = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC";

function makePageLink($pageNum,$linkTitle="") {
$pageName="test.php";
$link= "<a href=\"".$pageName;
$link.= "?page=\"" .$pageNum. ">";
if ($linkTitle != "") {
$link .= $linkTitle;
} else {

$link .= $pageNum;
}
$link.= "</a>";
return $link;
}

$whichPage=$_GET["page"];

if (!isset($GET['page'])) {
$whichPage = 1;
} else {
$whichPage = $GET['page'];
}

//gets number of rows/photos
$sql1="SELECT COUNT(*) FROM mlb WHERE team = '$team'";

$result1 = @($sql1,$connection) or die("Couldn't Execute Query for # 1");

$numPhotos=mysql_query($sql1);
$photoCount = mysql_fetch_row($numPhotos);
$photoCount = $photoCount[0];

//number of pages of 12 photos each
$numPages= ceil($numPhotos / 12);
//determines where to start and end count
$start=($whichPage-1)12+1;
$end=min($whichPage12,$photoCount);

//get 12 entries that will be displayed
$sql2 = "SELECT * FROM mlb WHERE team = '$team' ORDER BY year,gid DESC LIMIT $start,12";

$result = @($sql2,$connection) or die("Couldn't Execute Query for # 1");

$i = 1;

$cols = 3;

$dollar = "$";

echo "<TABLE BORDER=0 CELLSPACING=0 CELLPADDING=5 WIDTH=602><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>";

while ($row=@mysql_fetch_array($result)) {
if ($i > $cols) {

echo "</tr><tr><td colspan=$cols HEIGHT=10><IMG SRC=\"/images/dot.gif\"></td></tr><tr VALIGN=TOP>";

echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font> $" . $row ["price"] . "<a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><br><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>";

$i = 2;

} else {

echo "<td WIDTH=190><table border=\"1\" width=\"100%\" bordercolor=\"#DCDCDC\" cellspacing=\"0\" cellpadding=\"5\"><tr><td><p align=\"center\"><IMG SRC=\"/images/mlb/" . $row["team"] . "/" . $row["year"] . "" . $row["photo"] . "sm.jpg\" alt=\"$team Pictures: " . $row["player"] . " - " . $row["description"] . "\" " . $row["position"] . "><br><font size=\"1\" face=\"Arial\"><center><b>$team Photo:<br>" . $row ["name"] . "<br><font size=\"1\" face=\"Arial\"><font color=\"#800000\"><strike>Price $ " . $row ["regular"] . "</strike></font> $" . $row ["price"] . "<br><a href=\"/mlb/display.php?id=" . $row ["item_id"] . "$linktext2\"><IMG SRC=\"/images/view_item.jpg\" width=70 height=20 border=0></a></center></td></tr></table></td>";

$i++;

}

}

echo "</table>";

echo $numPhotos. " total | Displaying " .$start. "-" .$end;
if ($whichPage != 1) {
$link=makePageLink($whichPage-1,"[previous]");
echo $link;
}
for ($iter=1; $iter<= $numPages; ++$iter) {
$link=makePageLink($iter);
echo $link." | ";
}
if ($whichPage != $numPages) {
$link=makePageLink($whichPage+1,"[next]");
echo $link;
}

?>

You guys have been a lot of help, I appreciate it.

Ian

[drew010]

for the line 31 error, you want to completely get rid of the line
$whichPage=$_GET["page"];
because its handled by the if statement.

and for the other resource id problem, you will need to use mysql_fetch_row just the same as i showed before for that query too. basically you have to do it after every query if you want to see the results.

and a note about it, it will return the next row in the resultset, so if you have multiple rows being returned, you need to loop over it like

while($row = mysql_fetch_row($result)) {
echo $row[0] . "<br />";
}

to show all the data returned.