[Resolved] my form is inserting 1,311 rows instead of 1

[jkarr]

Hello,

I have a form to add vendor information to a database. At the end of the form are three buttons. Add and Return Home, Add and Add Another, and Cancel.

All three buttons work, except one button does something strange!

The Add and Return Home button works perfectly as well as the Cancel button.

The Add and Add Another works except it adds the current entry 1,311 times. No joke!

Here is the code I am using for the three buttons:

if(isset($_POST['cancel']))
{
echo "<font color=red>ACTION CANCELED BY USER.</font>";
include 'vendor_management_nonav.php';
}
elseif(isset($_POST['addno'])) 
{ 
$name = $_POST['name'];
$add1 = $_POST['add1'];
$add2 = $_POST['add2'];
$add3 = $_POST['add3'];
$city = $_POST['city'];
$state = $_POST['state'];
$zip = $_POST['zip'];
$phone = $_POST['phone'];
$fax = $_POST['fax'];
$contact_fname = $_POST['contact_fname'];
$contact_lname = $_POST['contact_lname'];
$contact_email = $_POST['contact_email'];
//Inserts New Vendor Into Table
$vendors = "_vendors";
$company2 = $company;
$company2 = eregi_replace(' ', "_", $company2);
$company_vendors = $company2 . $vendors;
mysql_query("INSERT INTO $company_vendors (name, add1, 
add2, add3, city, state, zip, phone, fax, contact_fname, 
contact_lname, contact_email) VALUES 
('$name', '$add1', '$add2', '$add3', '$city', '$state', '$zip', '$phone',
 '$fax', '$contact_fname', '$contact_lname', '$contact_email')")
 or die(mysql_error()); 
include 'vendor_management_nonav.php';
} 
elseif(isset($_POST['addmore']))
{
$name = $_POST['name'];
$add1 = $_POST['add1'];
$add2 = $_POST['add2'];
$add3 = $_POST['add3'];
$city = $_POST['city'];
$state = $_POST['state'];
$zip = $_POST['zip'];
$phone = $_POST['phone'];
$fax = $_POST['fax'];
$contact_fname = $_POST['contact_fname'];
$contact_lname = $_POST['contact_lname'];
$contact_email = $_POST['contact_email'];
//Inserts New Vendor Into Table
$vendors = "_vendors";
$company2 = $company;
$company2 = eregi_replace(' ', "_", $company2);
$company_vendors = $company2 . $vendors;
mysql_query("INSERT INTO $company_vendors (name, add1, 
add2, add3, city, state, zip, phone, fax, contact_fname, 
contact_lname, contact_email) VALUES 
('$name', '$add1', '$add2', '$add3', '$city', '$state', '$zip', '$phone',
 '$fax', '$contact_fname', '$contact_lname', '$contact_email')")
 or die(mysql_error()); 
include 'vendor_add_nonav.php';
} 
else 
{ 
<form here>

The addno button is Add and Return Home the addmore is Add and Add Another. They should both be exactly the same except for the include line because I copied/pasted it. The Add and Add Another is a new feature I'm trying to impliment. Since I copied/pasted I just can't figure out what's wrong.

If anyone has any ideas, I should would appreciate it.

Thanks,
Johnie Karr
Church of Christ
www.godsbible.org

[bradgrafelman]

What's in 'vendor_management_nonav.php' and so on? Are you sure these scripts aren't somehow adding the query again? I have no clue what the contents of these scripts are, so I'm just guessing.

Also, try debugging your query:

$query = "INSERT INTO $company_vendors (name, add1, 
add2, add3, city, state, zip, phone, fax, contact_fname, 
contact_lname, contact_email) VALUES  

('$name', '$add1', '$add2', '$add3', '$city', '$state', '$zip', '$phone', 
'$fax', '$contact_fname', '$contact_lname', '$contact_email')";

echo 'Query is:<hr>' . $query . '<hr><br><br>';
$exec = mysql_query($query) or die('Error, MySQL said: ' . mysql_error());

echo 'There were <b>' . mysql_affected_rows() . '</b> rows inserted.';

and let us know the output.

[jkarr]

vendor_management_nonav.php just has a table that displays the vendor list. There is only SELECT query's on that page.

I'll run the script you gave now and see the output.

Thanks,
Johnie Karr

[jkarr]

Here is the output from that script:

Query is:

INSERT INTO Company_Dunno_vendors (name, add1, add2, add3, city, state, zip, phone, fax, contact_fname, contact_lname, contact_email) VALUES ('', '', '', '', '', '', '', '', '', '', '', '')

There were 1 rows inserted.

Thanks again,
Johnie Karr

[jkarr]

I am attaching the four .php files being used if it will help any:

vendor_management.php
vendor_management_nonav.php
vendor_add.php
vendor_add_nonav.php

[jkarr]

My apologies to bradgrafelman, as I should have thought of this when you asked about the page vendor_add_nonav but;

I was walking around the house this morning and I thought of the problem. I just don't know how to fix it. The problem is that when you click the Add and Add More button it brings up the exact same form again, with the same variables and button names. So, what it is doing is looping itself, until the database gets full, or until I move the browser to a different page, I'm not sure. So, I need to figure away so that when vendor_add_nonav.php loads, it does not recognize that the 'addmore' button is checked. Here is a timeline (of sorts) of what I think is going on.

We start at vendor_add.php with a simple form. We elect to Add and Add More so the code that takes effect is as follows:

elseif(isset($_POST['addmore']))
{
$name = $_POST['name'];
$add1 = $_POST['add1'];
$add2 = $_POST['add2'];
$add3 = $_POST['add3'];
$city = $_POST['city'];
$state = $_POST['state'];
$zip = $_POST['zip'];
$phone = $_POST['phone'];
$fax = $_POST['fax'];
$contact_fname = $_POST['contact_fname'];
$contact_lname = $_POST['contact_lname'];
$contact_email = $_POST['contact_email'];
//Inserts New Vendor Into Table
$vendors = "_vendors";
$company2 = $company;
$company2 = eregi_replace(' ', "_", $company2);
$company_vendors = $company2 . $vendors;
mysql_query("INSERT INTO $company_vendors (name, add1, 
add2, add3, city, state, zip, phone, fax, contact_fname, 
contact_lname, contact_email) VALUES 
('$name', '$add1', '$add2', '$add3', '$city', '$state', '$zip', '$phone',
 '$fax', '$contact_fname', '$contact_lname', '$contact_email')")
 or die(mysql_error()); 
include 'vendor_add_nonav.php';
} 

There is nothing wrong with the query, like we have been checking. Notice the

include 'vendor_add_nonav.php';

So in theory it should bring up another form for us to fill out. The problem is that it has the same elseif as above so it is automatically recognizing to send the data and load vendor_add_nonav.php which put's itself in a loop.

Now, I need to figure out how I can make it not loop. I have thought about using different button names on this page, but that would not work because if the user clicked Add and Add More on this second page then it would loop from there.

So, is there a way I could, instead of doing

include 'vendor_add_nonav.php'; 

I could cause the page to load 'vendor_add.php' as a new page? I'm thinking maybe a meta refresh tag, so I'll try moving my if statements to the header and doing that. I'll post my results.

Sorry again bradgrafelman that I didn't think of this when you asked if vendor_add_nonav was sending the query again.

Johnie Karr
Church of Christ
www.godsbible.org

[jkarr]

Ok, that fixed it.

What I did was only moved the code for 'addmore' to the header of my document, I left the rest alone since they will be using the include statement, I don't want to include the pages inside the header. When I moved the code to the head, I changed it from an elseif to if and left the if<cancel> and elseif<addno> the same.

Here is my new code:

<title>Inventory Management System -- Version 1.1</title>
<?
if(isset($_POST['addmore']))
{
$name = $_POST['name'];
$add1 = $_POST['add1'];
$add2 = $_POST['add2'];
$add3 = $_POST['add3'];
$city = $_POST['city'];
$state = $_POST['state'];
$zip = $_POST['zip'];
$phone = $_POST['phone'];
$fax = $_POST['fax'];
$contact_fname = $_POST['contact_fname'];
$contact_lname = $_POST['contact_lname'];
$contact_email = $_POST['contact_email'];
//Inserts New Vendor Into Table
$vendors = "_vendors";
$company2 = $company;
$company2 = eregi_replace(' ', "_", $company2);
$company_vendors = $company2 . $vendors;
mysql_query("INSERT INTO $company_vendors (name, add1, 
add2, add3, city, state, zip, phone, fax, contact_fname, 
contact_lname, contact_email) VALUES 
('$name', '$add1', '$add2', '$add3', '$city', '$state', '$zip', '$phone',
 '$fax', '$contact_fname', '$contact_lname', '$contact_email')")
 or die(mysql_error());
?>
<meta http-equiv="refresh" content="0;url=http://www.godsbible.org/inventory/1.1/vendor_add.php">
<?
}
?>
</head>

I hope this will help somebody in the future. Thanks again for your help, and I'm sorry I didn't think of this before I posted, and I'm sorry that I didn't start thinking about this when bradgrafelman asked about it.

Thanks, and Sorry,
Johnie Karr
Church of Christ
www.godsbible.org