[Resolved] multiple forms

hakancs24

hello,
my problem is with multiple forms.

This php page gets the a few variables from another php page.
I want to send differenzt querys when user submits the different forms. i am trying to call functions in action tag but it doesnt work. i am getting "You don't have permission to access /PROGRAMM/" error. programm is the directory of pages.

any idea?

<html><head><title>Manage User</title></head><body>
<?
include("verbinden.php");
$neuFunk="unknown";
if($funktions=="admin"){$neuFunk="user";}
else if($funktions=="user"){$neuFunk="admin";}
else{}
?>

<h2><font color="blue"><center><u>MANAGE USER</u><center></font></h2><hr>
<form name="functionform" method="post" action="<? change_Funktion ?>">
<br><h3><u>Change function</u></h3>
<table cellpadding="5" cellspacing="5" width="90%" hight="25%">
<tr><td width="20%"><b>username :</b></td><td width="15%" align="left"><?echo $usernames ?></td>
<td width="15%"><b>Comments :</b></td><td width="25%"><input type="text" name="Comments" value="<? echo $comments ?>" size="30"></td>
<td width="15%" align="right"><b>function :</b></td><td width="20%">
<select name="func" size="1">
<option><? echo $funktions ?> </option>
<option><? echo $neuFunk ?> </option>
</select>
</td><td width="20%"><input type="submit" name="sbutton_1" value="change_function"></td></tr></table>
</form>

<br><hr><br>
<h3><u>Rename user</u></h3>
<form name="usernameform" method="post" action="<? ?>">
<table cellpadding="5" cellspacing="5" width=290%" hight="25%">
<tr><td width="15%"><b>old Name :</b></td><td width="25%"><input type="text" name="oldName" readonly value="<? echo $usernames ?>"></td>
<td width="15%"><b>new Name :</b></td><td width="25%"><input type="text" name="newName"></td>
<td width="20%"><input type="submit" name="sbutton_2" value="rename"></td></tr></table>
</form>

<br><hr><br>
<h3><u>Change password</u></h3>
<form name="passform" method="post" action="<? ?>">
<table cellpadding="5" cellspacing="5" width="90%" hight="25%">
<tr><td width="15%"><b>new Password :</b></td><td width="25%"><input type="password" name="pass_1"></td>
<td width="15%"><b>confirm :</b></td><td width="25%"><input type="password" name="pass_2"></td>
<td width="20%"><input type="submit" name="sbutton_3" value="change"></td></tr></table>
</form>

<br><hr>
<div align="center">
<h3><u><font color="red"><b>Delete user</b></font></u></h3>
<form name="deluserform" method="post" action="<? ?>">
<input type="submit" name="sbutton" value="delete <? echo $usernames ?>" style="color: #FF0000; font-size: 10pt; font-weight: bold; border: 1px solid #FF0000;height: 35;">
</form></div>

nemonoman

i am trying to call functions in action tag but it doesnt work.

Thats correct. The '<form action=' must call a FILE, not a FUNCTION

What you want is:

if you have many forms all calling the same page:
<form name=myform1 action=mypage.php method=post>
<input type=hidden name=formname value='form1'>

in the file 'mypage.php'

<?
$form=$_POST['formname'];

if($form==1){
  myfunction1();
}
elseif($form==2){
myfunction2();
}
elseif($form==3){
myfunction3();
}
// and so on.
?>

hakancs24

Thank you for the answer,

is it not possible also with $PHP_SELF ?

i saw something like this but i dont know how it works.

nemonoman

You can of course make the action file the same as the page-creating file:

<form name=myform1 action=<? echo $PHP_SELF ?> method=post>
<input type=hidden name=formname value='form1'>

then your file would start with

<?
$form=$_POST['formname'];

if($form==1){
  myfunction1();
}
elseif($form==2){
  myfunction2();
}
elseif($form==3){
  myfunction3();
}
// and so on

//you would then include the php code that you now use to create the page.

hakancs24

i tried to do that
the first page sends a few parameters to this page, these are :
$funktions
$usernames
$comments

when i reload the page with $PHP_SELF
then they release their values. So i see undefined variables error.

Is it possible to save their values so that when i reload the page they are still there?

nemonoman

Sure:

in your forms include the submitted values in hidden fields:
<input type=hidden name=funktions value=<? echo $funktions ?> >

hakancs24

So thank you so much i think it will work
but i am still getting following notices/errors. I dont know why

Notice: Undefined variable: funktions in manusers.php on line 5

Notice: Undefined variable: funktions in manusers.php on line 6

Notice: Undefined variable: neuFunk1 in manusers.php on line 81

Notice: Undefined variable: comments1 in manusers.php on line 81

Notice: Undefined variable: oldusername in manusers.php on line 81

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'comments1= WHERE name=' at line 1

left.php

<html>
<head>
<style>
a:link{color:#003399}
a:visited{color:#800080}
a:hover{color:#FF3300}
</style>
</head>
<body bgcolor="#FF661C" topmargin="0" leftmargin="0" marginwidth="0" marginheight="0">
<?
include("verbinden.php");
$ver=verbind();

$query="select * from benutzer ORDER BY name ASC ";
$ergebnis=mysql_query($query,$ver);
$anzahlRows=0;
if(!$ergebnis)
{
echo mysql_error();
}
else
{
$dbnamen=array();
$dbken=array();
$dbfunk=array();
$dbcomments=array();
$i=0;
$anzahlRows=mysql_num_rows($ergebnis);
while($zeile=mysql_fetch_array($ergebnis))
{
$dbnamen[$i]=$zeile[0];
$dbken[$i]=$zeile[1];
$dbfunk[$i]=$zeile[2];
$dbcomments[$i]=$zeile[3];
$i++;
}
mysql_free_result($ergebnis);
mysql_close($ver);
}
echo "<br><center><font color='white' size='4'>USERS</font></center><hr>";
for($j=0;$j<$anzahlRows;$j++)
{
echo "    <a href='manusers.php?usernames=$dbnamen[$j]&passwords=$dbken[$j]&funktions=$dbfunk[$j]&comments=$dbcomments[$j]&rows=$anzahlRows' target='Data'>$dbnamen[$j]</a><br>";
}
?>
</body>
</html>

manusers.php

<html><head><title>Manage User</title></head><body>
<?
include("verbinden.php");
$neuFunk="unknown";
if($funktions=="admin"){$neuFunk="user";}
else if($funktions=="user"){$neuFunk="admin";}
else{}

$form=$_POST['functionsform'];
if($form=="form1")
{
change_Funktion();
}
elseif($form=="form2")
{
rename_Funktion();
}
elseif($form=="form3")
{
changePass_Funktion();
}
else
{
deleteBen_Funktion();
}
?>
<h2><font color="blue"><center><u>MANAGE USER</u><center></font></h2><hr>

<form name="functionform" method="post" action="<? echo $PHP_SELF ?>">
<input type=hidden name="functionsform" value="form1">
<br><h3><u>Change function</u></h3>
<table cellpadding="5" cellspacing="5" width="90%" hight="25%">
<tr><td width="20%"><b>username :</b></td><td width="15%" align="left"><?echo $usernames ?></td>
<td width="15%"><b>Comments :</b></td><td width="25%"><input type="text" name="Comments" value="<? echo $comments ?>" size="30"></td>
<td width="15%" align="right"><b>function :</b></td><td width="20%">
<select name="func" size="1">
<option><? echo $funktions ?> </option>
<option><? echo $neuFunk ?> </option>
</select>
</td><td width="20%"><input type="submit" name="sbutton_1" value="change_function"></td></tr></table>

</form>
<br><hr><br>
<h3><u>Rename user</u></h3>
<form name="usernameform" method="post" action="<? echo $PHP_SELF ?>">
<input type=hidden name="functionsform" value="form2">
<table cellpadding="5" cellspacing="5" width=290%" hight="25%">
<tr><td width="15%"><b>old Name :</b></td><td width="25%"><input type="text" name="oldName" readonly value="<? echo $usernames ?>"></td>
<td width="15%"><b>new Name :</b></td><td width="25%"><input type="text" name="newName"></td>
<td width="20%"><input type="submit" name="sbutton_2" value="rename"></td></tr></table>
<input type=hidden name=oldusername value=<? echo $usernames ?> >
</form>

<br><hr><br>
<h3><u>Change password</u></h3>
<form name="passform" method="post" action="<? echo $PHP_SELF ?>">
<input type=hidden name="functionsform" value="form3">
<table cellpadding="5" cellspacing="5" width="90%" hight="25%">
<tr><td width="15%"><b>new Password :</b></td><td width="25%"><input type="password" name="pass_1"></td>
<td width="15%"><b>confirm :</b></td><td width="25%"><input type="password" name="pass_2"></td>
<td width="20%"><input type="submit" name="sbutton_3" value="change"></td></tr></table>
</form>

<br><hr>
<div align="center">
<h3><u><font color="red"><b>Delete user</b></font></u></h3>
<form name="deluserform" method="post" action="<? echo $PHP_SELF ?>">
<input type=hidden name="functionsform" value="form4">
<input type="submit" name="sbutton_4" value="delete <? echo $usernames ?>" style="color: #FF0000; font-size: 10pt; font-weight: bold; border: 1px solid #FF0000;height: 35;">
</form></div>

<?
function change_Funktion()
{
$ver=verbind();
$query="UPDATE benutzer SET funktion=".$neuFunk1.",comments1=".$comments1." WHERE name=".$oldusername;
$ergebnis=mysql_query($query,$ver);
if(!$ergebnis)
{
echo mysql_error();
}
else
{
echo "<script language='JavaScript'>";
echo "alert('User function has been successfuly changed');";
echo "</script>";
mysql_free_result($ergebnis);
mysql_close($ver);
}
}

function rename_Funktion()
{

}

function changePass_Funktion()
{

}
function deleteBen_Funktion()
{

}

?>
</body></html>

nemonoman

in your function

Your query:
$query="UPDATE benutzer SET funktion=".$neuFunk1.",comments1=".$comments1." WHERE name=".$oldusername;

references $neuFunk1, $comments1, $oldusername

these have not been declared within the scope of the function, so as far as the query is concerned, they don't exist.

so your query reads:
UPDATE benutzer SET funktion=,comments1=WHERE name=

Which will cause MYSQL to fail.

2 things will fix this:

declare the variables within the scope of the function, either by parameters

change_Funktion($neuFunk1, $comments1, $oldusername)

or by declaring as globals:
change_Funktion(){
global $neuFunk1, $comments1, $olduser;

also your query is sending STRINGs to the database, so you have to include quotes. you can also leave out the "." approach, thus:

$query="
UPDATE benutzer
SET funktion='$neuFunk1',
comments1='$comments1'
WHERE name='$oldusername'
";

hakancs24

Great!
Thank you so much for your help.
It works now. I still get some notices but i think i have to disable notices in php.ini

sincerely
Hakan