[Resolved] Removing element in array problem

Trilogen

Hi I have a case which is supposed to remove indexes in an array. It messes up all the time. I'm not sure if my code is correct. Let me know if something is out of place.

case "Remove":
			$cart = array();
			$cart = $_SESSION['cart'];// this is an array (the shopping cart)
			$temp = $cart;
			for($j=0;$j<count($cart);$j++)
				{
					if($_POST['item$j'])
						{
							unset($temp[$j]);
						}
				}
			$cart = array();
			$cart = array_merge($temp);
			$_SESSION['cart'] = $cart;
			$domain = $_POST['domain'];
			break;

You can see the script in action here

You'll notice it is not removing the items in cart now. However before I managed to remove some Items but it was very sporadic and never removed items I selected in the cart. I've been stressing for more than 4 hours trying different ways to get it to remove specific items in cart.

Your help will be godsend! Thank you for your interest!

mtmosier

if(isset($_POST["item$j"]))

Use isset instead of just checking the value because you're using 0 as one of your values, which will equate to false. And use double quotes instead of single quotes because with single quotes $j won't be replaced by it's value.

Just for reference you don't have to use these temporary variables, or set them to array() before reassigning them. You could do this using just $_SESSION['cart'], or if you don't like to use the session array directly, with $cart.

laserlight

If you changed to use $_POST['item'] as an array, [man]array_diff/man might be useful.

Your existing code could be simplified and corrected to:

$size = count($_SESSION['cart']);
for ($i = 0; $i < $count; $i++)
{
	if (!isset($_POST["item$i"]))
	{
		unset($_SESSION['cart'][$i]);
	}
}
$domain = $_POST['domain'];

Trilogen

Thank you guys for your help!

All seems to be working fine now.

And yeh mtmosier, I did not realise that $_POST variables containing the value 0 would be false because I thought it was passing as string.