Coding Errors

[Matt_T]

Hi,

I'm new to coding and have two pages with errors. I can't seem to find out how to fix them. Here are the pages:

(CART.PHP)

<?php

include("db.php");

switch($_GET["action"])
{
case "add_item":
{
AddItem($_GET["id"], $_GET["qty"]);
ShowCart();
break;
}
case "update_item":
{
UpdateItem($_GET["id"], $_GET["qty"]);
ShowCart();
break;
}
case "remove_item":
{
RemoveItem($_GET["id"]);
ShowCart();
break;
}
default:
{
ShowCart();
}
}

function AddItem($itemId, $qty)

$result = mysql_query("select count(*) from cart where cookieId = '" . GetCartId() . "' and itemId = $itemId");

$row = mysql_fetch_row($result);
$numRows = $row[0];

if($numRows == 0)
{
// This item doesn't exist in the users cart,
// we will add it with an insert query

@mysql_query("insert into cart(cookieId, itemId, qty) values('" . GetCartId() . "', $itemId, $qty)");
}
else
{
// This item already exists in the users cart,
// we will update it instead

UpdateItem($itemId, $qty);
}

function UpdateItem($itemId, $qty)

mysql_query("update cart set qty = $qty where cookieId = '" . GetCartId() . "' and itemId = $itemId");

function RemoveItem($itemId) 
mysql_query("delete from cart where cookieId = '" . GetCartId() . "' and itemId = $itemId");

$result = mysql_query("select * from cart inner join items on cart.itemId = items.itemId where cart.cookieId = '" . GetCartId() . "' order by items.itemName asc");

while($row = mysql_fetch_array($result))
{
// Increment the total cost of all items
$totalCost += ($row["qty"] * $row["itemPrice"]);
?>
<tr>
<td width="15%" height="25">
<font face="verdana" size="1" color="black">
<select name="<?php echo $row["itemId"]; ?>" onChange="UpdateQty(this)">
<?php

for($i = 1; $i <= 20; $i++)
{
echo "<option ";
if($row["qty"] == $i)
{
echo " SELECTED ";
}
echo ">" . $i . "</option>";
}
?>
</select>
</font>
</td>
<td width="55%" height="25">
<font face="verdana" size="1" color="black">
<?php echo $row["itemName"]; ?>
</font>
</td>
<td width="20%" height="25">
<font face="verdana" size="1" color="black">
$<?php echo number_format($row["itemPrice"], 2, ".", ","); ?>
</font>
</td>
<td width="10%" height="25">
<font face="verdana" size="1" color="black">
<a href="cart.php?action=remove_item&id=<?php echo $row["itemId"]; ?>">Remove</a>
</font>
</td>
</tr>
<?php
}

// Increment the total cost of all items
$totalCost += ($row["qty"] * $row["itemPrice"]); 

$totalCost = $totalCost + ($row["qty"] * $row["itemPrice"]); 

<select name="<?php echo $row["itemId"]; ?>" onChange="UpdateQty(this)">
<?php
for($i = 1; $i <= 20; $i++)
{
echo "<option ";
if($row["qty"] == $i)
{
echo " SELECTED ";
}
echo ">" . $i . "</option>";
}
?>
</select>


<script language="JavaScript">

function UpdateQty(item)
{
itemId = item.name;
newQty = item.options[item.selectedIndex].text;

document.location.href = 'cart.php?action=update_item&id='+itemId+'&qty='+newQty;
}

</script> 


<tr>
<td width="100%" colspan="4">
<hr size="1" color="red" NOSHADE>
</td>
</tr>
<tr>
<td width="70%" colspan="2">
<font face="verdana" size="1" color="black">
<a href="products.php">&lt;&lt; Keep Shopping</a>
</font>
</td>
<td width="30%" colspan="2">
<font face="verdana" size="2" color="black">
<b>Total: $<?php echo number_format($totalCost, 2, ".", ","); ?></b>
</font>
</td>
</tr>

[hr]

PRODUCTS..PHP

<?php

// This page will list all of the items
// from the items table. Each item will have
// a link to add it to the cart

include("db.php");

// Get a connection to the database
$cxn = @ConnectToDb($dbServer, $dbUser, $dbPass, $dbName);
$result = mysql_query("select * from items order by itemName asc");
?>



<?php
while($row = mysql_fetch_array($result))
{
?>

<tr>
<td width="30%" height="25">
<font face="verdana" size="1" color="black">
<?php echo $row["itemName"]; ?>
</font>
</td>
<td width="10%" height="25">
<font face="verdana" size="1" color="black">

<?php echo $row["itemPrice"]; ?>
</font>
</td>
<td width="50%" height="25">
<font face="verdana" size="1" color="black">
<?php echo $row["itemDesc"]; ?>
</font>
</td>
<td width="10%" height="25">
<font face="verdana" size="1" color="black">
<a href="cart.php?action=add_item&id=<?php echo $row["itemId"]; ?>&qty=1">Add Item</a>
</font>
</td>
</tr>
<tr>
<td width="100%" colspan="4">
<hr size="1" color="red" NOSHADE>
</td>
</tr> 
<tr>
<td width="100%" colspan="4">
<font face="verdana" size="1" color="black">
<a href="cart.php">Your Shopping Cart &gt;&gt;</a>
</font>
</td>
</tr>
</table>
</body>
</html>

Help would greatly be appreciated.
Thanks! 🆒

[kburger]

Before we crawl through the code it would be helpful to know what the error messages are.

[Matt_T]

Sorry, I forgot those.

For CART.PHP it is:

Parse error: parse error, unexpected T_VARIABLE, expecting '{' in /home2/racingri/public_html/cart/cart.php on line 33

For PRODUCTS.PHP it is:

Parse error: parse error, unexpected $ in /home2/racingri/public_html/cart/products.php on line 58

Thanks. 🙂

[kburger]

You need to wrap your functions in { and }.

function AddItem($itemId, $qty)

should be

function AddItem($itemId, $qty)
{

and then of course end your function with }

In products.php you never closed your while loop with a }

[Matt_T]

Hi,

THANKS! 🆒

I know this will sound pretty stupid, but where do I end the "}" in both the files? I've tryed about 5 different places. 😕

Thanks again. 🙂

[kburger]

Here's a slightly more condensed version of your scripts, hopefully with the errors corrected. You're also not nesting your table rows in table tags. I'll leave that up to you.

cart.php

<?php

include("db.php");

switch($_GET["action"]) {
	case "add_item":
		AddItem($_GET["id"], $_GET["qty"]);
		break;
	case "update_item":
		UpdateItem($_GET["id"], $_GET["qty"]);
		break;
	case "remove_item":
		RemoveItem($_GET["id"]);
		break;
}
ShowCart();

function AddItem($itemId, $qty) {
	$result = mysql_query("select count(*) from cart where cookieId = '" . GetCartId() . "' and itemId = $itemId");

$row = mysql_fetch_row($result);
$numRows = $row[0];

if($numRows == 0) {
	// This item doesn't exist in the users cart,
	// we will add it with an insert query
	@mysql_query("insert into cart(cookieId, itemId, qty) values('" . GetCartId() . "', $itemId, $qty)");
}
else {
	// This item already exists in the users cart,
	// we will update it instead
	UpdateItem($itemId, $qty);
}
}

function UpdateItem($itemId, $qty) {
	mysql_query("update cart set qty = $qty where cookieId = '" . GetCartId() . "' and itemId = $itemId");
}

function RemoveItem($itemId) {
	mysql_query("delete from cart where cookieId = '" . GetCartId() . "' and itemId = $itemId");
}

$result = mysql_query("select * from cart inner join items on cart.itemId = items.itemId where cart.cookieId = '" . GetCartId() . "' order by items.itemName asc");

while($row = mysql_fetch_array($result)) {
	// Increment the total cost of all items
	$totalCost += ($row["qty"] * $row["itemPrice"]);
	?>
	<tr>
	<td width="15%" height="25">
	<font face="verdana" size="1" color="black">
	<select name="<?php echo $row["itemId"]; ?>" onChange="UpdateQty(this)">
	<?php

for($i = 1; $i <= 20; $i++) {
	echo "<option ";
	if($row["qty"] == $i){
		echo " SELECTED ";
	}
	echo ">" . $i . "</option>";
}
?>
</select>
</font>
</td>
<td width="55%" height="25">
<font face="verdana" size="1" color="black">
<?php echo $row["itemName"]; ?>
</font>
</td>
<td width="20%" height="25">
<font face="verdana" size="1" color="black">
$<?php echo number_format($row["itemPrice"], 2, ".", ","); ?>
</font>
</td>
<td width="10%" height="25">
<font face="verdana" size="1" color="black">
<a href="cart.php?action=remove_item&id=<?php echo $row["itemId"]; ?>">Remove</a>
</font>
</td>
</tr>
<?php
}

// Increment the total cost of all items
$totalCost += ($row["qty"] * $row["itemPrice"]); 

$totalCost = $totalCost + ($row["qty"] * $row["itemPrice"]); 
?>
<select name="<?php echo $row["itemId"]; ?>" onChange="UpdateQty(this)">
<?php
for($i = 1; $i <= 20; $i++) {
	echo "<option ";
	if($row["qty"] == $i) {
		echo " SELECTED ";
	}
	echo ">" . $i . "</option>";
}
?>
</select>


<script language="JavaScript">

function UpdateQty(item)
{
itemId = item.name;
newQty = item.options[item.selectedIndex].text;

document.location.href = 'cart.php?action=update_item&id='+itemId+'&qty='+newQty;
}

</script>


<tr>
<td width="100%" colspan="4">
<hr size="1" color="red" NOSHADE>
</td>
</tr>
<tr>
<td width="70%" colspan="2">
<font face="verdana" size="1" color="black">
<a href="products.php">&lt;&lt; Keep Shopping</a>
</font>
</td>
<td width="30%" colspan="2">
<font face="verdana" size="2" color="black">
<b>Total: $<?php echo number_format($totalCost, 2, ".", ","); ?></b>
</font>
</td>
</tr>
</body>
</html>

products.php

<?php

// This page will list all of the items
// from the items table. Each item will have
// a link to add it to the cart

include("db.php");

// Get a connection to the database
$cxn = @ConnectToDb($dbServer, $dbUser, $dbPass, $dbName);
$result = mysql_query("select * from items order by itemName asc");
?>
<html>
<body>
<table>

<?php
while($row = mysql_fetch_array($result)) {
?>

<tr>
<td width="30%" height="25">
<font face="verdana" size="1" color="black">
<?php echo $row["itemName"]; ?>
</font>
</td>
<td width="10%" height="25">
<font face="verdana" size="1" color="black">

<?php echo $row["itemPrice"]; ?>
</font>
</td>
<td width="50%" height="25">
<font face="verdana" size="1" color="black">
<?php echo $row["itemDesc"]; ?>
</font>
</td>
<td width="10%" height="25">
<font face="verdana" size="1" color="black">
<a href="cart.php?action=add_item&id=<?php echo $row["itemId"]; ?>&qty=1">Add Item</a>
</font>
</td>
</tr>
<?php 
}
?>
<tr>
<td width="100%" colspan="4">
<hr size="1" color="red" NOSHADE>
</td>
</tr>
<tr>
<td width="100%" colspan="4">
<font face="verdana" size="1" color="black">
<a href="cart.php">Your Shopping Cart &gt;&gt;</a>
</font>
</td>
</tr>
</table>

</body>
</html> 

[kburger]

Now that I look at the code a little more closely, I see some logic errors as well. These 2 lines do the same thing, so you're doubling the $totalCost.

$totalCost += ($row["qty"] * $row["itemPrice"]); 

$totalCost = $totalCost + ($row["qty"] * $row["itemPrice"]);  

[Weedpacket]

Originally posted by Matt T
I know this will sound pretty stupid, but where do I end the "}" in both the files? I've tryed about 5 different places. 😕

Um, you know your code best. Where should the function finish? Put the '}' there.

[Matt_T]

Hi,

Thanks for the codes! 🙂

I get this error for CART.PHP:

Fatal error: Call to undefined function: showcart() in /home2/racingri/public_html/cart/test/cart.php on line 16

This error for PRODUCTS.PHP:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home2/racingri/public_html/cart/test/products.php on line 18

But it does have a link working on the page to view the Cart.

Thanks again, this site is awesome! 🆒

[kburger]

The first error is telling you that you haven't defined the function showcart() anywhere, at least not in the code you posted. If it's in another file make sure you include that file with an include() statement.

For the second error, put a die() statement for your query, like this:

$result = mysql_query("select * from items order by itemName asc") or die("Error: " . mysql_error());

That will show you what the real error is. Looks like it's an error with your query.