Simple MYSQL Query

Sayian

hello .. i made a mysql query to check the database to see if the person rating an image has given a rating of 1 , 3 times or more to stop people from diliberatly messing peoples ratings up , but it us returning me an error? .. Is this not right?

   $result = mysql_query("SELECT id FROM $tb_ratings WHERE rater_id = '".$_POST['rater_id']."' AND rating = 1") or die(mysql_error());
       if(mysql_num_rows($result)){
	$rs = mysql_fetch_array($result);
	if($rs > 3){
	header("Location: acct_profile.php?acctid=" . $_POST['user_id'] ."&rate=NA");
	exit;
}

jonathan89

What was the error message?

Sayian

unexpected $ in /home/publichtml on line 201 , the last line .. the line that the php end tag was on , but the end tag is correct , i dont get it.

Sayian

Ok i found the problem .. i forgot to use a closing curly bracket.
Fixed ... but now thiers another problem .. even if someone has only given 2 1 rating's its still sending them to the header. It's supposed to be 3 rating's or more , but it's not working correctly. it sends them after thier first rating of 1.

Sayian

This is what i have now .. and its still not working .. it's not verifying that thier's 5 rating;'s of 1 before it forwards to the header.

		     $result = mysql_query("SELECT * FROM $tb_ratings WHERE rater_id = '".$_POST['rater_id']."' AND rating = 1") or die(mysql_error());
       if(mysql_num_rows($result)){
	$rs = mysql_fetch_array($result);
	if($rs >= "5"){
	header("Location: acct_profile.php?acctid=" . $_POST['user_id'] ."&rate=NA");
	exit;
}
}

Weedpacket

 $rs = mysql_fetch_array($result);
    if($rs >= "5"){

As the name implies, mysql_fetch_array returns an array, not an integer or a string.

Sayian

It would of been helpfull if you could of told me what command mysql use's to fetch a string or a number .. but thanks.

linus

mysql_num_rows() is the function you want, it'll tell you how many rows were returned. Your code can be as simple as this:


$result = mysql_query(...etc...);
if (mysql_num_rows($result) => 5) {
  // mischief is afoot
}

Mysql_fetch_array is used to retrieve the values of the fields, not the number of rows. It's always good PHP practise to use var_dump() on things to teach you about their structures (like the return value of the fetch_array function), and it's always good MySQL practise to take whatever query you're using and paste it into the mysql console or into PhpMyAdmin so you can see exactly what gets returned and how.

[As an aside, you could use fetch_array to find out how many rows were returned by doing the following:

$result = mysql_query(etc);
$rows = mysql_fetch_array($result);
if (count($rows) => 5) { // count the number of elements in the array
  // bounced!
}

... but obviously that's a pretty roundabout way to do it.]