Help with uploading and displaying files

twistedfrog

Hi guys,

I am trying to upload a picture through an HTML form, display it to the user and then put either it, or the path to it into a database. The form seems to be working, and the photo's name is formPhoto. Here is my php code:

<?php
if ( isset($_FILES['formPhoto']) )
{
$path_parts = pathinfo(postAd3.php);
#$dir = $path_parts['dirname'] . "\img";

                                        $dir = ".\\websites\\fyiguide\\img";

                                        $uniq = uniqid("");
                                        $file_ext = $_FILES['type'];
                                        $filename = $dir . "\\" . $uniq . "." . $file_ext;

                                        if(move_uploaded_file($_FILES['tmp_name'], $filename))
                                        {
                                          echo("file uploaded");
                                        }
                                        else
                                        {
                                          echo("messed up on" . $filename . "    file extention is $file_ext");
                                        }

                                        echo("<p>trying this: -- </p>");
                                    }
                                    else
                                    {
                                      echo("No file was selected");
                                      exit();
                                    }
                                ?>

This script fails when I use the Move_Uploaded_file function ... can anyone point me in the right direction? I want the files deposited in the img folder on my webserver, which for me is websites/fyiguide/img where /fyiguide is where all my web files are located. I'm not running the server, so I have limited information, but at the ssh prompt when I type cd ./ I get to /www outside of the websites directory.

Is there any more info I need to post? Thanks in advance guys - this is driving me crazy.

Matt

twistedfrog

I also forgot that /img is set to global read, write, and execute. I am not too happy about the security implications, but I wasn't sure how else to ensure my permissions were correct. They are just images anyway I guess.

kburger

You seem to be saying that you're on a *nix server, but those look like Windows filesystem paths.

$dir = ".\websites\fyiguide\img";

twistedfrog

This is very true .... what would the *nix path look like? just ./website/fyiguide/img ??

Thanks for pointing that out.

kburger

Something like that, but you should use the absolute path.

$_SERVER['DOCUMENT_ROOT'] should help you with that if you don't know what the absolute path is.

twistedfrog

I changed the code to read the following, but it still won't work. I am also unable to get the proper extension type. It has worked before though .... anyone have ideas on that? Thanks alot guys - I really appriciate it.

if ( isset($_FILES['formPhoto']) )
{
$path_parts = pathinfo(postAd3.php);
#$dir = $path_parts['dirname'] . "\img";

                                        $dir = "./websites/fyiguide/img";

                                        $uniq = uniqid("");
                                        $file_ext = $_FILES['type'];
                                        $filename = $dir . "/" . $uniq . "." . $file_ext;

                                        if(move_uploaded_file($_FILES['tmp_name'], $filename))
                                        {
                                          echo("file uploaded");
                                        }
                                        else
                                        {
                                          echo("messed up on" . $filename . "    file extention is $file_ext");
                                        }

                                        echo("<p>trying this: -- </p>");
                                    }
                                    else
                                    {
                                      echo("No file was selected");
                                      exit();
                                    }

kburger

Again, I'd suggest using the absolute path.

I also wouldn't be using $_FILES['type'] to use as the extension. You'll get something like "image/gif". That's not going to work as an extension. You should probably use whatever the uploaded file had on it. But if you know these are going to be images, I'd suggest using getimagesize(). Look at the documentation for the 3rd element returned by that function.

I'd also suggest looking at the documentation on this page for handling file uploads.

if (move_uploaded_file($_FILES['userfile']['tmp_name'], $filename)

(note: not sure why this forum is putting a break in the array above)

twistedfrog

Thanks for the help guys - with some tinkering I got it. I owe you one.

Matt

kburger

OK. You can send one to...

Just kidding. Glad to help. Be sure to mark this thread [resolved].