[Resolved] whats wrong with my function?

TimTimTimma

OK, earlier today I decided my user_theme system wasn't powerful enough, so I rewrote it, everything is fine, the system works, with 1 problem...NONE OF THE CONTENT IS BEING DISPLAYED!

here is the outline of how the function works

class user
{
function theme($tpl_file = ""){
if(!empty()){
return include($Current_Directory."/Templates/".$themename."/".$tpl_file);
}else{
returns just the name of the theme being used
}
}
}

like i said it works, the templates are being return but none of the content is, here is an example

$article_title = "title";
$article_content = "content";
$user->theme("news.tpl");

the above example would return the templates, but no content. I understand that in most functions you need to also include the variables you are going to be using within the function but, I figured since it was merely returning the include() function I didn't need to do that, and if I MUST have the fields for the content to be included is there away around this?

bpat1434

And where do you put the content into the template? From what I see, you don't even initiate the class. I think your code should probably look more like:

$article_title = "title";
$article_content = "content";

$user =& new user;
$tpl = $user->theme("news.tpl");
// Run through a tpl parse script here.

TimTimTimma

I intiiate the class, the thing is the class is rather big...and I figured it would be kinda messed up to post the entire thing here, you can check out all the code at http://timtimtimma.com/backend_source.php that has the user class with the theme() function

bpat1434

Well here's the function:

    function theme($tpl_file = "")
301 	    {
302 	        global $Current_Directory;
303 	        if(!isset($_SESSION['user_theme'])){
304 	            $_SESSION['user_theme'] = $this->extract('user_theme');
305 	        }
306 	        $theme = $Current_Directory."/Templates/".$_SESSION['user_theme']."/".$tpl_file;         

307 	        if(!empty($tpl_file)){
308 	            if(file_exists($theme)){
309 	                $inc_file = file($theme);
310 	                $inc_file = implode("", $inc_file);
311 	                $inc_file = addslashes($inc_file);
312 	                $inc_file = "\$r_file = \"".$inc_file."\";";
313 	                eval($inc_file);
314 	                echo $r_file;
315 	            }else{
316 	                die("<b>CRITICAL ERROR!</b> The current theme set has missing components! Contact the admin about this error!");
317 	            }
318 	        }else{
319 	            return $_SESSION['user_theme'];
320 	        }        

321 	    }

Now, this takes the file and evaluates the code in it to do what you want to output, but there is no specification of where the tags (if any) are replaced and what they're replaced with.

~Brett

TimTimTimma

thats the thing if you scroll to the bottom the constants are defined, that I wish to use, and if not the constants the variables. My problem is that I figured that constants were global, now it appears as they are not.

And the reason you don't see source for replacement, is because that function, in diffrent areas needs diffrent variables, and a different amount of them. I figured of just adding a few optional fields, but then I would have to open each template file and change the constants to variables, then put the function where I needed it, then add the fields I wanted to include, but that just seems like to much work, and what if i come across an area where I need alot more variables for some reason?

bpat1434

Well, first off: I dislike PHPublisher. I used it once in a trial, hated it. So my first thing would be to tell you to get away from it, and just learn PHP on your own and write your own Template Parsing Class/Script and use that. It's much more customizable, and easier to understand. Right now, it doesn't seem like you have the "freedom" you want with the templates, and design.

But yes, if you are going to add "fields" you will have to add them to the specific templates.

~Brett

TimTimTimma

what are you talking about you have used it before?????

This is a Content Management System I am building :-S how could you have even gotten to it when it not even availkable for download yet?

What is this other PHPublisher you speak of? God forbid a software or something thats using the name >.<

P.S. I fixed my theme function.

I added another optional field, then put an array as the field, and put in values equaling the variables I wanted to use and just slapped the arrays into the templates and POOF! it works now! 😃 and for some reason it seems faster.... use to generate pages at .045 but now generates them at .015-.025