Arrays

[cazamic]

I have this order form and I am wondering if I could make it any better. It works ok except it has no rea error handeling. What I want to change is that when I recieve an order in my mail, it shows every variable listed in my message. The items the person didn't order show up on my email as not selected. How can I just get it to list what was ordered.

Can anyone help? Also surely there is a neater way to do this, .. the weblink for the working form is

http://www.ralphjandrell.co.uk/order.html

Here is the code that captures the users input...

<?php

$title=$POST['title'];
$firstname=$POST['firstname'];
$surname=$POST['surname'];
$address=$POST['address'];
$email=$POST['email'];
$phone=$POST['phone'];
$postcode=$POST['postcode'];
$comments=$POST['comments'];

$details1[1] = 'None selected';
$details1[2] = 'Terracotta Rim Dish - Green Foliage Design';
$details1[3] = 'Terracotta Rim Dish - Blue Foliage Design';
$details1[4] = 'Terracotta Rim Dish - Terracotta Oakleaf Design';
$details1[5] = 'Terracotta Rim Dish - Oakleaf Design';
$details2[6] = 'None selected';
$details2[7] = '12cm - £12.00';
$details2[8] = '14cm - £18.00';
$details2[9] = '18cm - £25.00';
$details2[10] = '26cm - £42.00';
$details2[11] = '33cm - £68.00';
$details2[12] = '39cm - £95.00';
$details2[13] = '46cm - £180.00';
$details3[14] = 'None selected';
$details3[15] = 'Amount = 1';
$details3[16] = 'Amount = 2';
$details3[17] = 'Amount = 3';
$details3[18] = 'Amount = 4';
$details3[19] = 'Amount = 5+';

$details4[1] = 'None selected';
$details4[2] = 'Bowl - Green Foliage Design';
$details4[3] = 'Bowl - Blue Foliage Design';
$details4[4] = 'Bowl - Terracotta Oakleaf Design';
$details4[5] = 'Bowl - Oakleaf Design';
$details5[6] = 'None selected';
$details5[7] = '21cm - £30.00';
$details5[8] = '26cm - £45.00';
$details5[9] = '32cm - £80.00';
$details6[10] = 'None selected';
$details6[11] = 'Amount = 1';
$details6[12] = 'Amount = 2';
$details6[13] = 'Amount = 3';
$details6[14] = 'Amount = 4';
$details6[15] = 'Amount = 5 +';

$details7[1] = 'None selected';
$details7[2]= 'Lampstand - Green Foliage Design';
$details7[3] = 'Lampstand - Blue Foliage Design';
$details7[4] = 'Lampstand - Terracotta Oakleaf Design';
$details7[5] = 'Lampstand - Oakleaf Design';
$details8[6] = 'None selected';
$details8[7] = '16cm (Round Shape) - £45.00';
$details8[8] = '29cm (Classic Shape) - £80.00';
$details8[9] = '32cm (Classic Shape) - £120.00';
$details9[10] = 'None selected';
$details9[11] = 'Amount = 1';
$details9[12] = 'Amount = 2';
$details9[13] = 'Amount = 3';
$details9[14] = 'Amount = 4';
$details9[15] = 'Amount = 5 +';

$details10[1] = 'None selected';
$details10[2] = 'Vase - Green Foliage Design';
$details10[3] = 'Vase - Blue Foliage Design';
$details10[4] = 'Vase - Terracotta Oakleaf Design';
$details10[5] = 'Vase - Oakleaf Design';
$details11[6] = 'None selected';
$details11[7] = '12cm - 18.00';
$details11[8] = '18cm - £30.00';
$details11[9] = '22cm - £45.00';
$details11[10] = '28cm - £70.00';
$details12[11] = 'None selected';
$details12[12] = 'Amount = 1';
$details12[13] = 'Amount = 2';
$details12[14] = 'Amount = 3';
$details12[15] = 'Amount = 4';
$details12[16] = 'Amount = 5 +';

$to="[e-mail]";
$message="From: $title $firstname $surname\n\nAddress:\n\n$address$postcode\n\nPhone: $phone\n\nEmail: $email\n\nQuestions or comments: $comments\n\n\nOrder Details:\n\n$details1[$item1]\n\n$details2[$item2]\n\n$details3[$item3]\n\n\n$details4[$item4]\n\n$details5[$item5]\n\n$details6[$item6]\n\n\n$details7[$item7]\n\n$details8[$item8]\n\n$details9[$item9]\n\n\n$details10[$item10]\n\n$details11[$item11]\n\n$details12[$item12]";

if(mail($to,"Order",$message,"From: $email\n" )) {
echo "<center>Thank you for your order $title $firstname $surname. <br><br>";

} else {
echo "There was a problem sending the mail. Please go back and check that you filled in the form correctly.";
}
?>

[kburger]

If the form is being "POST"ed, just iterate through the $_POST array and echo those that have a value.

After looking at your form, I'd suggest changing it a little:

<SELECT name="item5"> 
<option value=6>Select a Size
<option value=7>21cm - £30.00
<option value=8>26cm - £45.00
<option value=9>32cm - £80.00</option>
</select>

to something like

<SELECT name="item5"> 
<option value="">Select a Size</option>
<option value="21cm - £30.00">21cm - £30.00</option>
<option value="26cm - £45.00">26cm - £45.00</option>
<option value="32cm - £80.00">32cm - £80.00</option>
</select>

[cazamic]

ok, can you elaborate? Can you show me some code that does this? I hadn't realised I had missed those closing option tags so cheers....Also if someone accidently submitted an empty form how could I stop recieving blank orders, like an error message..

[kburger]

Actually, those closing </option> tags aren't really a problem. You can probably get a way with omitting them.

The basic idea I was getting at is this.

foreach ($_POST as $key => $value) {
	if (!empty($value)) $message .= "$key: $value\n";
}

This is all assuming you use relevant information in the form for the option values like I have in my previous post. While you're at it, you might want to use informative select names also. So instead of "item1" it might be something like "Terracotta Rim Dish Design".

If you want some simple form validation you can do something like this, for example, to check to see if someone entered their first name.

if (empty($_POST['firstname'])) {
    // do something - don't send the email - display an error message, etc.
}

By the way, I love that pottery. If my wife saw it I think she'd have us schedule our next vacation for the UK.