What is wrong with this

NZ_Kiwis

<?php
if ($title = "") {
$problem = "Header can not be left blank";
exit();
} else {
?>

This goes on and does ther "else" stuff and does not exit the code when I leave the title box blank...

This is my HTML

<form method="POST" action="adding.php?main_id=<?php echo $row2["main_id"];?>">
<font size="2" face="Verdana"><font size="2" face="Verdana">This post is being added in the <?php echo $row2["topic_name"]; ?>
	</font>
	<p>
	<font face="Verdana">
<input type="text" name="title" size="94" style="border-style: solid; border-width: 1px" size="30"></font></p>
	<p>
	<font face="Verdana">
	<textarea rows="18" name="body" cols="81" style="border-style: solid; border-width: 1px"></textarea></font></p>
	<p>
	<font face="Verdana">
<input type="hidden" name="redirect" value="<? echo $ref; ?>"> 
<input type="hidden" value="6" name="timezone[]" checked>
<input type="submit" value="Submit" name="B1" style="border-style: solid; border-width: 1px"></font></p>

<input type="hidden" name="redirect" value="<?php echo $ref; ?>">
</form>

kburger

You're using the assignment operator '=' rather than the comparison operator '=='.

And really, you should use if (empty($title))

NZ_Kiwis

Originally posted by kburger
You're using the assignment operator '=' rather than the comparison operator '=='.

And really, you should use if (empty($title))

sweet as I want to add this to my page now

<?php
if ($title == "") {
$problem = "Header can not be left blank";
Header("Location: $ref2");
exit();
} else {

but I get this error

Warning: Cannot modify header information - headers already sent by (output started at /home/httpd/vhosts/rugbyleaguenz.com/httpdocs/members/forum/adding.php:19) in /home/httpd/vhosts/rugbyleaguenz.com/httpdocs/members/forum/adding.php on line 36

how dso fix this

kburger

If you're going to use the header() function it HAS to be done before ANY output is sent, including whitespace, <html> tags, whatever. Since you haven't posted your whole script I can't tell you exactly what you've done wrong, other than sending stuff to the browser before trying to send headers.

Also, it doesn't make any sense to assign a string to a variable and then go off to another page where that variable will not be 'visible'. Your $problem assignment is useless.