Simple Query Change

[Sayian]

I am very confused about the complexity of this query , and i need to remove the MD5 pass encryption.

 
$query = "INSERT INTO $tb_albums (user_id, title".(($_POST['password']) ? ", password" : '').") VALUES ('".$_SESSION['userid']."','".$_POST['title']."'".(($_POST['password']) ? ",'".md5($_POST['password'])."'" : '').")";

thiers so many brackets when i try ti remove the md5 all i get is errors.

[bradgrafelman]

That is one garbled, confusing mess of PHP. Separate it out:

if(!empty($_POST['password']) {
    $column_ending = ', password';
    $password_ending = ", '" . $_POST['password'] . "'";
} else {
    $column_ending = '';
    $password_ending = '';
}

$query = "INSERT INTO $tb_albums (user_id, title" . $column_ending . ") VALULES ('" . $_SESSION['userid'] . "', '" . $_POST['title'] . "'" . $password_ending . ")";

That looks a bit better to me. I also removed the MD5() encryption for you.

[Sayian]

You know , my problem might not be with this page. it might be with my album_login.php page ... b/c i was thinking maybe the md5 encrp. was causing the problem when ppl inserted albums , but the problem is when they try to login. The albums have password protection ( optional ) , but when ppl try to log into their albums , it doesnt work. let me show you the code for the album login

<?php
$random = rand(1, 100000001);
include("./admin/config.php");
include("$include_path/common.php");
include("$include_path/$table_file");
include("$include_path/doc_head.php");
include("$include_path/styles.php");

global $HTTP_POST_VARS,$HTTP_GET_VARS,$HTTP_SESSION_VARS;

global $_SESSION;

if ($HTTP_POST_VARS!="")
    $_POST=$HTTP_POST_VARS;

if ($HTTP_GET_VARS!="")
    $_GET=$HTTP_GET_VARS;

if ($HTTP_SESSION_VARS!="")
    $_SESSION=$HTTP_SESSION_VARS;

check_user_login();

$return_message = "";

if(isset($_POST['login'])){

  if ($_POST['PW'] == '$$$99$$$')
  {
        $_SESSION['album_'.$_POST['album_id']] = 1;
        session_register('album_'.$_POST[album_id]);

    $r = urldecode($_GET['r']);
    if (!$r) { $r=urldecode($_POST['r']); }
    $url = $base_url . "/" . $r;

  // echo " url ".$url."a";

  header("Location: $url");
  exit();
  }
  else
  {
    $sql = "select id, password from $tb_albums where id = '".$_POST['album_id']."' and password = '".md5($_POST['PW'])."'";

$query = mysql_query($sql) or die(mysql_error());
if(mysql_num_rows($query)){

    $_SESSION['album_'.$_POST['album_id']] = 1;
    session_register('album_'.$_POST[album_id]);

    $r = urldecode($_GET['r']);
    if (!$r) { $r=urldecode($_POST['r']); }
    $url = $base_url . "/" . $r;

  // echo " url ".$url."a";

  header("Location: $url");
  exit();

} else {
  $return_message = "Invalid Album Password <br><br>";
}
  }
}


$r = urlencode($_GET['r']);

if($lf==1) 
   $return_message="Invalid Album Password ";

$tpl->assign(array('RETURN_MESSAGE' => $return_message));
$tpl->assign(array('REDIRECT_URL' => $r));
$tpl->assign(array('ALBUM_ID' => $a));

$tpl->parse('FORM', 'albums_login');
$login = $tpl->fetch('FORM');


$final_output = table("", $login);


$tpl->assign(array('CONTENT_TEXT' => $final_output));
$tpl->parse('PAGE', 'main');
$final_output = $tpl->fetch('PAGE');



$final_output = final_output($final_output);

//echo $final_output;
include ("copy.php");
?>

Now ... when i use the master pass i setup $$$99$$$ i can access any album for any user ... but user's cant access their own albums , and i cant access user's albums with the password's they give me to test ... it seems as tho the master password is the only password working , Even if i create a fresh album , with the password test , if you type test in for the album login , it comes back Invalid password

How can i fix this?

[bradgrafelman]

if($lf==1)  

   $return_message="Invalid Album Password "; 

Where's $lf being set?

and password = '".md5($_POST['PW'])."'";

Are the passwords MD5 encrypted in the database?

[Sayian]

Yes , the passwords are store MD5 Encypted in the database. I thought i needed to take off the encrytpion thinking that was the problem but it wasnt , the problem is with the login , for some reason the login just doesnt work.

I dont see where the IF statement is being called. I think i wrote this login script all wrong , i guess i just need someone to help me find why its not working and help so i can fix it. I dont think i did a very good job on this login script.

[Weedpacket]

On a side note, the two lines conflict:

$_SESSION['album_'.$_POST['album_id']] = 1;
        session_register('album_'.$_POST[album_id]);

Use either one of those or the other; preferably the first.

How are you inserting users' records into the database in the first place? How do records get put into $tb_albums? I'm pretty sure the code you originally posted wouldn't work

".....(user_id, title".(($POST['password']) ? ", password" : '').")....."
becuase that would try and put the users password into a table column named the same as the user's password. If the user had a password "wibble", it would try and put "50eccc6e2b0d307d5e8a40fb296f6171" in a column named "wibble", and it's a pretty good guess that the table wouldn't have one.
I think instead of

$query = "INSERT INTO $tb_albums (user_id, title".(($_POST['password']) ? ",
password" : '').") VALUES
('".$_SESSION['userid']."','".$_POST['title']."'".(($_POST['password']) ?
",'".md5($_POST['password'])."'" : '').")";

you just want

$password = isset($_POST['password']) ? md5($_POST['password']) : "";
$title = mysql_real_escape_string($_POST['title']);
$query = "INSERT INTO $tb_albums (user_id, title, password) VALUES
('".$_SESSION['userid']."','".$title."'".$password."')";

[Sayian]

When attempting to use the query you gave me it shot me to a blank screen. So that you can see the full code , here it is.
This is the code for the page that creates the albums , not the album login.

<?php
  include("./admin/config.php");
  include("$include_path/common.php");


  global $HTTP_POST_VARS,$HTTP_GET_VARS,$HTTP_SESSION_VARS;

  global $_SESSION;

  if ($HTTP_POST_VARS!="")
      $_POST=$HTTP_POST_VARS;

  if ($HTTP_GET_VARS!="")
      $_GET=$HTTP_GET_VARS;

  if ($HTTP_SESSION_VARS!="")
      $_SESSION=$HTTP_SESSION_VARS;

  check_user_login();

  if ($_POST)
  {
    if (!$_POST['title'])
    {
        header("Location: albums.php?e=1&m=You must enter a title for your album.");
    }
    else
    {
     $query = "INSERT INTO $tb_albums (user_id, title".(($_POST['password']) ? ",
password" : '').") VALUES
('".$_SESSION['userid']."','".$_POST['title']."'".(($_POST['password']) ?
",'".md5($_POST['password'])."'" : '').")";
      if (@mysql_query($query))
      {
        header("Location: albums.php");
      }
    }
  }
  else
  {
    include("$include_path/$table_file");
    include("$include_path/doc_head.php");
    include("$include_path/styles.php");
    include("$include_path/custom.php");

if ($_GET['e'] == 1 && $_GET['m'] != '')
{
  echo "<script language='javascript'>alert('".$_GET['m']."');</script>";      
}

// Call the albums
$tpl->define_dynamic('album_list', 'albums_content');
$album_results = mysql_query("SELECT * FROM $tb_albums WHERE user_id='".$_SESSION['userid']."'");

while ($a_row = mysql_fetch_array($album_results))
{
  (($a_row['password'] != '') ? $a_title = $a_row['title'].' [P]' : $a_title = $a_row['title']);
  $tpl->assign(array(
    'ALBUM_TITLE' => $a_title,
    'ID' => $a_row['id']
  ));
  $tpl->parse(ROWS,'.album_list');
}

$tpl->parse('CONTENT', 'albums_content');
$content = $tpl->fetch('CONTENT');
$final_output = table("Albums Management", $content);
$tpl->assign(array('CONTENT_TEXT' => $final_output));
$tpl->parse('PAGE', 'main');
$final_output = $tpl->fetch('PAGE');
$final_output = final_output($final_output);
include ("copy.php");
  }

?>

[Weedpacket]

You're still trying to put information into a column with the same name as the user's password, and I'm still sure that's wrong.

I wonder what error message you'd get if you left the '@' out of

if (@mysql_query($query))
      {
        header("Location: albums.php");
      }

and added an else clause

else
{
 echo 'The query "'.$query.'" failed, with MySQL returning '.mysql_error();
die;
}

What is the point of these lines?

global  $HTTP_POST_VARS,$HTTP_GET_VARS,$HTTP_SESSION_VARS;


global $_SESSION;

if ($HTTP_POST_VARS!="")
    $_POST=$HTTP_POST_VARS;

if ($HTTP_GET_VARS!="")
    $_GET=$HTTP_GET_VARS;

if ($HTTP_SESSION_VARS!="")
    $_SESSION=$HTTP_SESSION_VARS; 

For a start, it's meaningless to declare variables as global when they're already in the global scope. Second, why do you override existing superglobals with the values of other globals that would (unless they've been turned off) contain the same information anyway? If it's a PHP version matter, you should wrap this in a function that checks the PHP version ([man]phpversion[/man] will do that); you will only need to do this is the version is older than 4.1. And if you're going to be doing that all the time, you might as well put it in an include file.

Also, why do you check the values of those variables by comparing them to an empty string, instead of using [man]empty[/man] or [man]isset[/man] (as you do in one place further down). The same question could be asked for if($POST), if(!$POST['title']), the two $GET variables, and you never do check to see that $POST['user_id'] or $_POST['password'] exists before using them.

[Sayian]

ive gone into the database ... pulled up the 2 albums for which i created the name's Test and Test2. Looked up the MD5 pass for test which is 098f6bcd4621d373cade4e832627b4f6

When i looked to see what password is in the tables , the password for test was correctly placed into the password table.

Ive tried this with more then just Test , many albums , everything is being inserted correctly.

I guess now my problem doesnt lie with the album creation page , it must lie within the album login page.

Any help on this would be great
And weekpacket , thanks for your 411 about the superglobals , i will look into this.