Problem with EVAL

cpuworks

I have a function that returns a string like this: 'array("fname"=>"mark","lname"=>"wilson"'

I want to EVAL this code, setting a var
to that array. If I set that text into
a string,and EVAL it, I get no result.
(Code below, and attached)
But if I just enter it all as a line of code,
it works, so the code is correct, but
my implementation of the EVAL is wrong.
Any ideas?

<?php
echo "<hr>variable method (doesn't work): \n";
$cmd = 'array("fname"=>"mark","lname"=>"wilson")';
echo "CMD=$cmd \n";
$user =eval("$cmd;");
echo "USER: \n";
print_r($user);
echo "<hr>\n";
// this works
$user=array("fname"=>"mark","lname"=>"wilson");
echo "<hr>hard-coded method (works): \n";
echo "USER: \n";
print_r($user);
echo "<hr>\n";
?>

bradgrafelman

First of all, fix your eval() structure by actually having eval() output the array...

$cmd = 'return array("fname"=>"mark","lname"=>"wilson")';

Second of all, why in the heck are you using eval() just to set a variable's contents?!?!?!

$cmd = array("fname"=>"mark","lname"=>"wilson");

Boom. Hastle free, easy to read, etc. etc.

EDIT: Also, 2 things...
1. If you're posting PHP code, please use the board's

 tags, so that we can read it easily.
  2. If you're posting PHP code... uhm... don't attach it? That's just redudantly redudant.

cpuworks

1) Thanks for the solution! That works!

2) Why am I doing this? I'm trying to make a SELECT list which can set more than one value. The string which ends up as $cmd is the VALUE for the selected option. I have a routine which walks the $_REQUEST array and, if it finds a SELECT object with the right name, executes the string value, thereby setting multiple values in the REQUEST array.
(To see result, go to http://webtut.com/test.php )

I guess I could've provided all that context, but it didn't seem necessary. As far as attaching AND including the code, my browser was messing up and wouldn't let me paste the code in, so I had to attach it. Then, once I restarted the browser and edited the note, I forgot to remove the now-redundant attachment. My bad!

bradgrafelman

Don't forget to MARK THIS THREAD RESOLVED using the link at the bottom of the page if you did indeed find a solution to your issue.

cpuworks

D'oh! Done. Thanks!