[RESOLVED] switch

origin

i'm trying to figure out how to use this switch business.

http://www.melliart.com/br_index.php

there is a list nav on the left that switches the image thumbnails. each thumbnail links to a full size image that appears to the right of the thumbnails.

my problem:
when i click the link for the second set of thumbs they appear like they should but... when i click one of the thumbs the correct full size version appears but the 2nd set of thumbs changes back to the 1st set of thumbs...

nav code:
<p>pages</p>
<ul id="NAVdots">
<li><a href="cssindex.php?id=art_01" title="Fine Art Page 1">1</a></li>
<li><a href="cssindex.php?id=art_02" title="Fine Art Page 2">2</a></li>
<li><a href="cssindex.php?id=art_03" title="Fine Art Page 3">3</a></li>
<li><a href="cssindex.php?id=art_04" title="Fine Art Page 4">4</a></li>
<li><a href="cssindex.php?id=art_05" title="Fine Art Page 5">5</a></li>
</ul>

thumbnail set 1 include:

thumbnail set 2 include:

<div class="thumbnail"> <a href="cssindex.php?id=057" title="57"><img src="images/portfolio/tn/art/tn_057.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=056" title="56"><img src="images/portfolio/tn/art/tn_056.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=055" title="55"><img src="images/portfolio/tn/art/tn_055.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=054" title="54"><img src="images/portfolio/tn/art/tn_054.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=053" title="53"><img src="images/portfolio/tn/art/tn_053.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=052" title="52"><img src="images/portfolio/tn/art/tn_052.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=051" title="51"><img src="images/portfolio/tn/art/tn_051.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=050" title="50"><img src="images/portfolio/tn/art/tn_050.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=049" title="49"><img src="images/portfolio/tn/art/tn_049.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=048" title="48"><img src="images/portfolio/tn/art/tn_048.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=068" title="47"><img src="images/portfolio/tn/art/tn_047.jpg" alt="" width="66" height="66" border="0"></a></div>
<div class="thumbnail"> <a href="cssindex.php?id=068" title="46"><img src="images/portfolio/tn/art/tn_046.jpg" alt="" width="66" height="66" border="0"></a></div>

full size image include:

<?php switch($id)
{
case "069":
 include "gallery/art/069.php";
 break;
case "068":
 include "gallery/art/068.php";
 break;
case "067":
 include "gallery/art/067.php";
 break;
case "066":
 include "gallery/art/066.php";
 break;
case "065":
 include "gallery/art/065.php";
 break;
case "064":
 include "gallery/art/064.php";
 break;
case "063":
 include "gallery/art/063.php";
 break;
case "062":
 include "gallery/art/062.php";
 break;
case "061":
 include "gallery/art/061.php";
 break;
case "060":
 include "gallery/art/060.php";
 break;
case "059":
 include "gallery/art/059.php";
 break;
case "059":
 include "gallery/art/059.php";
 break;
case "058":
 include "gallery/art/058.php";
 break;
case "057":
 include "gallery/art/057.php";
 break;
case "056":
 include "gallery/art/056.php";
 break;
case "055":
 include "gallery/art/055.php";
 break;
case "054":
 include "gallery/art/054.php";
 break;
case "053":
 include "gallery/art/053.php";
 break;
case "052":
 include "gallery/art/052.php";
 break;
case "051":
 include "gallery/art/051.php";
 break;
case "050":
 include "gallery/art/050.php";
 break;
case "049":
 include "gallery/art/049.php";
 break;
case "048":
 include "gallery/art/048.php";
 break;
case "047":
 include "gallery/art/047.php";
 break;
case "046":
 include "gallery/art/046.php";
 break;
case "045":
 include "gallery/art/045.php";
 break;
case "044":
 include "gallery/art/044.php";
 break;
case "043":
 include "gallery/art/043.php";
 break;
case "042":
 include "gallery/art/042.php";
 break;
case "041":
 include "gallery/art/041.php";
 break;
case "040":
 include "gallery/art/040.php";
 break;
case "039":
 include "gallery/art/039.php";
 break;
case "038":
 include "gallery/art/038.php";
 break;
case "037":
 include "gallery/art/037.php";
 break;
case "036":
 include "gallery/art/036.php";
 break;
case "035":
 include "gallery/art/035.php";
 break;
case "034":
 include "gallery/art/034.php";
 break;
case "033":
 include "gallery/art/033.php";
 break;
case "032":
 include "gallery/art/032.php";
 break;
case "031":
 include "gallery/art/031.php";
 break;
case "030":
 include "gallery/art/030.php";
 break;
case "029":
 include "gallery/art/029.php";
 break;
case "028":
 include "gallery/art/028.php";
 break;
case "027":
 include "gallery/art/027.php";
 break;
case "026":
 include "gallery/art/026.php";
 break;
case "025":
 include "gallery/art/025.php";
 break;
case "024":
 include "gallery/art/024.php";
 break;
case "023":
 include "gallery/art/023.php";
 break;
case "022":
 include "gallery/art/022.php";
 break;
case "021":
 include "gallery/art/021.php";
 break;
case "020":
 include "gallery/art/020.php";
 break;
case "019":
 include "gallery/art/019.php";
 break;
case "018":
 include "gallery/art/018.php";
 break;
case "017":
 include "gallery/art/017.php";
 break;
case "016":
 include "gallery/art/016.php";
 break;
case "015":
 include "gallery/art/015.php";
 break;
case "014":
 include "gallery/art/014.php";
 break;
case "013":
 include "gallery/art/013.php";
 break;
case "012":
 include "gallery/art/012.php";
 break;
case "011":
 include "gallery/art/011.php";
 break;
case "010":
 include "gallery/art/010.php";
 break;
case "009":
 include "gallery/art/009.php";
 break;
case "008":
 include "gallery/art/008.php";
 break;
case "007":
 include "gallery/art/007.php";
 break;
case "006":
 include "gallery/art/006.php";
 break;
case "005":
 include "gallery/art/005.php";
 break;
case "004":
 include "gallery/art/004.php";
 break;
case "003":
 include "gallery/art/003.php";
 break;
case "002":
 include "gallery/art/002.php";
 break;
case "001":
 include "gallery/art/001.php";
 break;
case "art_02":
 include "gallery/art/057.php";
 break;
case "art_01":
 include "gallery/art/069.php";
 break;
default:
 require "gallery/art/069.php";
}
?>

sorry about posting all this crap. i have been searching for a solution for days.

i know there are many requires in that full size image include.

bpat1434

I'm gonna say this:
In my experience in dealing with switches that use numbers as identifiers, you normally don't need to make them strings. Normally they'll be just fine without them.

Also, you're missing a break with your default case which may be mucking up your switch.

~Brett

Daisatske

I think this is what you might be looking for. Tell me if this helps! ^_

<?PHP

$id = $HTTP_GET_VARS['id'];

switch($id)
{

 case "069": include("gallery/art/069.php");        break;
 case "068": include("gallery/art/068.php");        break;
 case "067": include("gallery/art/067.php");        break;
 case "066": include("gallery/art/066.php");        break;
 case "065": include("gallery/art/065.php");        break;
 case "064": include("gallery/art/064.php");        break;
 case "063": include("gallery/art/063.php");        break;
 case "062": include("gallery/art/062.php");        break;
 case "061": include("gallery/art/061.php");        break;
 case "060": include("gallery/art/060.php");        break;
    default: require("gallery/art/069.php");        break;

}

// DO NOT EDIT BELOW THIS LINE

$display = "$fact";
echo ($display);

Its always better to have cleaned up code instead of code that is scattered about.
Daisatske

bpat1434

Dais:
While that is "cleaned up" it might not be what he's looking for. His structure is fine. The problem he has is that the second page is not called. Your switch doesn't even account for art_01 or art_02 which are "id" values to galleries.

Origin:
While the switch may do what you want, you may be better off creating two switches: 1) gallery switch, 2) picture switch. With laying it out like that you can narrow down your error problems, and easier to debug. Something like:

<?php

if(!isset($_GET['id']))
{
    $id = 'art_01';
}
else
{
    $id = $_GET['id'];
    // Use HTTP_GET_VARS['id'] if you're still using
    // PHP <4.1
}

if(eregi('art_', $id))
{
    switch($id)
    {
        case 'art_01':
          include('/gallery/art/069.php');
          break;
        case 'art_02':
          include('/gallery/art/057.php');
          break;
        default:
          include('/gallery/art/069.php');
    }
}
else
{
    switch($id)
    {
        case 069:
          include('/gallery/art/069.php');
          break;
        // etc. etc.
    }
}

That's a little drawn out, but it does the same thing.

MY only question left is this: are you sure that 057.php and 069.php are supposed to show different things? I mean, if gallery 2 is a "copy" of gallery 1, are you 100% sure you changed all the necessary code. That's another thing that could be causing this problem.

~Brett

origin

thanks for the help. i got frustrated and quit working on this for a while. i'm really in over my head. this thing is working like this now:

there are thumbnails on the left and the full size image on the right with navigation under the thumbs. this navigation changes the thumbnails.

i'm still having the same problem: the default thumbs (art_thumbs_01.inc) work properly but when any other set of thumbs is selected clicking on any thumbnail will revert the thumbs to the default set. the full size image will be correct but the thumbs always go back to the default set. :bemused:

the thumbnails with navigation:

<div id="archive"><?php include("includes/thumbs.inc"); ?>
<div id="navigation">
     <ul>
	<li><a href="../br_index.php?page=art_01">1</a></li>
	<li><a href="../br_index.php?page=art_02">2</a></li>
	<li><a href="../br_index.php?page=art_03">3</a></li>
	<li><a href="../br_index.php?page=art_04">4</a></li>
	<li><a href="../br_index.php?page=art_05">5</a></li>
	<li><a href="../br_index.php?page=art_06">6</a></li>
     </ul>
</div>
  </div>

the samples:

<div id="sample"><?php include("includes/switcher.inc"); ?>
  </div>

includes/thumbs.inc:

<?PHP

$id = $HTTP_GET_VARS['page'];

switch($page)
{

case 'art_01':
 include "art_thumbs_01.inc";
 break;
case 'art_02':
 include "art_thumbs_02.inc";
 break;
case 'art_03':
 include "art_thumbs_03.inc";
 break;
case 'art_04':
 include "art_thumbs_04.inc";
 break;
case 'art_05':
 include "art_thumbs_05.inc";
 break;
default:
 require "art_thumbs_01.inc";
 break;
}
?>

includes/switcher.inc:

<?PHP

$id = $HTTP_GET_VARS['id'];

switch($id)
{ 

case "070":
 include "gallery/art/070.php";
 break;
 case "069":
 include "gallery/art/069.php";
 break;
case "068":
 include "gallery/art/068.php";
 break;
case "067":
 include "gallery/art/067.php";
 break;
case "066":
 include "gallery/art/066.php";
 break;
case "065":
 include "gallery/art/065.php";
 break;
case "064":
 include "gallery/art/064.php";
 break;
case "063":
 include "gallery/art/063.php";
 break;
case "062":
 include "gallery/art/062.php";
 break;
case "061":
 include "gallery/art/061.php";
 break;
case "060":
 include "gallery/art/060.php";
 break;
case "059":
 include "gallery/art/059.php";
 break;

// etc. etc.

default:
 require "gallery/art/070.php";
  break;
}


// DO NOT EDIT BELOW THIS LINE

$display = "$fact";
echo ($display);

?>

what do you think?

bpat1434

Doh!!

There is a minor error in your code. Look in thumbs.inc

$id = $HTTP_GET_VARS['page'];

switch($page)
{

Should really be:

$id = $HTTP_GET_VARS['page'];

switch($id)
{
OR
$page = $HTTP_GET_VARS['page'];

switch($page)
{

You never instantiated the $page variable, so it defaulted. Change one or the other and you should be in good form.

~Brett

origin

i tried both of these suggestions but the thumbnails still revert to the first set.

bpat1434 wrote:
Doh!!

There is a minor error in your code. Look in thumbs.inc

$id = $HTTP_GET_VARS['page'];

switch($page)
{

Should really be:

$id = $HTTP_GET_VARS['page'];

switch($id)
{
OR
$page = $HTTP_GET_VARS['page'];

switch($page)
{

You never instantiated the $page variable, so it defaulted. Change one or the other and you should be in good form.

~Brett

bpat1434

Well, I just went back and looked at how you ahve it set up. Let me see if I can clearly and concisely explain it.

When you show your main index page, there is no page or id $_GET[] variable set so it defaults. You click on a subsequent picture and it give the id variable a value. Then you decide to view page 2. The page variable is then populated. After that, there is no id variable so it defaults. When you go to click on a different thumb on page 2 (art_02) then page isn't set, so page defaults while id doesn't.

Understand?

So really, to fix this problem, you need to recreate your links so that they are:

<a href="br_index.php?page=art_01&id=053"><img...

~Brett

origin

Brett,

i changed the links and all is well in my world tonight. thank you very much. 🙂