what is wrong with this code?

batfink

<?php

if ($name = strstr ($HTTP_USER_AGENT, "MSIE")) && strstr ($HTTP_USER_AGENT, "firefox")) && strstr ($HTTP_USER_AGENT, "opera"))
{
header ("Location: /web/");
} else {
header ("Location: /wap/");
}

?>

i get this error

Parse error: parse error, unexpected T_BOOLEAN_AND in /home/xxx/xxx/xxx/var/www/html/index.php on line 2

?? :glare:

vaaaska

Is this line write?

if ($name = strstr ($HTTP_USER_AGENT, "MSIE")) 
&& strstr ($HTTP_USER_AGENT, "firefox")) 
&& strstr ($HTTP_USER_AGENT, "opera"))

perhaps...

if (($name == strstr($HTTP_USER_AGENT, "MSIE")) 
&& (strstr($HTTP_USER_AGENT, "firefox")) 
&& (strstr($HTTP_USER_AGENT, "opera")))

Boolean is true/false...I'm not sure if you will get that from what you are doing...

madwormer2

Well, you are getting the error because of the extra ) at the end of each strstr.

Although I'm not sure if your code is going to work how you want it to...

You are looking for it to be internet explorer AND opera AND mozilla?

Why would you want to do that, that'll always return false...

batfink

thanks for the tip on the extra parenthesis. 🙂

what im trying to do basically is redirect mobile phone users to /wap/

and web users to /web/

both directorys on my site.

thorpe

yeah... you'll want to use || instead of &&

madwormer2

$user_agent = $_SERVER["HTTP_USER_AGENT"];
if (
stristr($user_agent, "msie") 
|| stristr($user_agent, "mozilla") 
|| stristr($user_agent, "opera")
)
{
header ("Location: /web/");
} else {
header ("Location: /wap/"); 
}

Make sure it's at the top of the page...

Its using stristr which is case insensitive.

Mozilla is the string that shows all mozilla browsers including firefox.

And its using || (the or operandum 😛)

watev.

batfink

thats really helpful of you to edit that for me! thanks! :p

!! thanks! it worked. 😃

thats been driving me mad for a few hours!

madwormer2

Erm, just thought, include:

|| stristr($user_agent, "gecko")

Just 'coz

Another thought, you may want to think about it the other way around, because if a browser doesnt identify, it will automatically go to the wap page.

Take a look at http://help.websiteos.com/support/wap_and_domain_names.htm

batfink

thanks, i will do.