Problems with global variables

Fallenking

I'm using a function that calls generic information that many other functions need to run but my other functions can't seem to get any information from the global vars

$username = $_SESSION['username'];
function getcharacter($ctoget, $ctype)
{
	$select_character = mysql_query("SELECT * FROM characters WHERE member = '".$ctoget."' AND type = '".$ctype."'");
	$fetch_character = mysql_fetch_array($select_character);

//get character
global $cname, $wpn1, $wpn2, $cmaxhp, $ccurrenthp, $carmor, $cmaxhp, $cattack;
$cname = $fetch_character['name'];
$wpn1 = $fetch_character['wpn1'];
$wpn2 = $fetch_character['wpn2'];
$cmaxhp = $fetch_character['maxhp'];
$ccurrenthp = $fetch_character['currenthp'];
$carmor = $fetch_character['armor'];
$cattack = $fetch_character['attack'];


}

I'm having problems with this function

function thisonedoesntwork($attacker)
{
getcharacter($username, character);
$tmpwpn1 = $GLOBALS['wpn1'];
$tmpcarmor = $GLOBALS['carmor'];

echo "$tmpwpn1 and $tmpcarmor";
}

These variables that are echoed at the end have no value. What am I doing wrong?

Installer

The term "global scope" refers to outside of functions (not the same as "superglobal"). When you use "global", you're enabling the use of the varibable inside that function. It doesn't make it available anywhere else.

vaaaska

Well, you have the right idea, but not the right executiion. It's easier than what you have...

$username = $_SESSION['username'];

function getcharacter($ctoget, $ctype)
{
	$select_character = mysql_query("SELECT * FROM characters WHERE member = '".$ctoget."' AND type = '".$ctype."'");
	$fetch_character = mysql_fetch_array($select_character);

  return $fetch_character;

}

function thisonedoesntwork($attacker)
{
  $var = getcharacter($username, character);
  $tmpwpn1 = $var['wpn1'];
  $tmpcarmor = $var['carmor'];

echo "$tmpwpn1 and $tmpcarmor";
}

It's a little hard to tell what you are doing...but if you call up the first function and assign it to some variable you will get your results that are ready to go into another function. For instance...

phpmavenman

You have to tell the function to use the global variables defined outside of that function like so below:

function thisonedoesntwork($attacker)
{

global $wpn1,$carmor;
getcharacter($username, character);
$tmpwpn1 = $wpn1;
$tmpcarmor = $carmor;

echo "$tmpwpn1 and $tmpcarmor";
//or
echo "$wpn1 and $carmor";
}