my code is not working

Grunt

i am just trying to do kind of a register thing right now... The redirects work, and the md5 comparing works, but it doesnt actually add the data to the database.... The code is error free, but it just doesnt add insert the data.

<?php
$DBname = "fusion";
$DBuser = "root";
$DBpass = "";

$username=$_POST['txtUsername'];
$userpass=$_POST['txtPassword'];
$confpass=$_POST['txtConfirmPassword'];
$email=$_POST['txtEmail'];
$phone=$_POST['txtPhone'];
$dept=$_POST['txtDept'];
$jobtitle=$_POST['txtJobTitle'];
$submittrue=$_POST['cmdSubmit'];

mysql_connect(localhost, $DBuser, $DBpass);

@mysql_select_db($DBname) or die( "Unable to select database");

//md5 both the password and confirm boxes and test for equality
md5($userpass);
md5($confpass);

if ($submittrue == "Submit" && $userpass == $confpass)
{

	//set the query string
	$query = "INSERT INTO users VALUES ('$username','$userpass','$email','$phone','$dept','$jobtitle)";

	//actually do it
	mysql_query($query);

	//redirect the user to confirmation page
	header ('Location: addconf.htm'); 

	//close mysql
	mysql_close();
}

else
{
	//redirect user to failure page
	header ('Location: addfail.htm'); 

	//close mysql
	mysql_close();	
}
?>

vaaaska

Is it this line? You're missnig an ' after $jobtitle.

$query = "INSERT INTO users VALUES
('$username','$userpass','$email','$phone','$dept','$jobtitle)";

Ummm, that and it's in the wrong format...

$query = "INSERT INTO users
(name,of,fields,go,here...)
 VALUES
('$username','$userpass','$email','$phone','$dept','$jobtitle)";

Grunt

got it working now...

$query = "INSERT INTO users (username, userpass, email, phone, dept, jobtitle) VALUES ('$username','$userpass','$email','$phone','$dept','$jobtitle')";

thanks, cant believe i didnt see the missing apostrophe.......

:rolleyes:

vaaaska

It happens to everybody. Sometimes I simply count things like commas, parens, single-quotes, double-quotes and the like when I'm having problems debugging with db stuff in particular - it can help.

😉