error handling with remote images

[Jack_McSlay]

i'm making a random banner script that acquires the banner images remotely instead of being hosted in the own place.
however, whenever the image cannot be acquired, i want to display a image saying "image missing" and not that ugly PHP warning that pops up whenever you put a non-existing image as the argument for getimagesize()

i've tried using file_exists() but it doesn't work

function image ($source,$folder = IMAGE_FOLDER){
  $src = $folder.$source;
  $size = getimagesize ($src);

  return ("src =\"$src\" {$size[3]}");
}

(if anyone hasn't realized, IMAGE_FOLDER has been previously defined as the default image folder, since I also use the function for local images as well)

[Installer]

"getimagesize()" returns false on failure, so use an "if...else" block. Ideally you would have all your bases covered by the time you put your code into production, so that you can turn off error display.

[Jack_McSlay]

you mean,something like this?

function image ($source,$folder = IMAGE_FOLDER){

  $src = $folder.$source;

  if ( getimagesize ($src)){
    $size = getimagesize ($src);
  }
  else {
    $folder == IMAGE_FOLDER;
    $source = ERROR_IMAGE;
    $src = $folder.$source;
    $size = getimagesize ($src);
  }

  return ("src =\"$src\" {$size[3]}");
}

same error messages.

I didn't undestansd what you meant by covering all bases

[Installer]

function image($source, $folder = IMAGE_FOLDER)
{ 
    $src = $folder . $source; 
    $missing_img = 'pathname/for/default/image';
    if ($size = getimagesize($src)) { 
        return "src =\"$src\" {$size[3]}"; 
    } else { 
        // Put error-handling code here, such as:
        $size = getimagesize($missing_img);
        return 'src =" . $missing_img . '" {$size[3]}';
    } 
}

"Cover your bases" in this context: Have error-handling code in place to gracefully recover from any error that could occur (that you can reasonably foresee).

[drew010]

function image ($source,$folder = IMAGE_FOLDER){

  $src = $folder.$source;

  if ( $size = @getimagesize ($src) == false){
    $folder = IMAGE_FOLDER;
    $source = ERROR_IMAGE;
    $src = $folder . $source;
    $size = @getimagesize($src);
  }

  return ("src =\"$src\" {$size[3]}");
}

try something like that. its important to use the error supression operator (@) in front of functions that will output an error as long as you check for the error yourself.

[Installer]

Not before the code is ready for production, and his code isn't ready for production.

[Jack_McSlay]

thanks drew, worked just right, I wasn't aware of the @ operator