loop back to form page?

[oops73]

hi,

i have a code that check if users IDcode is already in database.
if the user tries to submit twice he will se a error message.

no to my problem. at the same time as the error message comes up, MySQL shows a error. duplicate entry'blablabla...' key2

i just want the user to see my error message and loop back to the form.

this is my code:

// Check IDcode already in database //
        $query = "SELECT $IDcode FROM users WHERE IDcode = '$IDcode'"; 
        $result = mysql_query($query ,$db); 
        $num_rows = mysql_num_rows($result); 
        if ($num_rows>0) { 
        print ("Sorry - this IDcode is already in use!");
        } else  { 
        $query = ""; 
        $result = mysql_query($query); 
}

    // End of Check IDcode already in database //

[kburger]

I'm guessing we're not seeing all the relevant code. The code you've got here won't generate that error message.

The indention looks suspicious. Is there any other surrounding code that might be generating that message?

[oops73]

Originally posted by kburger
I'm guessing we're not seeing all the relevant code. The code you've got here won't generate that error message.

The indention looks suspicious. Is there any other surrounding code that might be generating that message?

Here are the rest, sorry...

// connexion to database and table //
		$db = mysql_connect($host, $login, $password) or die ('Error : '.mysql_error());
		 mysql_select_db($base, $db) or die ('Error : '.mysql_error());


    // Check IDcode already in database //
	$query = "SELECT $IDcode FROM users WHERE IDcode = '$IDcode'"; 
    $result = mysql_query($query ,$db); 
    $num_rows = mysql_num_rows($result); 
    if ($num_rows>0) { 
    print ("Sorry - this IDcode is already in use!");
    } else  { 
    $query = ""; 
    $result = mysql_query($query); 
}

    // End of Check IDcode already in database //


	// Requête SQL //
	$sql = 'INSERT INTO users VALUES("","'.$Fname.'","'.$Lname.'","'.$IDcode.'","'.$Region.'","'.$Depart.'")';
	$result = mysql_query($sql) or die ('Error : '.mysql_error() );

	// close database and table //
	mysql_close();

	// Result //
	if (FALSE == $result){ 
		$error['sql'] = "There has been an error adding in the database! Please try again.";
	} else {
		$error['ok'] = "Thank you ".$_SESSION['Fname']. ", you are now registerd in our database.";
	} 
}
}

[kburger]

Is this really your code?

else {
$query = "";
$result = mysql_query($query);
}

An empty query?

Assuming the query's not really empty, you're then doing an insertion regardless whether or not there were any returned rows.

Also, you've got 2 closing brackets that don't match anything above. Again, this isn't the code, is it? Please post the exact code and the exact error message.

[oops73]

Originally posted by kburger
Is this really your code?

An empty query?

Assuming the query's not really empty, you're then doing an insertion regardless whether or not there were any returned rows.

Also, you've got 2 closing brackets that don't match anything above. Again, this isn't the code, is it? Please post the exact code and the exact error message.

I wonder what i should put between the 2 brackets???
take a look.

<?php

 //BaseCodeing DAVID DUCREST, ExdendedCoding JOEL ANDERSON//

session_start();

// connection to database // 
$host = 'localhost';		// host
$login = 'root';	// login
$password = '';		// password 				
$base = 'testbase';	// name of database

if (isset($_COOKIE[session_name()])) {
	$url = $_SERVER['PHP_SELF'];
} else if (defined('SID')) {
	$url = $_SERVER['PHP_SELF'].SID;
}


 // condition ? if yes : if no //
isset($_SESSION['Fname']) ? 	$Fname = $_SESSION['Fname'] : 	$Fname = NULL;
isset($_SESSION['Lname']) ? 	$Lname = $_SESSION['Lname'] :	$Lname = NULL;
isset($_POST['IDcode']) ? 		$IDcode = $_POST['IDcode'] : 	$IDcode = NULL;
isset($_SESSION['Region']) ? 	$Region = $_SESSION['Region'] :	$Region = NULL;
isset($_SESSION['Depart']) ? 	$Depart = $_SESSION['Depart'] :	$Depart = NULL;

// WORK now //
if (isset($_POST['action']) && ('add' == $_POST['action'])) 
{

////////// ACTION /////////
 // condition ? if yes : if no //
	isset($_POST['Fname']) ? 	$Fname = $_POST['Fname'] : 	$Fname = NULL;
	isset($_POST['Lname']) ? 	$Lname = $_POST['Lname'] :	$Lname = NULL;
	isset($_POST['IDcode']) ? 	$IDcode = $_POST['IDcode'] : $IDcode = NULL;
    isset($_POST['Region']) ? 	$Region = $_POST['Region'] : $Region = NULL;
	isset($_POST['Depart']) ? 	$Depart = $_POST['Depart'] : $Depart = NULL;
	// check if empty // 
	if (empty($Fname)) {
		$error['emptyFname'] = 'Empty Fname.';
	} else if (empty($Lname)){
		$error['emptyLname'] = 'Empty Lname.';
	} else if (empty($IDcode)){
	    $error['emptyIDcode'] = 'Empty IDcode.';
    } else if (empty($Region)){	
	    $error['emptyRegion'] = 'Empty Region.';
	} else if (empty($Depart)){	
		$error['emptyDepart'] = 'Empty Depart.';
	} else {	


	// connexion to database and table //
	$db = mysql_connect($host, $login, $password) or die ('Error : '.mysql_error());
	 mysql_select_db($base, $db) or die ('Error : '.mysql_error());


    // Check IDcode already in database //
	$query = "SELECT $IDcode FROM users WHERE IDcode = '$IDcode'"; 
    $result = mysql_query($query ,$db); 
    $num_rows = mysql_num_rows($result); 
    if ($num_rows>0) { 
    print ("Sorry - this IDcode is already in use!");
    } else  { 
    $query = ""; 
    $result = mysql_query($query); 
}

    // End of Check IDcode already in database //


	// Requête SQL //
	$sql = 'INSERT INTO users VALUES("","'.$Fname.'","'.$Lname.'","'.$IDcode.'","'.$Region.'","'.$Depart.'")';
	$result = mysql_query($sql) or die ('Error : '.mysql_error() );

	// close database and table //
	mysql_close();

	// Result //
	if (FALSE == $result){ 
		$error['sql'] = "There has been an error adding in the database! Please try again.";
	} else {
		$error['ok'] = "Thank you ".$_SESSION['Fname']. ", you are now registerd in our database.";
	} 
}
}
?>

<p align="center">SIMPLE PREVIEW &amp; SUBMIT PAGE</p>
<FORM name="lastpart" method="post" action="<?=$url;?>">
  <table width="50%" border="1" align="center">
    <tr> 
      <td>First Name:</td>
      <td><input type="text" name="Fname" value="<?=$Fname;?>">
        <font color="#FF0000">*</font> </td>
    </tr>
    <tr> 
      <td>Last Name:</td>
      <td><input type="text" name="Lname" value="<?=$Lname;?>">
        <font color="#FF0000">*</font> </td>
    </tr>
    <tr> 
      <td>IDcode:</td>
      <td><input type="text" name="IDcode" value="<?=$IDcode;?>">
        <font color="#FF0000">*</font> </td>
    </tr>
    <tr> 
      <td>Region &amp; Departement:</td>
      <td><input name="Region" value="<?=$Region;?>"></select>
        <font color="#FF0000">*</font> 
        <input  name="Depart" value="<?=$Depart;?>"></select>
        <font color="#FF0000">*</font></td>
    </tr>
    <tr> 
      <td>&nbsp;</td>
      <td><input name="action" type="hidden" value="add" /> <input type="submit" name="Submit" value="SEND TO DATABASE">

  </td>
</tr>
  </table>
  </FORM>
<p>&nbsp;</p>
<p><a href="page_4.php" target="_blank">SEE database!</a></p>
<?php
// message modification ou erreurs
if (isset($_POST['action']) && ('add' == $_POST['action']) && isset($error)) {
	$error = implode("<br />", $error);
	echo '<div style="color:#999;">'.$error.'</div>';
}
unset($error); ?>

[kburger]

You need to move your insertion query into your 'else' structure. Right now you've got an empty query there. Then below, you do the insertion even if there was already $IDcode in the users table.

Change this:

// connexion to database and table //
$db = mysql_connect($host, $login, $password) or die ('Error : '.mysql_error());
 mysql_select_db($base, $db) or die ('Error : '.mysql_error());


// Check IDcode already in database //
$query = "SELECT $IDcode FROM users WHERE IDcode = '$IDcode'"; 
$result = mysql_query($query ,$db); 
$num_rows = mysql_num_rows($result); 
if ($num_rows>0) { 
	print ("Sorry - this IDcode is already in use!");
} else  { 
	$query = ""; 
	$result = mysql_query($query); 
}

// End of Check IDcode already in database //


// Requ?te SQL //
$sql = 'INSERT INTO users VALUES("","'.$Fname.'","'.$Lname.'","'.$IDcode.'","'.$Region.'","'.$Depart.'")';
$result = mysql_query($sql) or die ('Error : '.mysql_error() );

// close database and table //
mysql_close(); 

to this:

// connexion to database and table //
$db = mysql_connect($host, $login, $password) or die ('Error : '.mysql_error());
 mysql_select_db($base, $db) or die ('Error : '.mysql_error());


// Check IDcode already in database //
$query = "SELECT $IDcode FROM users WHERE IDcode = '$IDcode'"; 
$result = mysql_query($query ,$db); 
$num_rows = mysql_num_rows($result); 
if ($num_rows>0) { 
	print ("Sorry - this IDcode is already in use!");
} else  { 
	// Requ?te SQL //
	$sql = 'INSERT INTO users VALUES("","'.$Fname.'","'.$Lname.'","'.$IDcode.'","'.$Region.'","'.$Depart.'")';
	$result = mysql_query($sql) or die ('Error : '.mysql_error() );
}

// End of Check IDcode already in database //

// close database and table //
mysql_close();