long winded php assistance needed

thewomb

hey im wondering if there is any way to make the if statements simpler and somehow reduce the amount of code required as there will be over 200 actial vars to be collected and checked.

<?
//INFO VAR
$a = $_REQUEST['01'];
$b = $_REQUEST['02'];
$c = $_REQUEST['03'];
$d = $_REQUEST['04'];


// PRESENTATION VAR
$aa = $_REQUEST['01a'];
$bb = $_REQUEST['02a'];
$cc = $_REQUEST['03a'];
$dd = $_REQUEST['04a'];


// ASSISTANCE VAR
$aaa = $_REQUEST['01b'];
$bbb = $_REQUEST['02b'];
$ccc = $_REQUEST['03b'];
$ddd = $_REQUEST['04b'];


$name = $_REQUEST['name'];
$email = $_REQUEST['email'];
$phone = $_REQUEST['phone'];
$company = $_REQUEST['company'];

$headers = "From: $email \n\n"
			."Reply-To: $email \n\n"
			."MIME-Version: 1.0 \n\n"
			."Return-Path: $email \n\n"
			."Content-type: text/html; charset=iso-8859-1 \n\n"
			."X-Mailer: PHP/" . phpversion();


//mail("XX", "info request", $email_body, $headers);
//mail("XX", "info request", $email_body, $headers);


// format info requests

if (isset($a))
{
$ainfo = '<br>'.$name.' has requested info for '. $a;
echo $ainfo;
}

if (isset($b))
{
$binfo = '<br>'.$name.' has requested info for '. $b;
echo $binfo;
}

if (isset($c))
{
$cinfo = '<br>'.$name.' has requested info for '. $c;
echo $cinfo;
}

if (isset($d))
{
$dinfo =  '<br>'.$name.' has requested info for '. $d;
echo $dinfo;
}

echo '<p>';

// format presentation requests 

if (isset($aa))
{
$apres = '<br>'.$name.' has requested a presentaion for '. $aa;
echo $apres;
}

if (isset($bb))
{
$bpres = '<br>'.$name.' has requested a presentaion for '. $bb;
echo $bpres;
}

if (isset($cc))
{
$cpres = '<br>'.$name.' has requested a presentaion for '. $cc;
echo $cpres;
}

if (isset($dd))
{
$dpres = '<br>'.$name.' has requested a presentaion for '. $dd;
echo $dpres;
}

// format Assistance requests

if (isset($aaa))
{
$aassist = '<br>'.$name.' has requested assistance for '. $aaa;
echo $aassist;
}

if (isset($bbb))
{
$bassist = '<br>'.$name.' has requested assistance for '. $bbb;
echo $bassist;
}

if (isset($ccc))
{
$cassist = '<br>'.$name.' has requested assistance for '. $ccc;
echo $cassist;
}

if (isset($ddd))
{
$dassist = '<br>'.$name.' has requested assistance for '. $ddd;
echo $dassist;
}


?>

justsomeone

The chances are this could and should be simplified, but it's a bit tricky to work out exactly what you are trying to do.

Start by describing what you are trying to achieve. It will be easier for people to come up with ways of achieving what you want, than it will be for them to decipher what your code is trying to do.

leatherback

Hi,

I think you can work this easier by using arrays. But as mentioned by justsomeone, it is hard to say, without knowing what you need to do.

Anyway..

In your form, name the fields of one 'category' the same. So your a, b, c, d varas would all be:

<input type=text name=INFO[] value=YOURVALUE> input a

<input type=text name=INFO[] value=YOURVALUE> input b

<input type=text name=INFO[] value=YOURVALUE> input c

<input type=text name=INFO[] value=YOURVALUE> input d

Then, in the processing form:

$info = $_request[info];

Foreach($info as $key => value)
  {
  echo $value;
  }

// or:

echo $info[0];

leatherback

You could even make it less complex still..

Use
variable[0][] for info,
variable[1][] for presentation ...

Then you could do:

For ($i = 0; $i <4; $i++)
  {
    Foreach($info[$i] as $key => value)
     {
     echo $value;
     } 
  }