[RESOLVED] Complex Conditionals (if nested inside for)?

[cbj4074]

Hi everyone,

I need to check for a couple of different conditions, but want to make my code as simple and efficient as possible.

Basically, I have 4 test numbers, one of which is appended in the URI when the user clicks a test link. For example, the user clicks:

test.php?test_number=1

I want it to be impossible to cause errors on the page by specifying an invalid test number, so I need to make sure that test_number is equal to 1, 2, 3, or 4, and nothing else.

I could do:

if ($test_number != 1 || $test_number != 2 || $test_number != 3 || $test_number != 4) {
     header('location: ' . $parent_page);
     die();
}

However, that will become pretty cumbersome as more tests are added.

Is there an easier/better way to do this check using a loop?

Thanks for all your help!

[paulnaj]

Hi,

It could depend on a few things, but if the range of possibilities is for example, integers from 1 to 1,000, say then ...

<?php
if(!is_int($test_number) ||  $test_number  < 1 || 1000 < $test_number) { 
     header('location: ' . $parent_page); 
     die(); 
}
?>

... would do the trick. But even if you had a 'messy' set of possibilities, you might use in_array() ...

<?php
$poss = array(1, 4, 5, 8, 'hello');
if(!in_array($test_number, $poss)) { 
     header('location: ' . $parent_page); 
     die(); 
}
?>

Hope that helps!

Paul.

[cbj4074]

Exactly what I was looking for.

Thanks, Paul! 🙂