is set field='$field[$value[$index]]' legal?

[searain]

$sql_update="update table1 set field='$field[$value[$index]]' where value=$value[$index]"

This $sql_update gives me error message says that parse error expecting "[" ...

So I changed it to

$this_value=$value[$index];
$sql_update="update table1 set field='$field[$this_value]' where value=$this_value";

To me it is the same, but this time, this $sql_update is fine.

Thanks!

[paulnaj]

Hi searain,

Can't quite see exactly what the problem is with the first one, although I would guess that it's got something to do with embedding the variables in the string ... not a good idea in the first place IMHO :queasy:

Better to cut in and out of strings, like ...

<?php
$sql_update = "
	UPDATE table1 
	SET field='".$field[$value[$index]]."' 
	WHERE value=".$value[$index]."
"; 
?> 

... which won't have the problems of your first example, runs a tad faster, and is much easier to see what's going on and debug.

The only benefit to embedding I can see is that is fractionally faster to type.

Paul. 🙂

[robert_w_ark]

Originally posted by paulnaj
...

<?php
$sql_update = "
	UPDATE table1 
	SET field='".$field[$value[$index]]."' 
	WHERE value=".$value[$index]."
"; 
?> 

That code wont work. Syntax error. Try using:

$sql_update = "UPDATE table1 SET field = '".$field[$value[$index]]."' WHERE value = '".$value[$index]."'";

[paulnaj]

Nothing wrong with mine, mate. $value is numeric, so quotes are not right.