Question about application structure...

[mattd123]

Hmm, just randomly thought I'd attempt to make some forum software, and figured that if it's going to be something that other people could be editing etc, it'd be better if it was well structured.

So, for index.php, where everything is brought together, i have the current code (the significant part anyway, reduced slightly for posting purposes):

include_once('sources/header.php'); // DB connect, logo, nav etc etc
include_once('sources/jscript.php'); // Javascript functions


if (isset($_GET['act'])) {
	$act = $_GET['act']; 

// A switch which will include the appropriate file, based upon 
// what the $_GET variable is.  Each file is concluded with exit2() 
// function as described in code section below.


switch ($act) {

case ($act == 'newtopic' && isset($curforum)):
	include('sources/newtopic.php');
   		break;    
case ($act == 'register'):
	include('sources/register.php');
	break;  
	case ($act == 'login'):
	include('sources/login.php');
	break;
  	case ($act == 'logout'):
	include('sources/logout.php');
	break;
	case ($act == 'usercp'):
	include('sources/usercp.php');
	break;
	case ($act == 'memberlist'):
	include('sources/members.php');
	break;
case ($act == 'viewprofile'):
	include('sources/profile.php');
	break;

// etc etc etc...
}
}

// Display the forums if thecode hasn't already exited (i.e. it's on 
// the main page)
include('sources/viewforums.php');
// Online users, members etc, again will only display on main
// page as code will have exited otherwise. 
include ('sources/footerstats.php'); 

function exit2()
{
// Footer stuff
exit();
}

So basically, I was wondering if that would be a viable way of doing things. It works, yes, but I'm not sure how it would be performance wise etc...so any comments/suggestions/alternatives etc?

Thanks 🙂

[leatherback]

Recently I started working like that for a CMS I am building. This allows you for easy loginchecking, and referring when people attempt to do stuff they shouldn't be doing.

I am not sure about performence. In my case I have only 15 cases in the switch, and then more in the include (So there is a switch for 'link management.php, which subsequently has a switch for new / update / delete / new section / remove section / update section'

Works wonders for me.

J.

[mattd123]

Thanks for the response, I'm glad to hear it worked well for you. 🙂

I too also have several switches, for example, one to parse each of the variables in ?act=usercp&do=editprofile. This works, but has led me to another question: how much would the scripts need to be broken down?

Currently, on the second switch ($do), I have the code to run directly in the switch, as opposed to being included. This means that when I'm done, I'm going to have a pretty large usercp.php file (~60kb). I'm presuming that this wouldn't affect the client noticibly, since whichever route is taken (included or direct) the data is having to be parsed/get there anyway. Guess it's just about the organistation really...

thinks about stuff

[leatherback]

The CMS I am building has now about 80 files, and 400 Kb of script. I move every function-set to a new file, so I can use it in different parts of the program.

(So basically I am between OOP en NOOP)

J