yay looping! :(

Richardtagger

ok, i have a cron job to run the following script which is supposed to do the following things:
1) take 1 day off the "daysleft" value on each row - it does this fine.
2) make projects which have 0 days and arent already inactive, inactive - it also does this fine.
3) find the users who's projects just ended by looking for inactive where notified= no, - it gets them fine, but when i try making a foreach loop i get an error :
Warning: Invalid argument supplied for foreach() in /home/needsite/public_html/dbupdatercron24hours.php on line 9
my php is as follows, woulkd you mine checking it is correct and that im not making errors on the loops, it gets kinda complicated and frustrating, i cant see whats wrong, can any of you?

<?php 
include 'db.php';

$sql_days = mysql_query("UPDATE projects SET daysleft=daysleft -1 WHERE active='yes'") or die(mysql_error()); // take a day off
$sql_make_inactive = mysql_query("UPDATE projects SET active='no' WHERE daysleft='0'") or die(mysql_error()); // make projects with 0 days left inactive
$get_inactive_users = mysql_query("SELECT * FROM projects WHERE active='no' AND notifieduser='no'") or die(mysql_error()); // get inactive projects where the user has not been mailed.  

while($r = mysql_fetch_array($get_inactive_users)) { // sort the users gathered from projects query into an array
$users = $r['user'];
foreach($users as $value) { 
echo "$value";
}
exit();
foreach($users as $value) { // for each user
$get_mail =  mysql_query("SELECT * FROM projects WHERE username='$value");
while($r2 = mysql_fetch_array($get_mail)) { //sort the users from the users query into an array
$mail_addy = $r2['email'];
// To send HTML mail, the Content-type header must be set
$headers  = 'MIME-Version: 1.0' . "\r\n";
$headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";
// Additional headers
$headers .= 'From: NeedSite.net <mailer@needsite.net>' . "\r\n";
mail($mail_addy, 'testing', 'message', $headers);

}
}
}
?>

line 9 is the first for each loop which i was just trying to test and i cant get it to work.. thanks in advance.
Richard

leatherback

Assuming it is this line:

foreach($users as $value)

I think it should be:

foreach($users as $value=>$key)

Richardtagger

foreach($users as $value=>$key) {
echo "$value";
}

still comes out with the error.

Installer

foreach($users as $value=>$key)

I don't see what that's supposed to do, l.b.?

Change

$users = $r['user'];

// to

$users[] = $r['user'];

Then move the foreach loop out of the while loop.

include 'db.php'; 

$sql_days = mysql_query("UPDATE projects SET daysleft=daysleft -1 WHERE active='yes'") or die(mysql_error()); // take a day off 
$sql_make_inactive = mysql_query("UPDATE projects SET active='no' WHERE daysleft='0'") or die(mysql_error()); // make projects with 0 days left inactive 
$get_inactive_users = mysql_query("SELECT * FROM projects WHERE active='no' AND notifieduser='no'") or die(mysql_error()); // get inactive projects where the user has not been mailed.   

while($r = mysql_fetch_array($get_inactive_users)) { // sort the users gathered from projects query into an array 
    $users[] = $r['user']; 
}
foreach($users as $value) { // for each user 
    $get_mail =  mysql_query("SELECT * FROM projects WHERE username='$value"); 
    while($r2 = mysql_fetch_array($get_mail)) { //sort the users from the users query into an array 
        $mail_addy = $r2['email']; 
        // To send HTML mail, the Content-type header must be set 
        $headers  = 'MIME-Version: 1.0' . "\r\n"; 
        $headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n"; 
        $headers .= 'From: NeedSite.net <mailer@needsite.net>' . "\r\n"; 
        mail($mail_addy, 'testing', 'message', $headers); 
    } 
}

Richardtagger

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/needsite/public_html/dbupdatercron24hours.php on line 13

using Installers code.

Installer

Then your $get_mail query isn't getting any results. I should have left an echo or two in there. Add "echo $r['user'] . '<br />';" after the "$users[] = ..." line, and "echo mysql_num_rows($r2);" after the "$get_mail = ..." line.

Richardtagger

echo $r['user'] . '<br />';
echos the two usernames like it should.

but
echo mysql_num_rows($r2);
creates:
Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/needsite/public_html/dbupdatercron24hours.php on line 13

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/needsite/public_html/dbupdatercron24hours.php on line 14

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/needsite/public_html/dbupdatercron24hours.php on line 13

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/needsite/public_html/dbupdatercron24hours.php on line 14

Installer

I think I might have spotted it. There's no closing single quote after "$value" in the "$get_mail" query.

Richardtagger

yep, it's working now, thnx, o and also.. i have that loop with a foreach on the users how do i do a thing like:

foreach($users as $value, $id as value2)

i know thats wrong its just i need to get more values through the loop and i can put another loop inside that one as it ends up sending too many mails and it gets messy. Anyone know a way of doing it so that i use:

<?
include 'db.php'; 

$sql_days = mysql_query("UPDATE projects SET daysleft=daysleft -1 WHERE active='yes'") or die(mysql_error()); // take a day off
$sql_make_inactive = mysql_query("UPDATE projects SET active='no' WHERE daysleft='0'") or die(mysql_error()); // make projects with 0 days left inactive
$get_inactive_users = mysql_query("SELECT * FROM projects WHERE active='no' AND notifieduser='no'") or die(mysql_error()); // get inactive projects where the user has not been mailed.   

while($r = mysql_fetch_array($get_inactive_users)) { // sort the users gathered from projects query into an array
    $users[] = $r['user'];
	$project[] = $r['name'];
}

foreach($users as $value)  { // for each user
    $get_mail =  mysql_query("SELECT * FROM users WHERE username='$value'") or die(mysql_error()); 
    while($r2 = mysql_fetch_array($get_mail)) { //sort the users from the users query into an array
        $mail_addy = $r2['email']; 
		echo $mail_addy;
        // To send HTML mail, the Content-type header must be set
        $headers  = 'MIME-Version: 1.0' . "\r\n"; 
        $headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n"; 
        $headers .= 'From: NeedSite.net <mailer@needsite.net>' . "\r\n";
	$message = "<html>
<style type=\"text/css\">
.form {
background-color:#F2F2F2;
border-bottom-color:#999999;
border-bottom-style:solid;
border-bottom-width:1;
border-top-color:#999999;
border-top-style:solid;
border-top-width:1;
border-left-color:#999999;
border-left-style:solid;
border-left-width:1;
border-right-color:#999999;
border-right-style:solid;
border-right-width:1;
background-repeat:no-repeat;
}
.style1 {
	font-family: Geneva, Arial, Helvetica, sans-serif;
	font-size: 12px;
	color: #FFFFFF;
}
.style3 {font-size: 14}
.style4 {font-size: 14px}
.style5 {
	font-family: Geneva, Arial, Helvetica, sans-serif;
	font-size: 12px;
}
a:link {
	text-decoration: none;
}
a:visited {
	text-decoration: none;
}
a:hover {
	text-decoration: none;
}
a:active {
	text-decoration: none;
}
.style6 {
	font-size: xx-small;
	font-family: Geneva, Arial, Helvetica, sans-serif;
}
.style7 {color: #666666}
.style8 {font-family: Geneva, Arial, Helvetica, sans-serif; font-size: 12px; color: #666666; }
.style9 {color: #9E0309}
.style12 {font-size: 9px; color: #666666;}
</style>
<table width=\"596\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"0\">
  <tr background=\"http://www.needsite.net/img/banner.gif\">
    <td valign=\"top\" background=\"http://www.needsite.net/img/banner.gif\" class=\"form\"><div align=\"right\" class=\"style1\"><br>
        <span class=\"style3\"><br>
        <span class=\"style4\"><strong>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Automated email service&nbsp;&nbsp;</strong></span></span><span class=\"style4\"><strong>&nbsp;&nbsp;&nbsp;&nbsp;</strong></span><strong>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; </strong></div>      <p><br>
        <br><br>
        <span class=\"style8\">Dear $value,<br>
        <br>
      Our records indicate your project has just ended at <span class=\"style5\"><span class=\"style7\"><a href=\"http://www.needsite.net\" style=\"color:#9E0309\">[url]www.needsite.net[/url]</a></span></span>. Once you've logged in you'll be able to review the bids.</span></p>      

      <p class=\"style5\"><span class=\"style7\">Regards,<br>
        Richard Tagger,<br>
        Administrator,<br>
      <a href=\"http://www.needsite.net\" style=\"color:#9E0309\">[url]www.needsite.net[/url]</a></span></p></td>
  </tr>
</table>
<div align=\"center\" class=\"style6\">  <span class=\"style12\">Copyright NeedSite&copy; 2005<br>
  <br>
</span>
  <table width=\"596\" border=\"0\" align=\"center\" cellpadding=\"5\" cellspacing=\"0\">
    <tr>
      <td valign=\"top\" class=\"form\"><div class=\"style6 style7\">
        <p align=\"center\">Sposored Advertisements:<br>
<br>
<a href=\"http://www.needsite.net/advert.php\" class=\"style9\">Want to advertise here?</a><br>
</p>
        </div>
      </td>
    </tr>
  </table>
<span class=\"style12\">  </span></div>
</html>";
        mail($mail_addy, 'Project End Notifiation', "$message", $headers);
$make_inactive = mysql_query("UPDATE projects SET notifieduser='yes' WHERE user='$value'") or die(mysql_error());// record the sending.
    } 
}


?>

that code ^{^{^,}} where i can send the project title in the mail, so far the project titles are stored in an array.. i ned to include some kind of for each but i need it so that i dont have loops within loops... i needto use to values from two different arrays.. and only send the mail once.any ideas? thanx

Installer

I haven't found where in the email you're trying to place the project names, but I suppose that's not real important.

The project name can be used in the email the same way the username and address are. It looks like the foreach loop was really unnecessary, so this (untested) should work:

// Superceded

Can't you simplify the script until you get it working, and add all that static html stuff then, or at least when you don't need to ask other people to decipher your code?

Richardtagger

the reason i need a foreach is because it emails multiple people..? ill test what you tried. thanx

Richardtagger

The thing is... it is querying two tables.... projects and user.... it gets the username from projects.. and selects their email address from the users table... youve removed one of the queries so im not really sure where to go.. other than that it works fine.. just doesnt retrieve the email addresses as theyre stored in "users".

Installer

Yes, my fault. I didn't look at your queries well enough to see there are two tables. I'll take another whack at it right now.

Installer

This should do it:

// Superceded

Richardtagger

for some reason it's not getting the email addresses anymore.. the output was:

tagger

Dating Website - Clone of www.hotdates.com!
// HTML stuff here // Insert your project name etc. like this, wherever you want it, // Formatted however you want. This is just for example Your project is: Dating Website - Clone of www.hotdates.com!
Your username is: tagger
Your email address is:
Your project has ended.
// More HTML stuff here
richard

FINAL TESTING!
// HTML stuff here // Insert your project name etc. like this, wherever you want it, // Formatted however you want. This is just for example Your project is: FINAL TESTING!
Your username is: richard
Your email address is:
Your project has ended.
// More HTML stuff here

Richardtagger

yeh, i can kinda see why it aint working.... the way youre defingin $mail_addy isnt right is it, as the $get_inactive_users query is on the wrong table..?

Installer

Redone again (foreach loop removed, should get email):

include 'db.php';    

$sql_days = mysql_query("UPDATE projects SET daysleft=daysleft -1 WHERE active='yes'")   

    or die(mysql_error()); // take a day off 
$sql_make_inactive = mysql_query("UPDATE projects SET active='no' WHERE daysleft='0'")   

    or die(mysql_error()); // make projects with 0 days left inactive 
$get_inactive_users = mysql_query("SELECT * FROM projects WHERE active='no' AND notifieduser='no'")   

    or die(mysql_error()); // get inactive projects where the user has not been mailed.      

while($r = mysql_fetch_array($get_inactive_users)) { // sort the users gathered from projects query into an array 
    $user = $r['user'];
    $project = $r['name'];
    $get_mail =  mysql_query("SELECT * FROM users WHERE username='$user'")  

        or die(mysql_error()); 
    $mail_addy = mysql_result($get_mail, 0, 'email');    

    $headers  = 'MIME-Version: 1.0' . "\r\n";    

    $headers .= 'Content-type: text/html; charset=iso-8859-1' . "\r\n";    

    $headers .= 'From: NeedSite.net <mailer@needsite.net>' . "\r\n";   

    $message = "<html><br /> 
                // HTML stuff here <br /> 
                // Insert your project name etc. like this, wherever you want it, <br /> 
                // Formatted however you want. This is just for example. <br />  

                Your project is: $project <br /> 
                Your username is: $user <br /> 
                Your email address is: $mail_addy <br /> 
                Your project has ended. <br /> 
                // More HTML stuff here. <br />   

                </html>";   

    echo $message . '<br />';  

    mail($mail_addy, 'Project End Notifiation', $message, $headers);   

    $make_inactive = mysql_query("UPDATE projects SET notifieduser='yes' WHERE user='$user'")   

        or die(mysql_error());// record the sending. 
}

Edit: Leftover line removed.

Richardtagger

yep thanx, i realised the left over line and removed it, thanx for you help.

Installer

Did it work? 🙂

Richardtagger

yah it works great, cheers.