Syntax problem

Jon12345

What is wrong with the syntax here? I keep trying loads of things but can't find the answer.

echo "<td height='21'><a href='main.php?filter=".$row['ProductID']."&Category='$Category"'." class='style3'>".$row['Product']."</a></td>";

thorpe

echo '<td height="21"><a href="main.php?filter='.$row['ProductID'].'&Category='.$Category.'" class="style3">'.$row['Product'].'</a></td>';

halojoy

.
These long lines, with links, can make me all dizzy.

Here is another solution.
Sometimes can be easier to sort a string out, if you make a variable first.
Divide it into sections, which are added together.
Then display variable.

<?php

$Category = 'cat2';
$row['ProductID']= 'id5';
$row['Product'] = 'Product'; 

$link = "<td height='21'>";
$link .= "<a class='style3' href='main.php?filter="  .$row['ProductID'];
$link .= "&Category="  .$Category;
$link .= "'>"  .$row['Product'].  "</a></td>";
echo $link;

?>

Installer

FWIW, I'm with Thorpe on using single quotes for PHP strings and double quotes for HTML values, but I agree with halojoy, too, although I'd do it more like this (all those .=s can make me dizzy):

$link = '<td height="21">' . 
        '<a class="style3" href="main.php' .
        '?filter=' . $row['ProductID'] .
        '&Category=' . $Category . '">' . 
         $row['Product'] . 
        '</a></td>'; 
echo $link

Jon12345

This solution worked fine thanks. While I'm at it, can I ask what is wrong with this?

$result = mysql_query("SELECT * FROM products WHERE ProductID=".$filter." AND CategoryID=".$CategoryID);

thorpe

providing CatigoryID and ProductID are stored as (int) in your db, there is nothing wrong with this. though you dont need to escape out of the string while your using double quotes. so this could be simplified to;

$result = mysql_query("SELECT * FROM products WHERE ProductID=$filter AND CategoryID=$CategoryID");

where are the variables $filter and $CatigoryID comming from though? if they come from a form, you should be referencing them using the $_POST array.

eg;

$filter = $_POST['filter'];
$CatigoryID = $_POST['CatigoryID'];
$result = mysql_query("SELECT * FROM products WHERE ProductID=$filter AND CategoryID=$CategoryID");