[Resolved] fopen() not creating file

fire_cracker

I am attempting to write an online HTML editor for my website, and the first step is trying to make sure that the user has an index.html file in their folder, and if it doesn't create it and put in the basic text that the file should contain. For some reason the code won't make the file, and thus it is unable to read it into my textarea box. I have my error reporting turned all the way on. I have tried using the following methods of opening the file: w, w+, x, x+, a, a+. None of which will create the file for me.

Here is my code:

<?
session_start();
ini_set('display_errors', 'On'); 
ini_set('display_startup_errors', 'On'); 
error_reporting(E_ALL);

//Grab the Session vars
foreach($_SESSION as $key => $value) {
  $key = $value;
}

$file_dir = $_SERVER['DOCUMENT_ROOT'] . "/fms/users/" . $username;

$file_name = $file_dir . "/index.html";

//if the file doesn't exist, create it
if(file_exists($file_name) == "false") {
  echo "I know that " . $file_name . " doesn't exist<br>";
  $fh = fopen($file_name, 'w+') or die("Could Not Create The File");
  $text = "<html>\r\n <head>\r\n <title>". $username . "'s Website</title>\r\n </head>\r\n <body>\r\n </body>\r\n </html>";
  fwrite($fh,$text) or die("Could Not Write To The File");
  fclose($fh);
}

//read the contents of the file to be displayed in the textarea
$fp = fopen($file_name, 'r') or die("Could Not Open File To Write");
$file = fread($fp,filesize($fp)) or die("Could Not READ The File");

echo "<div align='center'>";
require("http://www.bluecollardigital.com/header.php");
echo "</div>";
?>
<div align="center">
<form name="htmledit" method="post" action="../../savefile.php">
<input type="hidden" name="file_name" value="index.html">
<textarea rows="10" cols="60" wrap="off"><? echo $file; ?></textarea><br>
<input type="submit" name="submit" value="Save File">
</form>
</div>
</body>
</html>

Thanks for the help

VisionsOfCody

Hi
I may be wrong but I don't think that fopen() will create a file - but touch() will

$filename = "test.dat";
if (!file_exists($filename)) {
 touch($filename); // Create blank file
 chmod($filename,0666);
}

then you can use fopen()

fire_cracker

Thank you for the help, but the problem appears to have mutated on me. Now it is saying the file exists (by not doing the if(file_exists($file_name) == "false") statement. I've checked on my FTP and Putty, and both agree that the file doesn't exist.

here is my current code, I've omitted nothing this time, just incase it is some stupid error.

<?
session_start();
ini_set('display_errors', 'On'); 
ini_set('display_startup_errors', 'On'); 
error_reporting(E_ALL);

//Send the user to the login page, if they aren't logged in
if(!$_SESSION['username']) {
  echo "<center><font size='5' color='red'><b>PLEASE LOG IN</b></font></center>";
  include('../.././includes/login_form.html');
  exit();
}

//Grab the Session vars
foreach($_SESSION as $key => $value) {
  $key = $value;
}

//Get Included Files Included :)
$include_dir = $_SERVER['DOCUMENT_ROOT'] . "/fms/includes/";
$include_config = $include_dir . "config.php";
$include_sql = $include_dir . "sql_connect.php";
require($include_config);
require($include_sql);

//Define some variable stuff
$directory = "http://www.bluecollardigital.com/fms/users/" . $username . "/";
$file_dir = $_SERVER['DOCUMENT_ROOT'] . "/fms/users/" . $username;

$file_name = $file_dir . "/index.html";

//if the file doesn't exist, create it
if(file_exists($file_name) == "false") {
  echo "I know that " . $file_name . " doesn't exist<br>";
  touch($file_name) or die("Could Not Create The File");
  chmod($file_name,0666);
  $fh = fopen($file_name, 'w') or die("Could Not Write To The File");
  $text = "<html>\r\n <head>\r\n <title>". $username . "'s Website</title>\r\n </head>\r\n <body>\r\n </body>\r\n </html>";
  fwrite($fh,$text) or die("Could Not Write To The File");
  fclose($fh);
}

//read the contents of the file to be displayed in the textarea
$fp = fopen($file_name, 'r') or die("Could Not Open File To Write");
$file = fread($fp,filesize($fp)) or die("Could Not READ The File");

echo "<div align='center'>";
require("http://www.bluecollardigital.com/header.php");
echo "</div>";
?>
<div align="center">
<form name="htmledit" method="post" action="../../savefile.php">
<input type="hidden" name="file_name" value="index.html">
<textarea rows="10" cols="60" wrap="off"><? echo $file; ?></textarea><br>
<input type="submit" name="submit" value="Save File">
</form>
</div>
</body>
</html>

Thanks again for all the help

VisionsOfCody

have you tried

if(!file_exists($filename))

maybe that'll do the trick

fire_cracker

Okay, after I changed that line, it is now recognizing that the file doesn't exist; however, it is not creating the file, or writing to the file. Also my or die statments for both the touch and fopen() commands are not executing, so either those lines are being ingmored, or PHP thinks that it is both creating and writing to the file.

I had a similar script working last night, but now the new version (that actualy has a function) doesn't seem to do anything.

halojoy

Originally posted by VisionsOfCody
have you tried
if(!file_exists($filename))
maybe that'll do the trick

I think that is better.

And I am not sure you should put quotes around "false"
That would make it a string .
$var = "false"; is not same as $var = FALSE;

I know we can use lower case letter for FALSE
but I alway use capital letters, just to mark it is a predefined php variable.

Somtimes also matters if you use == or === (2 or 3)
=== means that is BOTH same type ( integer, boolean, string ) and equal

<?php
if ( $somevariable === FALSE ) {
     // do something
}

fire_cracker

Okay, that little bit of code seemed to do the trick. It will now create the file, write the predefined code to the file, close the file; however, it will not read the file no mater how I try. I'm getting the warning:

Warning: filesize(): Stat failed for Resource id #5 (errno=2 - No such file or directory) in /homepages/19/d126260960/htdocs/websites/bluecollardigital.com/fms/htmledit/editfile.php on line 46

Warning: fread(): Length parameter must be greater than 0. in /homepages/19/d126260960/htdocs/websites/bluecollardigital.com/fms/htmledit/editfile.php on line 46
Could Not READ The File (Instance Two)

I've modified my script some, in an attempt to make it function somehow...I'm about to start pulling out my hair with this one.

Here is the new code:

<?
session_start();
ini_set('display_errors', 'On'); 
ini_set('display_startup_errors', 'On'); 
error_reporting(E_ALL);

//Send the user to the login page, if they aren't logged in
if(!$_SESSION['username']) {
  echo "<center><font size='5' color='red'><b>PLEASE LOG IN</b></font></center>";
  include('../.././includes/login_form.html');
  exit();
}

//Grab the Session vars
foreach($_SESSION as $key => $value) {
  $key = $value;
}

//Get Included Files Included :)
$include_dir = $_SERVER['DOCUMENT_ROOT'] . "/fms/includes/";
$include_config = $include_dir . "config.php";
$include_sql = $include_dir . "sql_connect.php";
require($include_config);
require($include_sql);

//Define some variable stuff
$directory = "http://www.bluecollardigital.com/fms/users/" . $username . "/";
$file_dir = $_SERVER['DOCUMENT_ROOT'] . "/fms/users/" . $username;

$file_name = $file_dir . "/index.html";

//if the file doesn't exist, create it
if(file_exists($file_name) === FALSE) {
  echo "I know that " . $file_name . " doesn't exist<br>";
  touch($file_name) or die("Could Not Create The File");
  chmod($file_name,0666);
  $fh = fopen($file_name, 'w+') or die("Could Not Write To The File");
  $text = "<html>\r\n <head>\r\n <title>". $username . "'s Website</title>\r\n </head>\r\n <body>\r\n </body>\r\n </html>";
  fwrite($fh,$text) or die("Could Not Write To The File");
  $file = fread($fh,filesize($fh)) or die("Could Not READ The File (Instance One)");
  fclose($fh);  

}
else{
  //read the contents of the file to be displayed in the textarea
  $fp = fopen($file_name, 'r') or die("Could Not Open File");
  $file = fread($fp,filesize($fp)) or die("Could Not READ The File (Instance Two)");
  fclose($fp);
}

echo "<div align='center'>";
require("http://www.bluecollardigital.com/header.php");
echo "</div>";
?>
<div align="center">
<form name="htmledit" method="post" action="../../savefile.php">
<input type="hidden" name="file_name" value="index.html">
<textarea rows="10" cols="60" wrap="off"><? echo $file; ?></textarea><br>
<input type="submit" name="submit" value="Save File">
</form>
</div>
</body>
</html>

Thanks again for everyone's help.

VisionsOfCody

I think that this liine

$file = fread($fp,filesize($fp))

should read

$file = fread($fp,filesize($file_name))

have you got the chm version of the manual - you can download it here
http://www.php.net/docs-echm.php

then use it locally on your machine like a standard searchable help file - it's great for syntax

fire_cracker

That seemed to fix the problem. It is now working. Hopefully I can manipulate it so that it does everything I want without much trouble.

Thanks for all the help, I managed to escape this problem without loosing any more hair.