auto routing based on subject

[lplatz]

I have a web form that, based on the subject selected (form field name: subject), the PHP procssing page will direct the form contents to a specific email address. Below is a snippet of the php code. However, what is happening is regardless of the subject selected on the forms page, the email is going to the email1 address. The emails going to the [e-mail] have the correct subject title in the subject field of the email, along with the correct content of the completed form. Thus I'm relatively sure the $subject variable w/in the php processing page is getting the information passed correctly.

Anything obvious jump off the page here? If more code is required, please advise.

<?php
$subject = $_REQUEST['subject'];
if ($subject == 'general' or 'summer programs')
{
$recipient = "[e-mail]";
}
elseif ($subject == 'schedule games' or 'baseball 101' or 'counselor' or 'counselor prospect')
{
$recipient = "[e-mail]";
}
else
{
$recipient = "[e-mail]";
}

(more code blah blah)

mail($recipient, $subject, $msgPBS, "From: $name <$email>");

?>

Thanks; Les

[leatherback]

To adres1?

You are sure it isn't going to adres3?

J.

[lplatz]

Why do you suspect that it would route to the [e-mail]?

I placed in the print($variable) into the code to see what the $recipient variable was being assigned and to no surprise it was assigned the $[e-mail].

This on the surface looks like a pretty straight forward code. Is there some syntax issues that anyone can see?

Thanks - Les

[leatherback]

Well, I am not sure whether you can:

if ($subject == 'general' or 'summer programs')

or whether you should:

if ($subject == 'general' or $subject == 'summer programs')

What also could work:

$subject = $_REQUEST['subject']; 

$recipient = array(
"general" => "[e-mail]",
"general2" => "[e-mail]",
"soccur" => "[e-mail]"
);

$this_email = $recipient[$subject];

J.

[edit]
ps: You used print($recipient) and not print($variable) I assume ;)

I thought email 3, because of the first thing in this post: I would have expected each if to return false.
[/edit]

[lplatz]

Decided to pursue a new path with this solution.

I used the SWITCH statement.

$subject = $_REQUEST['subject'];
switch ($subject)
{
case "general":
case "summer programs":
$recipient = "[e-mail]";
break;
case "schedule games":
case "baseball 101":
case "counselor":
case "counselor prospect":
$recipient = "[e-mail]";
break;
case "select teams":
$recipient = "[e-mail]";
break;
}

My tests with this solution appear to have worked. Thanks for your time and help in review of this code snippet in finding a solution.

Les

[kburger]

if ($subject == 'general' or 'summer programs')

We have 2 statements here:

1. $subject == 'general'
   may be TRUE, may be FALSE

2. 'summer programs'
   this will always be TRUE

if (FALSE or TRUE)
this will always be TRUE

I think you meant:
if ($subject == 'general' or $subject == 'summer programs')
as leatherback suggested

[lplatz]

KBurger... thanks for taking the time to review my if... elseif statements. I will note this for future development efforts.

Best Regards... Les