Weird Timeout Problem

arnette

for ($rowx=0; $rowx<$numrows; $rowx++) {
  $row = "";
  for ($pos=0; $pos<3;) {
    if (($file = readdir($handle)) !== false) {
      if(is_file($dir."/".$file)) {
        $template = new Template;
        $template->load("../templates/gallerypic.tpl");
        $template->replace("link", "pic.php?id=".$id."&pic=".$file);
        $template->replace("thumbnail", "pictures/".$id."/thumbs/".$file);
        $row .= $template->out();
        $pos++;
      }
    }
  }
  $pictures .= "<tr>".$row."</tr>";
}

With the code above, i get a timeout, i dont get it if i remove the if(is_file) line.

However i can do a $var = is_file, but i cant then do a if ($var).

What i am trying to do, obviously, is filter out the directories. I already know the directory names, ".", ".." and "thumbs".

I have tried doing an if ($file != <dirname>) which i can do for one or two directories, put when i try to do it for all 3, it times out again. It does not matter which of the two i chose.

I also tried doing an if (strlen($file)), which works for >2 but not >6

Ive already asked some people and they agree that this is extrememly weird, and i have tested the code on 2 servers.

If anyone can suggest what might be happening id be extrememly appreciative.

Thanks

arnette

by the way, the board replaced some of my code

<img src="images/smilies/wink.gif" border="0" alt="">

is actually a semicolon and close bracket

trevHCS

So the for line should look something like:

for ($pos=0; $pos<3; ) {

Going back to basics on this which I usually find is the easiest debugging solution (especially pre-caffine 🙂), I'm guessing theres a problem with it idenitfying the existance of the file. Therefore I would firstly do (before any of these loops):

echo $dir . "/" . $file

...and ensure that it produces a valid path to a file, eg: $dir hasn't gone walkabouts.

If that works, then something like a test of the readability of that file before the loops, eg:

if (is_readable($dir . "/" . $file)) { 
  echo "found";
}
else { 
  echo "not found";
}

Your problem appears to be that you're only incrementing the inner for loop when you find a file which might be a little dangerous if for some reason it doesn't exist or isn't readable by this script (eg: permissions are wrong).

I'm probably preaching to the choir here, but thats how I'd approach it as it's so easy to miss the simple problem when you get tied up in the more complex stuff.

Trev

Weedpacket

Originally posted by arnette
by the way, the board replaced some of my code
<img src="images/smilies/wink.gif" border="0" alt="">
is actually a semicolon and close bracket [/B]

Easily fixed: it's why there is a "Disable Smilies in This Post" checkbox among the options when you're writing. Yes, it is dumb that it does it in [php] blocks, but I didn't write this forum software!

arnette

ive found the bug guys, it was something stupid, and obvious now that i think about it.

thanks!