Problem: Displaying wrong values

wulfjack

I have the following problem:

In an SMF Board ( Bulletin Board ) a MOD has been installed to display an "Experience Bar" for each user, which is based on the number of Posts.
The way this MOD should work is to calculate the number of posts and a percentage and a graphical display that he needs to reach the next level. For example: if the levels are 0-49, 50-99, 100-250, etc. and a user has 75 posts, the display should show 50% ( 25 / 50 ) That means: he has reached 50% resp. 25 posts of 50 until he reaches the next level ( 100 ). If one has 150 posts it should show 33,3% ( 50 / 150 ).
The actual settings in my Bulletin Board are:

0- 24
25- 50
51- 249
250- 499
500- 999
1000- 1499
1500- 1999
2000- 2499
2500- 3499
3500- >

Everything works absolutely fine up to 1000 posts. Then it displays incorrect values: example: if a user has 1287 posts it displays: 5.15% ( 1287 / 25 ) instead of: 57,4% ( 287 / 500 )

Because I have no knowledge of PHP at all, here is the function that should make it happen and which doesn't work correctly:

[FONT=courier new]//Bar of Experience Mod
function barExp()
{
global $txt, $db_prefix, $settings, $bar_posts, $bar_exps;

$bar_post = $bar_posts;
$bar_nextlevel = 50;
$bar_backlevel = 0;
$bar_newlevel = 50;

$check_req = db_query("
	SELECT minPosts 
	FROM {$db_prefix}membergroups
	ORDER BY minPosts ASC", __FILE__, __LINE__);

while($row_bar = mysql_fetch_array($check_req))
{ 
if ($bar_posts >= $row_bar['minPosts'])
			$bar_backlevel = $row_bar['minPosts'];
}

$check_req = db_query("
	SELECT minPosts 
	FROM {$db_prefix}membergroups
	ORDER BY minPosts DESC", __FILE__, __LINE__);

while($row_bar = mysql_fetch_array($check_req))
{ 
if ($row_bar['minPosts'] > $bar_backlevel)
			$bar_newlevel = $row_bar['minPosts'];
}

$bar_post -= $bar_backlevel;
$bar_nextlevel = $bar_newlevel - $bar_backlevel;

$bar_fill = 0;
$bar_exp = 0;

if ($bar_post > 0)
	$bar_exp = round(sprintf(($bar_post / $bar_nextlevel) * 100),2);

$fill = (int) $bar_exp;

if ($fill)
	$bar_fill = '<img src="' . $settings['images_url'] . '/bar_fill.gif" width="' . $fill . '" height="11">';
else
	$bar_fill = '';

$bar_empty = 100 - $bar_exp;

if ($bar_empty)
	$bar_empty = '<img src="' . $settings['images_url'] . '/bar_empty.gif" width="' . $bar_empty . '" height="11">';
else
	$bar_empty = '';

if ($fill >= 100 || $fill < 1) 
	$bar_exps = '<img src="' . $settings['images_url'] . '/bar_up.gif" width="106" height="5"><br><img src="' . $settings['images_url'] . '/bar_full.gif" width="106" height="11"><br><img src="' . $settings['images_url'] . '/bar_down.gif" width="106" height="5"><br>'. $txt['bar_exp_completed'];
else
	$bar_exps = '<img src="' . $settings['images_url'] . '/bar_up.gif" width="106" height="5"><br><img src="' . $settings['images_url'] . '/bar_left.gif" width="3" height="11">' . $bar_fill . '<img src="' . $settings['images_url'] . '/bar_right.gif" width="3" height="11">' . $bar_empty . '<br><img src="' . $settings['images_url'] . '/bar_down.gif" width="106" height="5"><br>&nbsp;' . $txt['bar_exp_next'] . '<br>&nbsp;' . $bar_exp . '% (' . $bar_post . '/' . $bar_nextlevel . ')';

}
[/FONT]

I hope you can help, as the owner of this MOD does not respond for weeks now.

halojoy

Better start problems when someone has posted 100.000 posts 😃
So somewhere we have to increase multiply with 100.
Try changing $fill >= 100 || $fill < 1

// code removed here
if ($bar_empty) 
$bar_empty = '<img src="' . $settings['images_url'] . '/bar_empty.gif" width="' . $bar_empty . '" height="11">'; 
else 
$bar_empty = ''; 

if ($fill >= 10000 || $fill < 1)

Hope I got something right. I am not totally sure ......
I am not sure where is that trouble.
🙂

wulfjack

Sorry,
I have applied your changes, but for the user who has 1287 posts and where it displays: 5.15% ( 1287 / 25 ) instead of: 57,4% ( 287 / 500 ) it now displays:
514.8% (1.287/25)
and even worse, the graphical bar which I think is based on the percentage is now as wide as half of the screen.

halojoy

Keep the original.
Try change only this line:

if ($fill >= 10000 || $fill < 1)

Hope someone other comes to help us.
I do not quite understand this code and what to do.

😕

I really think you should put this question at Simple Machines Forum.
I know they are good to response with support.
They knows best, and there are special forum for mods.
Maybe even someone else have solve this problem already!

SMF Support community forums

😉

twoeyes

posting this so that it's syntax highlighted and i can see it easier 🙂

//Bar of Experience Mod 
function barExp() 
{ 
global $txt, $db_prefix, $settings, $bar_posts, $bar_exps; 

$bar_post = $bar_posts; 
$bar_nextlevel = 50; 
$bar_backlevel = 0; 
$bar_newlevel = 50; 

$check_req = db_query(" 
SELECT minPosts 
FROM {$db_prefix}membergroups 
ORDER BY minPosts ASC", __FILE__, __LINE__); 

while($row_bar = mysql_fetch_array($check_req)) 
{ 
if ($bar_posts >= $row_bar['minPosts']) 
$bar_backlevel = $row_bar['minPosts']; 
} 

$check_req = db_query(" 
SELECT minPosts 
FROM {$db_prefix}membergroups 
ORDER BY minPosts DESC", __FILE__, __LINE__); 

while($row_bar = mysql_fetch_array($check_req)) 
{ 
if ($row_bar['minPosts'] > $bar_backlevel) 
$bar_newlevel = $row_bar['minPosts']; 
} 

$bar_post -= $bar_backlevel; 
$bar_nextlevel = $bar_newlevel - $bar_backlevel; 

$bar_fill = 0; 
$bar_exp = 0; 

if ($bar_post > 0) 
$bar_exp = round(sprintf(($bar_post / $bar_nextlevel) * 100),2); 

$fill = (int) $bar_exp; 

if ($fill) 
$bar_fill = '<img src="' . $settings['images_url'] . '/bar_fill.gif" width="' . $fill . '" height="11">'; 
else 
$bar_fill = ''; 

$bar_empty = 100 - $bar_exp; 

if ($bar_empty) 
$bar_empty = '<img src="' . $settings['images_url'] . '/bar_empty.gif" width="' . $bar_empty . '" height="11">'; 
else 
$bar_empty = ''; 

if ($fill >= 100 || $fill < 1) 
$bar_exps = '<img src="' . $settings['images_url'] . '/bar_up.gif" width="106" height="5"><br><img src="' . $settings['images_url'] . '/bar_full.gif" width="106" height="11"><br><img src="' . $settings['images_url'] . '/bar_down.gif" width="106" height="5"><br>'. $txt['bar_exp_completed']; 
else 
$bar_exps = '<img src="' . $settings['images_url'] . '/bar_up.gif" width="106" height="5"><br><img src="' . $settings['images_url'] . '/bar_left.gif" width="3" height="11">' . $bar_fill . '<img src="' . $settings['images_url'] . '/bar_right.gif" width="3" height="11">' . $bar_empty . '<br><img src="' . $settings['images_url'] . '/bar_down.gif" width="106" height="5"><br> ' . $txt['bar_exp_next'] . '<br> ' . $bar_exp . '% (' . $bar_post . '/' . $bar_nextlevel . ')'; 
}

halojoy

😉
So what did they say at SMF support forum?
SMF Forums Support community
😉

leatherback

PLease HALO, don't use this forum to get your hits up.

-- DON'T SPAM --

halojoy

Originally posted by leatherback
PLease HALO, don't use this forum to get your hits up.

J.

-- DON'T SPAM --

Sorry J.
I do really not bother any hits.
Just wondered if he had tried to get help of those that should know it best.
Those who have support for SMF software and even a special MOD forum.
There are other unnessary comments postings that more should qualify as 'hits spamming'
No names mentioned.

🙂

wulfjack

I have seen other post and questions answered in the SMF forum rather quick.... I have posted my problem on the 13th and still haven't got an answer yet....

back to my problem:

the values and the corresponding variables that are being displayed incorrect are:
5.15% ( 1287 / 25 )
&bar_exp ( $bar_post / $bar_nextlevel )

even though I do have no knowledge about PHP, I can pretty much understand the logic of this function. What I do not know is the following:
$bar_post -= $bar_backlevel; what is -= doing ( minus equal )

and last but not least I cannot find a place in the whole PHP file that shows me how the variable $bar_post is being filled with 1287 Posts. I searched in all other relevant PHP files and couldn't find it.

halojoy

Originally posted by wulfjack
What I do not know is the following:
$bar_post -= $bar_backlevel; what is -= doing ( minus equal )

and last but not least I cannot find a place in the whole PHP file that shows me how the variable $bar_post is being filled with 1287 Posts. I searched in all other relevant PHP files and couldn't find it.

I did not know about -= , so I went to php.net manual
and found this in 'Assignments operators'
http://se.php.net/manual/en/language.operators.assignment.php

$a += $b;
means same as
$a = $a + $b;

$a -= $b;
would be the same as
$a = $a - $b;

Still, this does not tell where $bar_post is assigned its value, in first place

wulfjack

I was wondering if it possible to add some kind of "debug" in that code. I have created a new table to write records to at certain steps within that PHP-program, but I am getting errors of all kinds, because I am not familiar with PHP programming.... as an example:[FONT=courier new]
$debug_req = db_query("
INSERT INTO {$db_prefix}debug
(ID, subject, Debug_ID, value1, value2, value3, value4)
VALUES ($ID_MEMBER, " 'display_php' ", " 'debug_01' ", $bar_post, $bar_nextlevel, $bar_backlevel, $bar_newlevel));[/FONT]

How would you code that correctly ? and where would it make sense to be placed ?

The intention is to then read the debug table to find what values have been calculated at what step of the program.....

Reasonable ?

wulfjack

I have found the problem ( it's so simple, but was hard to get there ):
I added a line to display the number of posts

echo $bar_post

and it displayed for example: 2.145 instead of 2145

that means all calculations were based on 2.145

by changing the default forum settings to a number format of
1234,00 rather than 1.234,00 everything works now.....

thanks