[Resolved] easy while loop add, brain is frozen

[eviljosh]

Ok what this is supposed to do is go into the database pull out a num rows. Now all I need to do is have a while loop that counts up the amount of rows and then display the name of the person next to the total number. Intead what this does is something like

bob(1)
bob(2)
bob(3)
bob(4)

I need it to just echo out
bob(4)

The thing is there will be multiple names sometimes so I will need it to loop through and grab all the numbers and corresponding names. I know this is easy but I just cant get it for some reason. THanks so much!

function showallfulfillerfororder($ordername,$ordernum,$campaign,$id)
{
	$SQL = "SELECT * FROM fulfillerorder WHERE clientid='$id' AND status!=3 ORDER BY name";

$data=mysql_query($SQL);

$countcampaign = mysql_num_rows($data);

for($t=0; $t < $countcampaign; $t++)
{
	$QueryData=mysql_fetch_assoc($data);


	$a++;
	$show="$QueryData[name]--$a<br>";


	echo($show);

}

}

[leatherback]

Where do you get stuck?

It looks -in a quick glance- reasonable enough to me so far.

Just change:

echo($show);

to

echo $show;

J.

[eviljosh]

Im not really sure why that would work. I just have a programming habit of putting parenthesis around single variable echos.

[LoganK]

lb, I agree with Josh. The extra parenthesis are just a convinience some programmers use.

Josh, I think I might have a solution. Instead of incrementing a counter by 1 and echoing the output each time, why not put the number of times each name pops up in an array, with the name being the key? For example, $names["Bob"] = 4; Then on each iteration of the loop, you could use array_key_exists() to check if the name is already in the array; if so, increment it; else, add it to the array and set the value to 1.

This should work:

function  showallfulfillerfororder($ordername,$ordernum,$cam
paign,$id)
{
    $SQL = "SELECT * FROM fulfillerorder WHERE clientid='$id' AND status!=3 ORDER BY name";

$data = mysql_query($SQL);

$countcampaign = mysql_num_rows($data);

$names = array();

for($t=0; $t < $countcampaign; $t++)
{

    $QueryData=mysql_fetch_assoc($data);

$name = $QueryData[name];

if (array_key_exists($name, $names))
	$names[name] += 1; // or $names[name]++;
else
	$names[name] = 1;

}

foreach ($names as $name => $numTimes)
{
echo "$name -- $numTimes";
}

}

Let me know if it works!

[eviljosh]

hey, thanks for taking a stab at it. I was pretty sure this was the direction it needed to go, i have just been too busy to work on it since this is really just a vanity type function. Anyway im gonna mess with this code and see if i can get it to work.

Right now its displaying "name -- 1"

Only once even when there are multiple names.

[eviljosh]

SOOOOO awesome. Ok just two really simple changes and it works. You forgot to put the dollar signs in the array, probably thinking sql stuff?

And since there was no brackets around the if statement it was acting silly. Anyway, here it is. Thanks, and if you ever need anything programming wise let me know!

function   showallfulfillerfororder($ordername,$ordernum,$campaign,$id) 
{ 
    $SQL = "SELECT * FROM fulfillerorder WHERE clientid='$id' AND status!=3 ORDER BY name"; 

$data = mysql_query($SQL); 

$countcampaign = mysql_num_rows($data); 

$names = array(); 

for($t=0; $t < $countcampaign; $t++) 
{ 

    $QueryData=mysql_fetch_assoc($data); 

$name = $QueryData[name]; 

if (array_key_exists($name, $names)) 
{   

$names[$name] += 1; // or $names[name]++; 
}
else 

$names[$name] = 1; 

} 

foreach ($names as $name => $numTimes) 
{ 
echo "$name -- $numTimes"; 
} 

}

[LoganK]

Yeah, I probably did forget the dollar signs. I've done a lot of PHP work, but everyone can slip up here and there :-)