Pattern Problem

[welshside]

Can anyone help me with this....

I only want Jpeg's submitted, and i can't seem to get the verification method ot work, doh

$img_Pattern = "^{([0-9a-z-_]+).(jpeg)|(jpg)|(JPG)|(JPEG)";}

if ($file) {

$file_name = str_replace(" ","_",$file_name);

if (eregi($img_Pattern, $file_name)) {

include("shrinkimage.php");

$FILENAME="process_fldr/" . $FILENAME;

		} else {

		$FILENAME= "../images/noavatar.gif";

	}

 } else {

	header("Location: add.php?Msg=ONLY JPEG FILE TYPES!");

	}

[devinemke]

if you are going strictly by the file extension:

$pathinfo = pathinfo('/path/to/' . $file_name);
if (isset($pathinfo['extension']) && (strtolower($pathinfo['extension'] == 'jpg' || strtolower($pathinfo['extension'] == 'jpeg')
{
	// allowed
}
else
{
	// not allowed
}

be advised that a JPEG file need not necessarily have the .jpg extension. you may also want to look at $_FILES['userfile']['type'].

[halojoy]

Be advised that a JPEG file need not necessarily have the .jpg extension.
You may also want to look at

$_FILES['userfile']['type']

Yes,
I can name a textfile to 'my_image.jpg' and so it will be allowed to upload.
With other method mentioned, you check for REAL type of file

PS. I often rename my 'deadly_virus.exe' to 'beautiful_image.jpg'
before I attach this file in my emails to my enemies. DS.

[laserlight]

A slight improvement on devinemke's example:

$ext = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
if ($ext == 'jpg' || $ext == 'jpeg') {
	echo 'allowed';
} else {
	echo 'not allowed';
}

Of course, it may be that using the string functions are faster than using pathinfo().

[mrhappiness]

Originally posted by devinemke
$_FILES['userfile']['type'].

contains image/jpeg or image/pjpeg and i don't know what else is possible (depends on os used)
and of course renaming some_lame_text.txt do some_hot_actress.jpg will also result in the file being identifed as jpeg

why not using [man]getimagesize[/man]?

[welshside]

if ($file) {

$ext_=_strtolower(pathinfo($file_name,_PATHINFO_EXTENSION)); 

if_($ext_==_'jpg'_||_$ext_==_'jpeg')_{

$file_name = str_replace(" ","_",$file_name);

include("shrinkimage.php");

$FILENAME="process_fldr/" . $file_name;

		} else {

		header("Location: add.php?Msg=ONLY JPEG FILE TYPES!");

	}

 } else {

	$FILENAME= "../images/noavatar.gif";


	}

[welshside]

yeah the error returned is...

Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING in handle_msg.php on line 17

any ideaS?

[halojoy]

if ($file) {

$ext_=_strtolower(pathinfo($file_name,_PATHINFO_EXTENSION)); 

if_($ext_==_'jpg'_||_$ext_==_'jpeg')_{

$file_name = str_replace(" ","_",$file_name);

include("shrinkimage.php");

$FILENAME="process_fldr/" . $file_name;

		} else {

		header("Location: add.php?Msg=ONLY JPEG FILE TYPES!");

	}

 } else {

	$FILENAME= "../images/noavatar.gif";

}

just to put some color