tables not updating

[Vampirev]

calling all gurus,

im pulling my hair out with this one...

everything seems to be getting parsed etc...but the tables arent being updated.

the test is showing that the variables are getting parsed...just seems the table isnt being updated.

suggestions?

cheers
vamps

<?
include("header.php");

//holds checkdupe function (if email exists)
include("checkdupe.php");


if ($_COOKIE['loggedin'])
{
	$id = $_COOKIE['username'];


	//check for errors


	if ($showerror == "error")
	{
	// check input is correct

	if (!preg_match("/^[a-z ]+$/i", $_REQUEST["editfname"]))
	{
	print("<font color=\"red\">First Name missing</font>");
	include("editfields.php");
	}
	else if (!preg_match("/^[a-z ]+$/i", $_REQUEST["editlname"]))
	{
	print("<font color=\"red\">Last Name Missing</font>");
	include("editfields.php");
	}
	else if (!preg_match("/^[0-9\ ]+[0-9\ ]$/", $_REQUEST["editphone"]))
	{
	Print("<font color=\"red\">Invalid Phone Number</font>");
	include("editfields.php");
	}
	else if (!preg_match("/^[a-z0-9\_\.\-]{2,}\@[a-z0-9\-]{2,}(\.[a-z0-9\-]{2,})+$/i", $_REQUEST["editemail"])) 
	{
	Print("<font color=\"red\">Invalid Email Address</font>");
	include("editfields.php");
	}

	//function checks if email address is set as the current client.. allows dupe (ie no update of email) if not ERROR!
	else if (DupeEmailedit($_REQUEST['editemail']))
	{
	Print("<font color=\"red\">Sorry the Email Address entered is already in the system, please try another.</font>");
	include("editfields.php");
	}
	else if (!$_REQUEST['editstreet']) 
	{
	Print("<font color=\"red\">Please Enter Your Street Address</i></font>");
	include("editfields.php");
	}
	else if (!preg_match("/^[a-z0-9\ ]+[a-z0-9\ ]+[a-z0-9\ ]+[a-z0-9\ ]+$/i", $_REQUEST["editcity"])) 
	{
	Print("<font color=\"red\">Please Enter Your City</font>");
	include("editfields.php");
	}
	else if (!preg_match("/^[a-z]+$/i", $_REQUEST["editstate"])) 
	{
	Print("<font color=\"red\">Please Enter Your State</font>");
	include("editfields.php");
	}
	else if (!preg_match("/^[0-9]+$/", $_REQUEST["editpostcode"])) 
	{
	Print("<font color=\"red\">Please Enter Postcode</font>");
	include("editfields.php");
	}
	else if (!preg_match("/^[a-z]+$/i", $_REQUEST["editcountry"])) 
	{
	Print("<font color=\"red\">Please Enter Your Country</font>");
	include("editfields.php");
	}
	else //if no error update the table
	$errorpass ="ok";
	{



	if ($errorpass == "ok")
	{

	//Testing
	print("fname :".$_REQUEST['editfname']."<br>");
	print("lname :".$_REQUEST['editlname']."<br>");
	print("editphone :".$_REQUEST['editphone']."<br>");
	print("editemail :".$_REQUEST['editemail']."<br>");
	print("editstreet :".$_REQUEST['editstreet']."<br>");
	print("editcity :".$_REQUEST['editcity']."<br>");
	print("editstate :".$_REQUEST['editstate']."<br>");
	print("editpostcode :".$_REQUEST['editpostcode']."<br>");
	print("editcountry :".$_REQUEST['editcountry']."<br>");
	// end testing

	$sql = "UPDATE clientdb SET fname='$editfname', lname ='$editlname', phone = '$editphone' , email = '$editemail' , street = 	'$editstreet' , city = '$editcity' , state = '$editstate' , postcode = '$editpostcode' , country = '$editcountry' where clientid = '$id'";

	$result = mysql_query($sql)
	or die (mysql_error());


	$fullname = ($editfname." ".$editlname);
	$sql = "UPDATE Control SET name='$fullname', email = '$editemail'  where clientid = '$id'";

	$result = mysql_query($sql)
	or die (mysql_error());

	print("<tr><td colspan=\"3\" align=\"center\"><b><font color=\"red\">Data successfully Updated</b></font></td></tr>");
	}
	}
}

else //if form not submitted
{
//main form

include("editfields.php");
	}
}
else // no cookies are set
{
	Print("Sorry you are not logged in <a href=\"home.php\">click here</a> to login");
}



?>
<?include("footer.php");?>

[planetsim]

Try this

mysql_query($sql) or die (mysql_error()); 

instead of

$result = mysql_query($sql)
        or die (mysql_error()); 

Hopefully it should work, also $result is pretty pointless to begin with its never being used.

Ive never fully understood the reason why having that variable there stops Queries like Updating/Insert/Deleting.

[ownedman]

i noticed also that there are alot of include() unctions in your script have you though one of them might cause the error?

[halojoy]

Originally posted by ownedman
i noticed also that there are alot of include() unctions in your script have you though one of them might cause the error?

that is my fault!
maybe can be too many includes, Vampirev 😃

[Vampirev]

he 🙂yeah all includes work ok and have been tested seperatley.

not getting any errors where they shouldnt be..

id if it workd i get the data updated if it doesnt i get the

error msg..

something weird is going on 🙂

although i have the form fields as a seperate include they are parsing..

[leatherback]

Have you echoed the query? So you can see what is actually passed to mysql? And what does the mysql_error() give you?

J.

[Vampirev]

cheers guys shall give everything a go when im "working" tomorrow 🙂

[Vampirev]

ok tried echoing the query

got result = 1 (for both queries)

also tried making the query mysql_query($sql)

rather then $result = mysql_query($sql)

any other suggestions?

[Vampirev]

UPDATE*

forgot to mention im not getting any mysql errors

[halojoy]

Originally posted by Vampirev
ok tried echoing the query
got result = 1 (for both queries)

1, simply means everything went okay.
compare what return result can be from a function:
return 1; = okay / / / return 0; = not okay

[Vampirev]

thought as much...

so in theroy the queries are working...

where do i look next?

[videxx]

Dear Vampire,

after i read all the posts for ur thread.. i want to ask you few questions and give comments about ur codes...

first of all..

y do u need to include a function? while u can just write the codes inside the same page (i mean.. a seperate function after the main function)
e.g., include("checkdupe.php"); or this include("editfields.php");
u just made ur codes complicated and mess around~!

ur error checking is really a mess~~~~

u can use ECHO tho~~ a shorter way to output lines, instead of writing print("bla bla bla"); everytime..

i dun understand y u used $REQUEST while u can use normal method of $GET or $_POST?

in one MySQL method, it is advisable to use CONCATENATE instead of '.' in this code $fullname = ($editfname." ".$editlname);
or.. better yet.. y do u need to combine the fname and lname into fullname while u can jus save the data seperately? and so later, to retrieve the name, u can jus use the CONCATENATE method to combine the fname and lname to become a fullname..

there is a better way to update all fields.. regardless the data is empty.. by using foreach loop instead of ur current method..
$sql = "UPDATE clientdb SET fname='$editfname', lname ='$editlname', phone = '$editphone' , email = '$editemail' , street = '$editstreet' , city = '$editcity' , state = '$editstate' , postcode = '$editpostcode' , country = '$editcountry' where clientid = '$id'";

seriously... from my opinion, ur codes is not well-organized and too complicated to be process..
maybe that is why ur update is not working..

as per say.. i would like to help you with ur codes.. jus tell me ur situation, about the process flow, and i will come up with codes whichever suits, as i will give u my own coding which has been implemented successfully in my system..

Hope i can help you whenever i can.. and i'm sorry if whatever i said earlier in a harsh words...

Have a gud day then..

Warm wishes.. videxx.. 🆒

[halojoy]

okay,
you can introduce a variable $message

<?php
// first in beginning somewhere you set $message = empty
$message = '';

// every elseif like this
elseif (!preg_match("/^[a-z ]+$/i",$_REQUEST["editlname"])) {
print("<font color=\"red\">Last Name Missing</font>");
include("editfields.php");
}

//could be replaced with
elseif (!preg_match("/^[a-z ]+$/i",$_REQUEST["editlname"])) $message="Last Name missing";
elseif ( something )  $message = "something"; 
elseif ( bad error )  $message = "FATAL Error!!!!!"; 

// After all tests are done, you check if $message exist (not still empty)
if ( $message ){ 
echo "<font color='red'>" .$message. "</font>";
include( "editfields.php" );
}

?>

Isnt that nice!

[Vampirev]

ok heres a smaller one that doesnt call anything apart from header / footer..

same thing..updates not happening.

hope this is a lil easier to understand

I apologise for my poorly setout code at this stage but please keep in mind i have been at this for about 2 weeks 🙂

been using $_REQUEST as part of habit when i was using a few diff pages to get things going (one of the php dev guys here told me to use it).. also was told echo is 'old school'

so a few differnt people are to blame 🙂

I seriously appreciate all the help you guys have been giving me...Sure I could ask for code but that would defeat the purpose of learning for myself...im sure ill figure out whats going on eventually..

anyways...thanks again..

<?
include("header.php");






if ($_COOKIE['loggedin'])
{


if ($update == "pw")
	{


	$id = $_COOKIE['username'];
	//check old password matches current pasword
	$sql = "Select * from Control where login = '$id'";

	$result = mysql_query($sql)
	or die (mysql_error());

		while($row=mysql_fetch_array($result))

			{
			$old = ($row['rawpass']);

			if (md5($old) == md5($current))
				{

					if (preg_match("/^[a-z0-9]+$/i", $_REQUEST["pw1"]))
					{
					if ($pw1 == $pw2)		
					{
					//means all is well go ahead and update data

//--------------table update start--------------

$sql = "Update Control Set rawpass = '$pw1' where clientid ='$id'";
mysql_query($sql)
or die (mysql_error());




//---------end--table--update------------------- 

					Print("Thankyou your password has now been updated");
					include("footer.php");
					}
					else //if new passwords dont match
					{
					Print("Sorry the new passwords do not match please try again");

					//print change pw form
					echo '<form name="update" action="changepw.php" method="post"><table class="formtext"><tr><td align="right">Current Password : </td><td><input type="password" name="current" size="23" class="form"></td></tr><tr><td align="right">New Password : </td><td><input type="password" name="pw1" size="23" class="form"></td></tr><td align="right">Confirm Password : </td><td><input type="password" name="pw2" size="23" class="form"></td></tr><td colspan="2" align="right"><input type="submit" value="Update" class="form"><input type="hidden" name="update" value="pw"></form></td></tr></table>';

					//end print form
					include("footer.php");

					}
				}
				else
					{
					Print("New Password Must be at least 5 characters, please try again");

					//print change pw form
					echo '<form name="update" action="changepw.php" method="post"><table class="formtext"><tr><td align="right">Current Password : </td><td><input type="password" name="current" size="23" class="form"></td></tr><tr><td align="right">New Password : </td><td><input type="password" name="pw1" size="23" class="form"></td></tr><td align="right">Confirm Password : </td><td><input type="password" name="pw2" size="23" class="form"></td></tr><td colspan="2" align="right"><input type="submit" value="Update" class="form"><input type="hidden" name="update" value="pw"></form></td></tr></table>';

					//end print form
					include("footer.php");

					}

				}
				else
				{
				Print("Sorry The Current Password was incorrect please try again");
				//print change pw form
				echo '<form name="update" action="changepw.php" method="post"><table class="formtext"><tr><td align="right">Current Password : </td><td><input type="password" name="current" size="23" class="form"></td></tr><tr><td align="right">New Password : </td><td><input type="password" name="pw1" size="23" class="form"></td></tr><td align="right">Confirm Password : </td><td><input type="password" name="pw2" size="23" class="form"></td></tr><td colspan="2" align="right"><input type="submit" value="Update" class="form"><input type="hidden" name="update" value="pw"></form></td></tr></table>';

				//end print form
				include("footer.php");
				}


	}
	}
	else
	{
	//print change pw form
	echo '<form name="update" action="changepw.php" method="post"><table class="formtext"><tr><td align="right">Current Password : </td><td><input type="password" name="current" size="23" class="form"></td></tr><tr><td align="right">New Password : </td><td><input type="password" name="pw1" size="23" class="form"></td></tr><td align="right">Confirm Password : </td><td><input type="password" name="pw2" size="23" class="form"></td></tr><td colspan="2" align="right"><input type="submit" value="Update" class="form"><input type="hidden" name="update" value="pw"></form></td></tr></table>';

	//end print form
	include("footer.php");
	}


}
else
{
Print("Sorry, you are not logged in.<br>Click <a href='http://www.onstageshirts.com.au/home.php'>here</a> to login");
include("footer.php"); 
} 
?>

[halojoy]

<?php

include("header.php");

if ($_COOKIE['loggedin'])
{
	if ($update == "pw")
	{		
		$id = $_COOKIE['username'];
		//check old password matches current pasword
		$sql = "Select * from Control where login = '$id'";
		$result = mysql_query($sql)
		or die (mysql_error());
		while($row=mysql_fetch_array($result))
		{
			$old = ($row['rawpass']);
			if (md5($old) == md5($current))
			{							
				if (preg_match("/^[a-z0-9]+$/i", $_REQUEST["pw1"]))
				{
					if ($pw1 == $pw2)		
					{
                    //means all is well go ahead and update data
                    //----table update start----
                    $sql = "Update Control Set rawpass = '$pw1' where clientid ='$id'";
                    mysql_query($sql)or die( mysql_error() );
                    //---end--table--update---- 
                    Print("Thankyou your password has now been updated");
                    include("footer.php");
					}
					else //if new passwords dont match
					{
					Print("Sorry the new passwords do not match please try again");
					//print change pw form
					//end print form
					include("footer.php");
					}
				}
				else
				{
					Print("New Password Must be at least 5 characters, please try again");
					//print change pw form
					//end print form
					include("footer.php");
				}
			}
			else
			{
				Print("Sorry The Current Password was incorrect please try again");
				//print change pw form
				//end print form
				include("footer.php");
			}
		}
	}
	else
	{
		//print change pw form
		//end print form
		include("footer.php");
	}
}
else
{
          Print("Sorry, you are not logged in.<br>Click <a href='home.php'>here</a> to login");
          include("footer.php"); 
}

?>

Yes, should work.
But only assuming those variables you test in 'if' are correctly set somewhere.

[Vampirev]

mm thought it would work in theory but having same tables not being updated issue

[halojoy]

'but only assuming those variables are set correctly ....'
Lets see:

/***
if ($_COOKIE['loggedin'])
if ($update == "pw")
while($row=mysql_fetch_array($result))
if (md5($old) == md5($current))
if (preg_match("/^[a-z0-9]+$/i", $_REQUEST["pw1"]))
if ($pw1 == $pw2)
***/
/*** variables used in: if ( conditions )
$_COOKIE['loggedin']
$update
$row
$old
$current
$_REQUEST["pw1"]
$pw1
$pw2
Basically is enough, you haven't defined/set one of those properly
***/

[Vampirev]

[current] => qwerty
[pw1] => blah1
[pw2] => blah1
[update] => pw
[name] => Mich Test
[loggedin] => True
[username] => mb1000
[password] => d8578edf8458ce06fbc5bb76a58c5ca4

$update is set when the form is submitted.

$old is obviously set as it is called to check database .. (and this part works)

hrm....

[videxx]

Dear Halojoy

you can introduce a variable $message.. Isn't nice

erk.. i didnt intend to make the code to be changed bluntly.. i have some better way of doing it.. hmpphh :glare: and i can show you how i did..

videxx..

[videxx]

Dear Vamp..

first of all.. i didnt mean to hurt ur feelings.. that's y i did apologize to you if i ever said harsh words to you...

ok then.. it's nobody fault.. let's jus say, u are learning new things.. in various ways.. cheers~ 😃

so.. rite now.. what's ur problem again? can u please explain to me..? i'm lost here.. sorry..

videxx